Юрий, can you take a look?
JIRA - https://issues.apache.org/jira/browse/IGNITE-13450
PR - https://github.com/apache/ignite/pull/8252
вт, 15 сент. 2020 г. в 08:59, Dmitrii Ryabov :
>
> Ok, I created a ticket [1].
>
> [1] https://issues.apache.org/jira/browse/IGNITE-13450
>
> пн,
Ok, I created a ticket [1].
[1] https://issues.apache.org/jira/browse/IGNITE-13450
пн, 14 сент. 2020 г. в 14:59, Юрий :
>
> Dmitrii, seems you are right and we can go with new separate event
>
> пн, 7 сент. 2020 г. в 23:53, Dmitrii Ryabov :
>
> > Any objections to create a
Any objections to create a separate event, which will be fired before
executing a query?
ср, 2 сент. 2020 г. в 22:33, Dmitrii Ryabov :
>
> I agree with Max, we need to add a separate event for starting query
> execution, and EVT_CACHE_QUERY_EXECUTED shouldn't be deprecated,
&
I agree with Max, we need to add a separate event for starting query
execution, and EVT_CACHE_QUERY_EXECUTED shouldn't be deprecated,
because it is another case - it is fired when cache query was
successfully finished.
> Would the event notification be synchronous? In which thread?
As Max said, sy
Hello!
Nikolay, yes, but currently, we can't declare user attributes through
control.sh.
пн, 16 мар. 2020 г., 12:06 Nikolay Izhikov :
> Hello, Mikhail.
>
> Can you, please, double-check link to the ticket?
>
> For now it’s a IGNITE-12049 Add user attributes to thin clients which is
> resolved.
>
eds to be present to
> deserialize.
> That's why arbitrary objects should not be allowed in the handshake: in
> most cases they can't be decoded.
>
> On Thu, Jan 23, 2020 at 2:27 PM Dmitrii Ryabov
> wrote:
>
> > Alexei, yes, compactFooter i
, 2020 at 2:08 PM Alexei Scherbakov <
> alexey.scherbak...@gmail.com> wrote:
>
> > > Footer is checked in postWrite - much later class descriptor check.
> >
> > Well, my understanding was a binary object with compact footer = false is
> > totally standalone entity
> Even if compact footer is disabled ?
Footer is checked in postWrite - much later class descriptor check.
чт, 23 янв. 2020 г., 12:23 Alexei Scherbakov :
> чт, 23 янв. 2020 г. в 12:17, Dmitrii Ryabov :
>
> > > The protocol must be language-agnostic. If we add some features the
sword (like git works with
> GitHub
> > >> > > tokens).
> > >> > >
> > >> > > For now I don't see a reason to include attributes into the
> > handshake
> > >> > > message.
> > >> > >
> > >> > > O
em, can you explain it in more
> detail?
> > What do we solve by adding a map with arbitrary stuff to the client
> > protocol handshake?
> >
> > On Wed, Jan 22, 2020 at 5:02 PM Dmitrii Ryabov
> > wrote:
> >
> > > Hello, Igniters!
> > >
> &g
Hello, Igniters!
I want to add the possibility of sending user defined attributes from thin
clients. And check them inside custom authenticator during handshake [1].
There is an issue in hardcoded binary writer for JDBC and `IgniteClient`.
This writer searches for a classes in the JDK and
META-IN
at
> the PR and merge the fix if you have no objection.
>
> Thanks,
> S.
>
> чт, 26 сент. 2019 г. в 12:10, Dmitrii Ryabov :
>
> > I used same ticket [1] in PR [2] name. Tests [3] are ok, I didn't found
> > stable failures.
> >
> > Pavel, can yo
34438&buildTypeId=IgniteTests24Java8_RunAll
ср, 25 сент. 2019 г., 17:54 Вячеслав Коптилин :
> Hi Dmitrii,
>
> > I prepared fix, waiting for TC results.
> Thank you a lot!
>
> Could you please share the JIRA ticket?
>
> Thanks,
> S.
>
>
> ср, 25 сент. 2019 г. в 17
Bug looks strange. I prepared fix, waiting for TC results.
Pavel, I described changes in the ticket.
ср, 11 сент. 2019 г., 15:10 Dmitrii Ryabov :
> Ok, I'll do it.
>
> ср, 11 сент. 2019 г., 14:23 Pavel Kovalenko :
>
>> Hi Dmitrii,
>>
>> Thank you for contribution. I'll take a look at it. Could you please
>>
Ok, I'll do it.
ср, 11 сент. 2019 г., 14:23 Pavel Kovalenko :
> Hi Dmitrii,
>
> Thank you for contribution. I'll take a look at it. Could you please
> describe in the ticket what changes have you done besides version update
> and why they are needed?
>
> ср, 11
Hello, Igniters!
I want to update Apachee Zookeeper version from 3.4.13 to 3.5.5 and Apache
Curator from 2.9.1 to 4.2.0 as part of IGNITE-11094 [1]. Any objections?
[1] https://issues.apache.org/jira/browse/IGNITE-11094
Yakov,
I checked hazelcast - it uses multicast by default.
чт, 28 февр. 2019 г., 14:31 Stanislav Lukyanov :
> Yakov,
>
> Our product is for engineers sitting in one office.
> Companies which use Ignite have many engineers running Ignite on their
> laptops the same way
> as companies that make ch
Hello, Igniters!
Code is ready and reviewed, tests are passed.
Can we make final decision about this change? Do we really need it? [1]
Pros:
* Multicast ipFinder adds some instability when several persons try & debug
samples or evaluate a new Ignite version at the same local network.
* Speedup
27;s
> failure had been fixed.
>
> You should verify that getting an unhandled exception in any system thread
> leads to the failure of currently running test.
>
> On Fri, Jan 11, 2019 at 12:16 PM Dmitrii Ryabov
> wrote:
>
>> Ilya, can you check your test on current implemen
ad. If not, I can do it later.
>
> пн, 10 дек. 2018 г. в 14:23, Anton Vinogradov :
>
>> Dmitriy,
>>
>> You confirmed that fix should be reverted and reworked last Friday.
>> Why it still not reverted?
>>
>> On Mon, Dec 10, 2018 at 12:46 AM Dmitrii Ryabo
Hi,
Anton, can you review ticket for examples [1]?
[1] https://issues.apache.org/jira/browse/IGNITE-6826
пн, 24 дек. 2018 г., 15:23 Anton Vinogradov a...@apache.org:
> Folks,
>
> The important thing here is that 99% of "final static" ip-finders were
> removed. (~800 pcs.)
> Non-static, mostly,
e.
>
> I'm not sure which way of ignoring will be best.
>
> пн, 17 дек. 2018 г. в 17:02, Anton Vinogradov :
>
> > Dmitrii,
> >
> > My question was mostly about how to mute test properly.
> >
> >
> > On Mon, Dec 17, 2018 at 4:27 PM Dmitrii Ryab
t; > > >
> > > > Now muted test count was decreased from 3540 to 3408
> > > >
> > >
> > https://ci.ignite.apache.org/project.html?projectId=IgniteTests24Java8&tab=mutedProblems&branch_IgniteTests24Java8=%3Cdefault%3E
>
Hello, Igniters!
Our Bot got new functionality - it shows tests muted on TeamCity and their
ticket status [1].
So, we can see forgotten mutes for resolved tickets now.
Igniters with rights to unmute tests on TC - please, check this page
periodically for forgotten mutes.
[1] https://mtcga.gridga
on.
> > > > > Such merges should NEVER happen again.
> > > > > Please, next time make sure that code you merge has no massive
> > > > duplication
> > > > > and fixes without proper reason investigation.
> > > > > Committer alwa
e that copy-paste minimization is not the final
> step.
> >
> > On Thu, Dec 6, 2018 at 1:24 PM Павлухин Иван
> wrote:
> >
> > > Dmitrii Ryabov,
> > >
> > > Your comments sounds reasonable to me. Marker base class approach
> > > looks
t; > > > > > > >
> > > > > > > > > Thanks, as an improvement to the code, this may be better.
> > But
> > > > > still, it
> > > > > > > > > is
> > > > > > > > > not a reason to rever
n.
> >
> >
> > вт, 4 дек. 2018 г. в 23:21, Anton Vinogradov :
> >
> >
> > > Dmitrii,
> > >
> > > The solution is not clear to me.
> > > In case you expect the failure then a correct case is to wrap it with
> > > try-catch
t; Could you please explain the reason of explicit set of 100+
> > NoOpFailureHandlers?
> >
> >
> > вт, 4 дек. 2018 г. в 19:12, Dmitrii Ryabov :
> >
> > > Hello, Igniters!
> > >
> > > Today the test framework's default no-op failure handler w
Hello, Igniters!
Today the test framework's default no-op failure handler was changed to the
handler, which stops the node and fails the test.
Over 100 tests kept no-op failure handler by overrided
`getFailureHandler()` method.
If you'll found a problem or something unexpected - write here or in
Hello, Igniters,
I want to do IGNITE-10165 (Gather query stats and expose interfaces to
access it) [1], if you don't mind.
Yury, Vladimir, did you planned something about statistics implementation?
Also, can you point out in which sessions should be available option to
turn on/off stats gatherin
0
вт, 27 нояб. 2018 г. в 02:33, Alexey Kuznetsov :
>
> +1
> Do not forget notification from GitBox too!
>
> On Tue, Nov 27, 2018 at 2:20 AM Zhenya wrote:
>
> > +1, already make it by filers.
> >
> > > This was discussed already [1].
> > >
> > > So, I want to complete this discussion with moving ou
hub.com/apache/ignite/commit/d67c5bf
> > [2] https://github.com/apache/ignite/commit/9bb9c04
> >
> >
> > В Пн, 19/11/2018 в 13:36 +0300, Dmitrii Ryabov пишет:
> > > I agree to revert and make fix for 2.8. So, we will have more time to
> > test
> > > it.
>
d for me.
> > > > > And it's not obvious for me how to fix this issue in a short period
> > of
> > > > > time.
> > > > > Especially, code deals with recursion and other things that can
> lead
> > to
> > > > > very dange
d instead of
> Wrapper [p=Child [b=0, super=Parent [a=0]]]
> for classes with inheritance that use S.toString(SomeClass.class, this,
> super.toString()) embedded to some other object.
>
> Dmitrii Ryabov, I've reverted two commits related to IGNITE-602 and
> IGNITE-9209 ticke
> waitForCondition(lsnr::check, timeout);
Agree, it is more convenient to use.
пт, 26 окт. 2018 г. в 13:01, Pavel Pereslegin :
>
> Nikita,
> personally, I don’t like that "check()" throws an AssertionError, but in
> the case of a composite listener, it will indicate which of the conditions
> did no
I tried to replace default no-op handler by handler stopping node and
failing the test.
I've returned the no-op handler in many classes because critical
situations are expected behavior. But PR still have a lot of failed
tests and suites. In some tests, I can't understand a failure reason.
I'm no
+1 to
> leave abbreviations for common words with single meaning. For example,
group -> grp, transaction -> tx, context -> ctx.
And optional for the multi-words.
ср, 17 окт. 2018 г. в 14:54, Ilya Lantukh :
> + 1 from me to make abbreviations optional.
>
> On Wed, Oct 17, 2018 at 1:00 PM Sergey A
Hello, Igniters!
You've all seen the messages with new failures from MTCGA.Bot.
But the bot can also be used to analyze TeamCity runs and to print tests
analysis results in the JIRA ticket.
Now you can learn how to work with the bot at the wiki page [1].
[1]
https://cwiki.apache.org/confluence/
riy Pavlov
>
> пн, 24 сент. 2018 г. в 15:39, Dmitrii Ryabov :
>
>> I signed up. My username - somefire.
>>
>> 2018-09-24 15:08 GMT+03:00 Dmitriy Pavlov :
>>
>>> Dmitrii,
>>>
>>> could you please sign up to the wiki and share your ID. I wi
I signed up. My username - somefire.
2018-09-24 15:08 GMT+03:00 Dmitriy Pavlov :
> Dmitrii,
>
> could you please sign up to the wiki and share your ID. I will set
> necessary permissions.
>
> Sincerely,
> Dmitriy Pavlov
>
> пн, 24 сент. 2018 г. в 14:57, Dmitrii Rya
Hello, Igniters!
I propose to update the "How to Contribute" page to include TeamCity
Helper's JIRA commenting functionality into contribution process.
This will speedup review process by highlighting new failures, timeouts and
othe critical failures in the JIRA ticket.
For example, we can repl
Hello, Igniters!
I propose to create page about TeamCity Helper on the wiki and move here
information about Helper from the MTCGA page.
Also, I want to add instruction about how to use TCH to comment JIRA:
1. Start "Run All" build for PR on TeamCity.
2. Check failures and fix possible blockers.
Hi, Dmitiy,
I created ticket [1] 3 days ago.
[1] https://issues.apache.org/jira/browse/INFRA-17032
2018-09-19 20:51 GMT+03:00 Dmitriy Pavlov :
> Hi Dmitriy Ryabov,
>
> could you please create and share INFRA ticket to disable comment
> forwarding to the dev list?
>
> Sincerely,
> Dmitriy Pavlov
itriy G., Ivan, would it be
> reasonable to revert commit?
>
> Dmitriy Ryabov, is it related to recent fix or is it a standalone problem?
>
> Sincerely,
> Dmitriy Pavlov
>
> пн, 17 сент. 2018 г. в 18:45, Dmitrii Ryabov :
>
> > Looks like problem I had described in the tic
Hello, Igniters!
If you din't saw the "Apache Ignite TeamCity Bot: Features overview"
webinar, you should know:
Ignite TC Bot can detect failures appeared in the Pull Request and comment
JIRA ticket with this failures.
If PR has no new failures - bot will comment about the absence of such
failure
Looks like problem I had described in the ticket.
https://issues.apache.org/jira/browse/IGNITE-7618?focusedCommentId=16506923&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16506923
2018-09-15 12:01 GMT+03:00 Dmitriy Pavlov :
> Dmitriy G, Ivan B,
>
> could you pl
, Nikolay Izhikov :
> >
> > > Hello, Dmitrii.
> > >
> > > Can you give a link to detailed description of this feature?
> > >
> > > Actually, I wonder if someone except bit developers know how to use it
> > >
> > > чт, 13 сент. 2018 г., 22:46 Dmit
Hello, Igniters!
We've improved tests analysis in the TeamCity Helper.
Now, when you view PR analysis, you can see a table with possible blockers
- failed tests and suites, that most likely appeared in the pull request.
Yep, it's working. Thank you.
2018-09-13 19:09 GMT+03:00 Dmitriy Pavlov :
> Hi Dmitriy,
>
> Sure, I agree with extra permissions assignment. Done.
>
> Could you please check if you can manage your builds now?
>
> Sincerely,
> Dmitriy Pavlov
>
> чт, 13 се
Hi, Dmitriy,
Can you give me rights to stop my builds on TeamCity? Working on the TCH, I
run a lot of builds, and I don't like to ask other people to stop builds
too often.
2018-09-10 23:53 GMT+03:00 Dmitrii Ryabov :
> Hi, Dmitriy,
>
> I made PRs in my fork for test purposes. Real
fork, not in
> https://github.com/apache/ignite-teamcity-bot
> Could you please create unmerged PR in GitHub mirror so it could be merged
> after reviewing by the apply-pr script.
>
> Sincerely,
> Dmitriy Pavlov
>
> пн, 3 сент. 2018 г. в 18:20, Dmitrii Ryabov :
>
> >
Hi, Igniters!
I have an implementation for savepoints support inside of transactions,
which was reviewed by Boikov a year ago.
It allows us to rollback piece of the transaction, not whole tx.
Current restrictions:
* Doesn't work with near caches.
* MVCC should be disabled.
MVCC was merged r
-flaky failures detection. E.g
> failure occurred after 10 commits merged to master. How to find out bad
> commit? Automatic location (analog of bisecting, but using TC test) will be
> really helpful. But it is not a simple contribution.
>
> пт, 24 авг. 2018 г. в 18:35, Dmit
> 2. MTCGA messages should mention the commiter and authors of the "bad"
commit.
But this is not always possible.
2018-08-30 13:04 GMT+03:00 Dmitrii Ryabov :
> Vladimir, your idea is good, but...
> 1. Who should be mentioned in messages like PR or JIRA ticket creation? As
gt; to
> > > use.
> > > > When you subscribe to the dev list for the first time, you don't have
> > any
> > > > history on your email,
> > > > and the archive is polluted with messages, sent by bots.
> > > >
> > > > Some v
Thank you.
2018-08-29 13:33 GMT+03:00 Alexey Goncharuk :
> Certificates are updated, TC is up and running.
>
> ср, 29 авг. 2018 г. в 12:55, Dmitrii Ryabov :
>
> > Hi, Igniters!
> >
> > Who can refresh TeamCity's security certificate?
> >
>
Hi, Igniters!
Who can refresh TeamCity's security certificate?
Modern mail services allow users to filter messages. You can easily filter
out bot messages.
2018-08-29 11:48 GMT+03:00 Denis Mekhanikov :
> Igniters,
>
> We have a lot of threads, created by bots on the dev list.
> Currently messages are sent by JIRA, GitHub and MTCGA bots. Maybe, some
> others
iness
> border was not changed, so more test now will be considered as flaky.
> - Now 4 builds required to be failed or timed out in a row before
> notification is sent.
>
> Sincerely,
> Dmitriy Pavlov
>
> чт, 23 авг. 2018 г. в 17:09, Dmitrii Ryabov :
>
> > Hi, Dmit
2. Create a button by clicking on which the info about 0% tests will be
written in the PR.
3. Replace button by webhook for TeamCity (for Run All), which will start
analysis on TCH and write results in the PR.
4. ...
What do you think?
2018-08-22 8:55 GMT+03:00 Dmitrii Ryabov :
> I think we shou
;
> Sincerely,
> Dmitriy Pavlov
>
> вт, 21 авг. 2018 г. в 19:22, Dmitrii Ryabov :
>
> > I think plugin will be more pretty looking, but comments can contain any
> > information, so they can be more usefull. I agree with your idea to
> create
> > bot instead of plug
ntified by the Ignite TC Bot by master recent
> fail rate = 0.0%. The same rule can be applied to timed out suites.
>
> Sincerely,
> Dmitriy Pavlov
>
> вт, 21 авг. 2018 г. в 16:16, Dmitrii Ryabov :
>
> > Hello, Igniters!
> >
> > I want to suggest improvement f
Hello, Igniters!
I want to suggest improvement for TeamCity Helper [1] – we need an easy way
to get list of failed tests that don’t fall in the master branch. These
tests should:
* fail in the PR
* not fail in the master
* not be flaky.
Also, I want to suggest to create a GitHub plugin, which wil
We have ticket [1] for this change.
[1] https://issues.apache.org/jira/browse/IGNITE-6826
2018-08-01 15:58 GMT+03:00 Alexey Zinoviev :
> Great, sometimes I made it manually in local tests. It will be great to
> change the situation.
>
> 2018-08-01 18:22 GMT+06:00 Stanislav Lukyanov :
>
> > +1.
>
e value to the product. It doesn't support
> cross-cache transactions, consumes a lot of memory, much slower than any
> widely-used concurrent hash map. Let's go the same way as Java - mark LOCAL
> cache as "deprecated for removal", and then remove it in 3.0.
>
> On Wed,
Vladimir, do we have a ticket for cross-cache transactions with LOCAL
cache? I can't find it. In my task I met this situation in tests and I want
to fail such tests with link to this ticket. Also documentation in readme.io
say nothing about cross-cache failures with LOCAL cache.
ср, 25 июл. 2018 г
+1 to make LOCAL as filtered PARTITIONED cache. I think it would be much
easier and faster than fixing all bugs.
2018-07-25 11:51 GMT+03:00 Dmitriy Setrakyan :
> I would stay away from deprecating such huge pieces as a whole LOCAL cache.
> In retrospect, we should probably not even have LOCAL cac
x27;s not the case when we should change default
>>> behaviour.
>>> So, #1 and make it default in 3.0.
>>>
>>> On Wed, Jun 13, 2018 at 6:46 PM, Dmitrii Ryabov
>>> wrote:
>>>
>>> Vote for #2. I think no one will change this defaul
Vote for #2. I think no one will change this defaults in configuration in
#1.
2018-06-13 18:29 GMT+03:00 Anton Vinogradov :
> Vote for #2 since it can shed light on hidden bug at production.
>
> ср, 13 июн. 2018 г. в 18:10, Alexey Goncharuk >:
>
> > Igniters,
> >
> > Bumping up this discussion.
71 matches
Mail list logo
