I think plugin will be more pretty looking, but comments can contain any information, so they can be more usefull. I agree with your idea to create bot instead of plugin.
As for fail rate - I'm not sure it is working as you describe. I'm looking on my runAll [1]. There is `IgniteCacheGroupsTest.testCacheApiTxReplicated` in `Cache 3` suite with fail rate = 0.0%. But it is flaky and fails in master branch [2]. [1] https://mtcga.gridgain.com/pr.html?serverId=apache&suiteId=IgniteTests24Java8_RunAll&branchForTc=pull%2F4519%2Fhead&action=Latest [2] https://ci.ignite.apache.org/project.html?projectId=IgniteTests24Java8&buildTypeId=&tab=testDetails&testNameId=5628470782089555961&order=TEST_STATUS_DESC&branch_IgniteTests24Java8=__all_branches__&itemsCount=50 2018-08-21 18:00 GMT+03:00 Dmitriy Pavlov <dpavlov....@gmail.com>: > Hi Dmitrii, > > I'm not sure we're able to install Github apps to Apache mirrors. > > The simplest solution, what can be as efficient as a plugin, is fake MTCGA > bot account in Github, which will provide PR comments using Github program > interface. What do you think? > > A new test failure can be identified by the Ignite TC Bot by master recent > fail rate = 0.0%. The same rule can be applied to timed out suites. > > Sincerely, > Dmitriy Pavlov > > вт, 21 авг. 2018 г. в 16:16, Dmitrii Ryabov <somefire...@gmail.com>: > > > Hello, Igniters! > > > > I want to suggest improvement for TeamCity Helper [1] – we need an easy > way > > to get list of failed tests that don’t fall in the master branch. These > > tests should: > > * fail in the PR > > * not fail in the master > > * not be flaky. > > > > Also, I want to suggest to create a GitHub plugin, which will notify PR > if > > it has such tests. PR will have a marker, which allows/prohibits merge. > > This marker will be shown near PR conflicts. > > > > Allowing marker will be shown in case: > > * no new fails. > > > > Prohibiting marker will be shown in cases: > > * new fails – tests must be fixed. > > * new timed out test suite – suite should be restarted or tests must be > > fixed. > > * runAll wasn’t launched – tests must be launched. > > > > This will make test checks much faster and easier. Also, this will > decrease > > the number of merges with new failed tests made by inattention to the > > tests. > > > > Further, we can expand the plugin by adding new checks, showing PR > quality. > > > > [1] https://github.com/apache/ignite-teamcity-bot > > >
