April 10, 2019 at 9:30 AM
> *To: *Matt Cheah
> *Cc: *Anton Okolnychyi , "dev@iceberg.apache.org" <
> dev@iceberg.apache.org>
> *Subject: *Re: Style guidelines proposal for Iceberg
>
>
>
> I merged #152. I think it would be great to get more reviews on #153 and
>
, April 10, 2019 at 9:30 AM
To: Matt Cheah
Cc: Anton Okolnychyi , "dev@iceberg.apache.org"
Subject: Re: Style guidelines proposal for Iceberg
I merged #152. I think it would be great to get more reviews on #153 and others
that have a lot of changes.
On Wed, Apr 10, 2019 at 8:50
signment of these issues.
>
>
>
> -Matt Cheah
>
>
>
> *From: * on behalf of Anton Okolnychyi <
> aokolnyc...@apple.com>
> *Date: *Wednesday, April 10, 2019 at 2:00 AM
> *To: *"dev@iceberg.apache.org"
> *Cc: *"rb...@netflix.com" , Matt Che
-Matt Cheah
From: Ryan Blue
Reply-To: "rb...@netflix.com"
Date: Friday, March 22, 2019 at 9:27 AM
To: Matt Cheah
Cc: "dev@iceberg.apache.org"
Subject: Re: Style guidelines proposal for Iceberg
Thanks for working on this, Matt! If I understand correctly, the checks are
.apache.org <mailto:dev@iceberg.apache.org>"
> mailto:dev@iceberg.apache.org>>
> Subject: Re: Style guidelines proposal for Iceberg
>
> Thanks for working on this, Matt! If I understand correctly, the checks are
> run as part of the build, so Travis CI builds will
discussion as well.
-Matt Cheah
From: Ryan Blue
Reply-To: "rb...@netflix.com"
Date: Friday, March 22, 2019 at 9:27 AM
To: Matt Cheah
Cc: "dev@iceberg.apache.org"
Subject: Re: Style guidelines proposal for Iceberg
Thanks for working on this, Matt! If I understand c
Thanks for working on this, Matt! If I understand correctly, the checks are
run as part of the build, so Travis CI builds will fail for style
violations?
Where should we discuss the specific conventions? Would you prefer in this
thread or on the PR?
On Thu, Mar 21, 2019 at 5:07 PM Matt Cheah wro
