Thanks for this effort, Matt! I would be interested to help applying this throughout the code base. Let me know if there is anything I can do.
Cheers, Anton > On 22 Mar 2019, at 17:36, Matt Cheah <mch...@palantir.com> wrote: > > The checks would be run as part of the build, and would fail for any style > violations. > > Discuss the conventions on the PR if you find particular changes that we > should discuss. I included a summary of the common changes in the PR > description – feel free to quote these and bring them up for discussion as > well. > > -Matt Cheah > > From: Ryan Blue <rb...@netflix.com <mailto:rb...@netflix.com>> > Reply-To: "rb...@netflix.com <mailto:rb...@netflix.com>" <rb...@netflix.com > <mailto:rb...@netflix.com>> > Date: Friday, March 22, 2019 at 9:27 AM > To: Matt Cheah <mch...@palantir.com <mailto:mch...@palantir.com>> > Cc: "dev@iceberg.apache.org <mailto:dev@iceberg.apache.org>" > <dev@iceberg.apache.org <mailto:dev@iceberg.apache.org>> > Subject: Re: Style guidelines proposal for Iceberg > > Thanks for working on this, Matt! If I understand correctly, the checks are > run as part of the build, so Travis CI builds will fail for style violations? > > Where should we discuss the specific conventions? Would you prefer in this > thread or on the PR? > > On Thu, Mar 21, 2019 at 5:07 PM Matt Cheah <mch...@palantir.com > <mailto:mch...@palantir.com>> wrote: >> Hi everyone, >> >> A prerequisite for us to release Iceberg is to have proper style guidelines >> that are enforced in continuous integration. I would like to propose adding >> code linting using an open-source linting toolkit called Baseline >> [github.com] >> <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_palantir_gradle-2Dbaseline&d=DwMFaQ&c=izlc9mHr637UR4lpLEZLFFS3Vn2UXBrZ4tFb6oOnmz8&r=hzwIMNQ9E99EMYGuqHI0kXhVbvX3nU3OSDadUnJxjAs&m=K0Dm15Lx_yNduH68j7QgZiQZq5hqz44AhUi4ObrML80&s=DUGA0qbk25bjBQu5D7PGpIVkiK9BQyjoH5inFAkNu84&e=>. >> >> I have submitted a pull request [github.com] >> <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apache_incubator-2Diceberg_pull_143&d=DwMFaQ&c=izlc9mHr637UR4lpLEZLFFS3Vn2UXBrZ4tFb6oOnmz8&r=hzwIMNQ9E99EMYGuqHI0kXhVbvX3nU3OSDadUnJxjAs&m=K0Dm15Lx_yNduH68j7QgZiQZq5hqz44AhUi4ObrML80&s=IVj85rAKzD80_VyUhj5ggullU7aTqukD48adtl20qrM&e=> >> to integrate Baseline with the iceberg-api module. In that pull request, I >> describe some of the style conventions that were adopted that were not >> enforced before, as well as cases in which we deviate from Baseline’s style >> guidelines in favor of Iceberg’s prior opinions. >> >> Please look over the pull request and the proposed changes, and provide any >> feedback you may have on this mailing list thread or in pull request >> comments. >> >> Once we’re satisfied with the style rules we’re committed to holding to, I >> can submit patches to apply linting to all of the other modules, but would >> certainly appreciate help in working through these. Let me know if you would >> be interested in contributing to this effort as well. >> >> Thanks, >> >> -Matt Cheah > > > > -- > Ryan Blue > Software Engineer > Netflix
