Re: Remove deprecated table properties

Hey Steven, That makes sense. We can be gentle since there is no real pressure, but it would be nice to get this cleaned up at some point. I want to ensure everyone is comfortable with the deprecation and removal process of table properties. I've updated the PR

Re: Remove deprecated table properties

> When you migrate a table, I don't think everyone cleans up the old properties That is exactly the scenario we are trying to guard against. Maybe old stables are still using those deprecated properties. Hence we want to guard against silent behavior change. > and then jobs start failing. Warnin

Re: Remove deprecated table properties

I'm hesitant to fail the job. When you migrate a table, I don't think everyone cleans up the old properties, and then jobs start failing. Another approach is to warn until 2.0, and then remove them: https://github.com/apache/iceberg/pull/12315 LMKWYT Kind regards, Fokko Op di 18 feb 2025 om 16:

Re: Remove deprecated table properties

Also, as an idea, REST catalog services could return an error if those deprecated properties are being set. Thoughts? On 18.02.25 16:21, Robert Stupp wrote: Agree with both Steve's. Personally, I'm okay with removing those properties - but using the proposed phased approach. On 17.02.25 23:

Re: Remove deprecated table properties

Agree with both Steve's. Personally, I'm okay with removing those properties - but using the proposed phased approach. On 17.02.25 23:25, Steven Wu wrote: I have some concerns on the issue of silent behavior change that Steve Zhang raised in the PR comment. E.g., users may set the location base

Re: Remove deprecated table properties

I have some concerns on the issue of silent behavior change that Steve Zhang raised in the PR comment. E.g., users may set the location based on the deprecated table property, With this change, it would silently switch to a new location. This can potentially mess up orphan file cleanup etc. Maybe

Re: Remove deprecated table properties

+1 for removing. Thanks for taking up the cleanup duty! I looked up the usage for the property and its string value with github search, and confirmed that they are not used. Also, for reference, here are the previous related PRs: https://github.com/apache/iceberg/pull/3094 https://github.com/apac

Re: Remove deprecated table properties

+1 to remove them. Yufei On Mon, Feb 17, 2025 at 1:26 PM Steve Zhang wrote: > Thanks Fokko for removing deprecated properties! > > Just want to highlight the worst case for tables with old configuration > and not aware of this deprecation might experience silent behavior change. > But consideri

Re: Remove deprecated table properties

Thanks Fokko for removing deprecated properties! Just want to highlight the worst case for tables with old configuration and not aware of this deprecation might experience silent behavior change. But considering this has been deprecated for past 3 years, here’s my +1. Thanks, Steve Zhang > O

Re: Remove deprecated table properties

Hi Fokko +1 to clean this. Thanks ! Regards JB On Mon, Feb 17, 2025 at 11:18 AM Fokko Driesprong wrote: > > Hi everyone, > > While reviewing the LocationProvider equivalent of PyIceberg, I noticed some > old code in the Java codebase that I felt could be cleaned up. You can find > the PR over

Re: Remove deprecated table properties

+1 to remove in 1.9 On Mon, Feb 17, 2025 at 4:20 AM Fokko Driesprong wrote: > Hi everyone, > > While reviewing the LocationProvider equivalent of PyIceberg, I noticed > some old code in the Java codebase that I felt could be cleaned up. You > can find the PR over here