+1 to remove them. Yufei
On Mon, Feb 17, 2025 at 1:26 PM Steve Zhang <hongyue_zh...@apple.com.invalid> wrote: > Thanks Fokko for removing deprecated properties! > > Just want to highlight the worst case for tables with old configuration > and not aware of this deprecation might experience silent behavior change. > But considering this has been deprecated for past 3 years, here’s my +1. > > Thanks, > Steve Zhang > > > > On Feb 17, 2025, at 2:18 AM, Fokko Driesprong <fo...@apache.org> wrote: > > Hi everyone, > > While reviewing the LocationProvider equivalent of PyIceberg, I noticed > some old code in the Java codebase that I felt could be cleaned up. You > can find the PR over here <https://github.com/apache/iceberg/pull/12174>. > This one removes the deprecated properties: > > OBJECT_STORE_PATH = "write.object-storage.path"; > WRITE_FOLDER_STORAGE_LOCATION = "write.folder-storage.path"; > > These have been deprecated since Iceberg 0.12, and would like to know if > anyone has any concerns about removing these. > > Kind regards, > Fokko > > >
