Re: [VOTE] Deprecate and remove last-column-id

2024-11-25 Thread Fokko Driesprong
While counting the votes, I realized that I didn't vote explicitly myself. +1 from my end as well :) We have 13 votes, of which 7 are binding. I'll go ahead and merge the PR. Thanks everyone! I also raised PRs at PyIceberg and Iceberg-Rust

Re: [VOTE] Deprecate and remove last-column-id

2024-11-21 Thread rdb...@gmail.com
+1 On Thu, Nov 21, 2024 at 5:22 AM Jean-Baptiste Onofré wrote: > +1 > > Regards > JB > > On Tue, Nov 19, 2024 at 9:18 AM Fokko Driesprong wrote: > > > > Hi everyone, > > > > Based on the positive feedback on the [DISCUSS] thread and the > pull-request on GitHub, I would like to raise a vote to

Re: [VOTE] Deprecate and remove last-column-id

2024-11-21 Thread Jean-Baptiste Onofré
+1 Regards JB On Tue, Nov 19, 2024 at 9:18 AM Fokko Driesprong wrote: > > Hi everyone, > > Based on the positive feedback on the [DISCUSS] thread and the pull-request > on GitHub, I would like to raise a vote to deprecate and remove the > last-column-id field from the spec. Since this is a spe

Re: [VOTE] Deprecate and remove last-column-id

2024-11-21 Thread Fokko Driesprong
Hey Manu, That's an excellent question. I took the following rationale: - For the code, the iceberg-core module, a minor release deprecation cycle is required . - For the spec, I noticed that the deprecation of the

Re: [VOTE] Deprecate and remove last-column-id

2024-11-20 Thread Hussein Awala
+1 (non-binding) On Wednesday, November 20, 2024, Daniel Weeks wrote: > +1 > > On Wed, Nov 20, 2024, 9:41 AM Aihua Xu wrote: > >> +1 non-binding. >> >> Thanks for driving this. >> >> On Tue, Nov 19, 2024 at 5:50 PM Renjie Liu >> wrote: >> >>> +1, thanks Fokko! >>> >>> On Wed, Nov 20, 2024 at 8

Re: [VOTE] Deprecate and remove last-column-id

2024-11-20 Thread Aihua Xu
+1 non-binding. Thanks for driving this. On Tue, Nov 19, 2024 at 5:50 PM Renjie Liu wrote: > +1, thanks Fokko! > > On Wed, Nov 20, 2024 at 8:45 AM Steve Zhang > wrote: > >> +1 nb >> >> Thanks, >> Steve Zhang >> >> >> >> On Nov 19, 2024, at 12:18 AM, Fokko Driesprong wrote: >> >> Hi everyone,

Re: [VOTE] Deprecate and remove last-column-id

2024-11-20 Thread Daniel Weeks
+1 On Wed, Nov 20, 2024, 9:41 AM Aihua Xu wrote: > +1 non-binding. > > Thanks for driving this. > > On Tue, Nov 19, 2024 at 5:50 PM Renjie Liu > wrote: > >> +1, thanks Fokko! >> >> On Wed, Nov 20, 2024 at 8:45 AM Steve Zhang >> wrote: >> >>> +1 nb >>> >>> Thanks, >>> Steve Zhang >>> >>> >>> >>

Re: [VOTE] Deprecate and remove last-column-id

2024-11-20 Thread Jack Ye
+1 -Jack On Tue, Nov 19, 2024 at 7:45 AM Russell Spitzer wrote: > +1 > > On Tue, Nov 19, 2024 at 4:11 AM Fokko Driesprong wrote: > >> Hey Manu, >> >> That's an excellent question. I took the following rationale: >> >>- For the code, the iceberg-core module, a minor release deprecation >>

Re: [VOTE] Deprecate and remove last-column-id

2024-11-20 Thread Manu Zhang
Thanks Fokko. To be clear, are you proposing to deprecate last-column-id in 1.8.0 and remove in 1.9.0+? On Tue, Nov 19, 2024 at 4:18 PM Fokko Driesprong wrote: > Hi everyone, > > Based on the positive feedback on the [DISCUSS] thread >

Re: [VOTE] Deprecate and remove last-column-id

2024-11-19 Thread Renjie Liu
+1, thanks Fokko! On Wed, Nov 20, 2024 at 8:45 AM Steve Zhang wrote: > +1 nb > > Thanks, > Steve Zhang > > > > On Nov 19, 2024, at 12:18 AM, Fokko Driesprong wrote: > > Hi everyone, > > Based on the positive feedback on the [DISCUSS] thread >

Re: [VOTE] Deprecate and remove last-column-id

2024-11-19 Thread Steve Zhang
+1 nb Thanks, Steve Zhang > On Nov 19, 2024, at 12:18 AM, Fokko Driesprong wrote: > > Hi everyone, > > Based on the positive feedback on the [DISCUSS] thread > and the > pull-request on GitHub

Re: [VOTE] Deprecate and remove last-column-id

2024-11-19 Thread Russell Spitzer
+1 On Tue, Nov 19, 2024 at 4:11 AM Fokko Driesprong wrote: > Hey Manu, > > That's an excellent question. I took the following rationale: > >- For the code, the iceberg-core module, a minor release deprecation >cycle is required >

Re: [VOTE] Deprecate and remove last-column-id

2024-11-19 Thread Honah J.
+1. Thanks Fokko. Best, Honah On Tue, Nov 19, 2024 at 9:11 AM Kevin Liu wrote: > +1 (non-binding). The spec and code deprecation schedule looks good to me. > > Best, > Kevin Liu > > On Tue, Nov 19, 2024 at 8:42 AM Christian Thiel > wrote: > >> +1 (non-binding) – looks like we are going in the

Re: [VOTE] Deprecate and remove last-column-id

2024-11-19 Thread Kevin Liu
+1 (non-binding). The spec and code deprecation schedule looks good to me. Best, Kevin Liu On Tue, Nov 19, 2024 at 8:42 AM Christian Thiel wrote: > +1 (non-binding) – looks like we are going in the right direction in rust! > > > Christian > > > On 19. Nov 2024, at 16:13, Jack Ye wrote: > > +1

Re: [VOTE] Deprecate and remove last-column-id

2024-11-19 Thread Christian Thiel
+1 (non-binding) – looks like we are going in the right direction in rust! Christian On 19. Nov 2024, at 16:13, Jack Ye wrote: +1 -Jack On Tue, Nov 19, 2024 at 7:45 AM Russell Spitzer mailto:russell.spit...@gmail.com>> wrote: +1 On Tue, Nov 19, 2024 at 4:11 AM Fokko Driesprong mailto:fo..