Re: [DISCUSS] Removal of last-column-id of public API

2024-11-18 Thread Jean-Baptiste Onofré
Hi Fokko I think it makes sense to deprecate and remote the field. +1 Regards JB On Thu, Nov 14, 2024 at 10:01 AM Fokko Driesprong wrote: > > Hi everyone, > > While reviewing the TableMetadataBuilder PR on Iceberg-Rust the other day, I > noticed that it exposes the last-column-id to the publi

Re: [DISCUSS] Removal of last-column-id of public API

2024-11-18 Thread Renjie Liu
+1 for deprecating and removing this. I don't think it makes sense to ask users to pass this while we can infer it from existing arguments. Also I see java code

Re: [DISCUSS] Removal of last-column-id of public API

2024-11-15 Thread Kevin Liu
Thanks for bringing this up Fokko. It makes sense to hide `last-column-id` from the public API, as it is an implementation detail. As mentioned in the PR, I checked references to `last-column-id`