Re: [DISCUSS, VOTE] OpenAPI Metadata Update for EnableRowLineage

2025-01-23 Thread Russell Spitzer
Looks like we are unanimous now, I can wait another day just in case anyone has last minute comments and I"ll merge tomorrow. On Thu, Jan 23, 2025 at 3:55 PM Daniel Weeks wrote: > +1 > > Sorry to have missed the discussion, but I'm onboard with the proposed > changes. > > On Thu, Jan 23, 2025 at

Re: [DISCUSS, VOTE] OpenAPI Metadata Update for EnableRowLineage

2025-01-23 Thread Daniel Weeks
+1 Sorry to have missed the discussion, but I'm onboard with the proposed changes. On Thu, Jan 23, 2025 at 11:27 AM Yufei Gu wrote: > +1 > Yufei > > > On Thu, Jan 23, 2025 at 11:05 AM huaxin gao > wrote: > >> +1 (non binding) >> >> Thanks Russell. >> >> On Thu, Jan 23, 2025 at 10:55 AM Fokko D

Re: [DISCUSS, VOTE] OpenAPI Metadata Update for EnableRowLineage

2025-01-23 Thread Yufei Gu
+1 Yufei On Thu, Jan 23, 2025 at 11:05 AM huaxin gao wrote: > +1 (non binding) > > Thanks Russell. > > On Thu, Jan 23, 2025 at 10:55 AM Fokko Driesprong > wrote: > >> +1 >> >> Thanks Russell >> >> Op do 23 jan 2025 om 18:47 schreef Aihua Xu : >> >>> + (non binding). >>> >>> Thanks Russell. >>>

Re: [DISCUSS, VOTE] OpenAPI Metadata Update for EnableRowLineage

2025-01-23 Thread huaxin gao
+1 (non binding) Thanks Russell. On Thu, Jan 23, 2025 at 10:55 AM Fokko Driesprong wrote: > +1 > > Thanks Russell > > Op do 23 jan 2025 om 18:47 schreef Aihua Xu : > >> + (non binding). >> >> Thanks Russell. >> >> On Thu, Jan 23, 2025 at 2:05 AM Jean-Baptiste Onofré >> wrote: >> >>> +1 (non bi

Re: [DISCUSS, VOTE] OpenAPI Metadata Update for EnableRowLineage

2025-01-23 Thread Fokko Driesprong
+1 Thanks Russell Op do 23 jan 2025 om 18:47 schreef Aihua Xu : > + (non binding). > > Thanks Russell. > > On Thu, Jan 23, 2025 at 2:05 AM Jean-Baptiste Onofré > wrote: > >> +1 (non binding) >> >> Regards >> JB >> >> On Wed, Jan 22, 2025 at 11:51 PM Russell Spitzer >> wrote: >> > >> > Hey Y'al

Re: [DISCUSS, VOTE] OpenAPI Metadata Update for EnableRowLineage

2025-01-23 Thread Aihua Xu
+ (non binding). Thanks Russell. On Thu, Jan 23, 2025 at 2:05 AM Jean-Baptiste Onofré wrote: > +1 (non binding) > > Regards > JB > > On Wed, Jan 22, 2025 at 11:51 PM Russell Spitzer > wrote: > > > > Hey Y'all > > > > Yet another Row Lineage Spec update. This adds a MetadataUpdate > EnableRowLi

Re: [DISCUSS, VOTE] OpenAPI Metadata Update for EnableRowLineage

2025-01-23 Thread Jean-Baptiste Onofré
+1 (non binding) Regards JB On Wed, Jan 22, 2025 at 11:51 PM Russell Spitzer wrote: > > Hey Y'all > > Yet another Row Lineage Spec update. This adds a MetadataUpdate > EnableRowLineage to the REST Spec. We briefly talked today > about an alternative EnableFeature(Feature Name) API instead but i

Re: [DISCUSS, VOTE] OpenAPI Metadata Update for EnableRowLineage

2025-01-23 Thread Eduard Tudenhöfner
+1 On Thu, Jan 23, 2025 at 4:49 AM Honah J. wrote: > +1, thanks Russell! > > Best regards, > Honah > > On Wed, Jan 22, 2025 at 6:49 PM Renjie Liu > wrote: > >> +1, thanks Russell for driving this! >> >> On Thu, Jan 23, 2025 at 8:12 AM Russell Spitzer < >> russell.spit...@gmail.com> wrote: >> >>

Re: [DISCUSS, VOTE] OpenAPI Metadata Update for EnableRowLineage

2025-01-22 Thread Honah J.
+1, thanks Russell! Best regards, Honah On Wed, Jan 22, 2025 at 6:49 PM Renjie Liu wrote: > +1, thanks Russell for driving this! > > On Thu, Jan 23, 2025 at 8:12 AM Russell Spitzer > wrote: > >> That was a bit of what we discussed at the sync this morning. Whether we >> should have a generic e

Re: [DISCUSS, VOTE] OpenAPI Metadata Update for EnableRowLineage

2025-01-22 Thread Renjie Liu
+1, thanks Russell for driving this! On Thu, Jan 23, 2025 at 8:12 AM Russell Spitzer wrote: > That was a bit of what we discussed at the sync this morning. Whether we > should have a generic enable feature update for one way features that we > don’t have the ability to disable. We couldn’t come

Re: [DISCUSS, VOTE] OpenAPI Metadata Update for EnableRowLineage

2025-01-22 Thread Russell Spitzer
That was a bit of what we discussed at the sync this morning. Whether we should have a generic enable feature update for one way features that we don’t have the ability to disable. We couldn’t come up with more examples of features we actually wanted to add. I think I’d we have at least two more it

Re: [DISCUSS, VOTE] OpenAPI Metadata Update for EnableRowLineage

2025-01-22 Thread Daniel Weeks
Just a minor question added to the PR. We're adding an explicit 'enable' as an update type and I wonder if it would be better to generalize it so that we don't have separate updates to disable/enable (more forward thinking as this is the first case quite like this). -Dan On Wed, Jan 22, 2025 a

Re: [DISCUSS, VOTE] OpenAPI Metadata Update for EnableRowLineage

2025-01-22 Thread Amogh Jahagirdar
+1 Thanks Russell On Wed, Jan 22, 2025 at 4:50 PM rdb...@gmail.com wrote: > +1 > > On Wed, Jan 22, 2025 at 2:51 PM Russell Spitzer > wrote: > >> Hey Y'all >> >> Yet another Row Lineage Spec update. This adds a MetadataUpdate >> EnableRowLineage to the REST Spec. We briefly talked today >> about

Re: [DISCUSS, VOTE] OpenAPI Metadata Update for EnableRowLineage

2025-01-22 Thread rdb...@gmail.com
+1 On Wed, Jan 22, 2025 at 2:51 PM Russell Spitzer wrote: > Hey Y'all > > Yet another Row Lineage Spec update. This adds a MetadataUpdate > EnableRowLineage to the REST Spec. We briefly talked today > about an alternative EnableFeature(Feature Name) API instead but in the > absence of other feat