Re: [VOTE] Release Apache Iceberg 1.7.0 RC0

2024-11-04 Thread Russell Spitzer
New Release Candidate was made and a new vote started! Thanks everyone, let's do this again On Mon, Nov 4, 2024 at 11:06 AM Russell Spitzer wrote: > https://github.com/apache/iceberg/pull/11462 <- For Main, I created a > branch for 1.7.x off of RC0 which I will backport the fix to after we merge

Re: [VOTE] Release Apache Iceberg 1.7.0 RC0

2024-11-04 Thread Russell Spitzer
https://github.com/apache/iceberg/pull/11462 <- For Main, I created a branch for 1.7.x off of RC0 which I will backport the fix to after we merge to main. On Mon, Nov 4, 2024 at 10:26 AM Russell Spitzer wrote: > Sounds good to me. I'll work on that this morning > > On Mon, Nov 4, 2024 at 10:16 A

Re: [VOTE] Release Apache Iceberg 1.7.0 RC0

2024-11-04 Thread Russell Spitzer
Sounds good to me. I'll work on that this morning On Mon, Nov 4, 2024 at 10:16 AM Amogh Jahagirdar <2am...@gmail.com> wrote: > Thanks for identifying this issue and bringing it up here Cheng, that's > really appreciated! @Russell Spitzer I do > think it is an issue, if I understand the issue cor

Re: [VOTE] Release Apache Iceberg 1.7.0 RC0

2024-11-04 Thread Amogh Jahagirdar
Thanks for identifying this issue and bringing it up here Cheng, that's really appreciated! @Russell Spitzer I do think it is an issue, if I understand the issue correctly, there are certain cases in 1.14.3 where we may not be reading the dictionary filter in its entirety, leading to correctness i

Re: [VOTE] Release Apache Iceberg 1.7.0 RC0

2024-11-04 Thread Russell Spitzer
We are currently including 1.14.3 as a build dependency, is that an issue? On Sun, Nov 3, 2024 at 12:47 PM Cheng Pan wrote: > FYI, I just identified a Parquet data loss issue(newly introduced in > 1.14.0), and I confirmed it affects the Spark use cases, I’m not sure if it > also affects Iceberg

Re: [VOTE] Release Apache Iceberg 1.7.0 RC0

2024-11-04 Thread Russell Spitzer
Here you go, https://github.com/apache/iceberg/compare/apache-iceberg-1.6.1...apache-iceberg-1.7.0-rc0 On Mon, Nov 4, 2024 at 9:40 AM Manu Zhang wrote: > +1 (non-binding) > Build with JDK17 and test with SparkCatalog / SparkSessionCatalog (type > hive) on Spark 3.5.0. > > BTW, according to > htt

Re: [VOTE] Release Apache Iceberg 1.7.0 RC0

2024-11-04 Thread Manu Zhang
+1 (non-binding) Build with JDK17 and test with SparkCatalog / SparkSessionCatalog (type hive) on Spark 3.5.0. BTW, according to https://iceberg.apache.org/how-to-release/#validating-a-source-release-candidate , release announcement should include links to GitHub change comparison? On Mon, Nov

Re: [VOTE] Release Apache Iceberg 1.7.0 RC0

2024-11-04 Thread Eduard Tudenhöfner
+1 (binding) Verified signature/checksum/license and build/test with JDK17 On Mon, Nov 4, 2024 at 1:15 AM Honah J. wrote: > +1 (binding) > > Verified signature/checksum/license/build/test with JDK17 > > Best regards, > Honah > > On Sun, Nov 3, 2024 at 10:47 AM Cheng Pan wrote: > >> FYI, I jus

Re: [VOTE] Release Apache Iceberg 1.7.0 RC0

2024-11-03 Thread Honah J.
+1 (binding) Verified signature/checksum/license/build/test with JDK17 Best regards, Honah On Sun, Nov 3, 2024 at 10:47 AM Cheng Pan wrote: > FYI, I just identified a Parquet data loss issue(newly introduced in > 1.14.0), and I confirmed it affects the Spark use cases, I’m not sure if it > als

Re: [VOTE] Release Apache Iceberg 1.7.0 RC0

2024-11-03 Thread Cheng Pan
FYI, I just identified a Parquet data loss issue(newly introduced in 1.14.0), and I confirmed it affects the Spark use cases, I’m not sure if it also affects Iceberg cases. https://github.com/apache/parquet-java/issues/3040 Thanks, Cheng Pan > On Oct 31, 2024, at 06:06, Russell Spitzer wrot

Re: [VOTE] Release Apache Iceberg 1.7.0 RC0

2024-11-01 Thread Amogh Jahagirdar
+1 (binding) Verified signature/checksum/license/build/test with JDK17 Thanks for driving the release Russell! Amogh Jahagirdar On Fri, Nov 1, 2024 at 12:36 PM Daniel Weeks wrote: > +1 (binding) > > Verified sigs/sums/license/build/test > > Also did some manual verification using spark and ev

Re: [VOTE] Release Apache Iceberg 1.7.0 RC0

2024-11-01 Thread Daniel Weeks
+1 (binding) Verified sigs/sums/license/build/test Also did some manual verification using spark and everything checks out. -Dan On Fri, Nov 1, 2024 at 10:52 AM Steven Wu wrote: > +1 (binding) > > Verified signature, checksum, license. Did Flink SQL local testing with > the runtime jar. > > D

Re: [VOTE] Release Apache Iceberg 1.7.0 RC0

2024-11-01 Thread Steven Wu
+1 (binding) Verified signature, checksum, license. Did Flink SQL local testing with the runtime jar. Didn't run build because Azure FileIO testing requires Docker environment. On Fri, Nov 1, 2024 at 5:02 AM Fokko Driesprong wrote: > Thanks Russel for running this release! > > +1 (binding) > >

Re: [VOTE] Release Apache Iceberg 1.7.0 RC0

2024-11-01 Thread Fokko Driesprong
Thanks Russel for running this release! +1 (binding) Checked signatures, checksum, licenses and did some local testing. Kind regards, Fokko Op do 31 okt 2024 om 17:47 schreef Russell Spitzer < russell.spit...@gmail.com>: > @Manu Zhang You are definitely right, I'll get > that in before I do

Re: [VOTE] Release Apache Iceberg 1.7.0 RC0

2024-10-31 Thread Chertara, Rahil
) using OSS Spark 3.5 (with scala 2.12). Thanks Russell for managing the release! Regards, Rahil Chertara From: Russell Spitzer Reply-To: "dev@iceberg.apache.org" Date: Thursday, October 31, 2024 at 9:48 AM To: "dev@iceberg.apache.org" , Manu Zhang Subject: RE: [EXTERNAL] [

Re: [VOTE] Release Apache Iceberg 1.7.0 RC0

2024-10-31 Thread Russell Spitzer
@Manu Zhang You are definitely right, I'll get that in before I do docs release. If you don't mind I'll skip it in the source though so I don't have to do another full release. On Thu, Oct 31, 2024 at 7:35 AM Jean-Baptiste Onofré wrote: > +1 (non binding) > > I checked the LICENSE and NOTICE, a

Re: [VOTE] Release Apache Iceberg 1.7.0 RC0

2024-10-31 Thread Jean-Baptiste Onofré
+1 (non binding) I checked the LICENSE and NOTICE, and they both look good to me (the same as in previous releases), so not a blocker for me. I also checked: - the planned Avro readers used in both Flink and Spark, they are actually used - Signature and hash are good - No binary file found in the

Re: [VOTE] Release Apache Iceberg 1.7.0 RC0

2024-10-31 Thread Ajantha Bhat
Hi Russell, The LICENSE and NOTICE issue turned out to be a false positive. When I used the Archive Utility app on Mac to unzip, it automatically overwrote identical files without any prompts. However, using the command line to unzip provided a prompt for identical files. I can confirm both the fi

Re: [VOTE] Release Apache Iceberg 1.7.0 RC0

2024-10-30 Thread Russell Spitzer
Technically those binaries are not the release. Only the source is the release and those binaries are provided as a convenience, although that said we should probably fix it. On Wed, Oct 30, 2024 at 9:26 PM Ajantha Bhat wrote: > Hi Russell, > Thanks for working on the release. > > I just found t

Re: [VOTE] Release Apache Iceberg 1.7.0 RC0

2024-10-30 Thread Ajantha Bhat
Hi Russell, Thanks for working on the release. I just found the issue[1] that none of the Iceberg runtime jars are including the LICENSE and NOTICE from the respective module directory. It always only packs the LICENSE and NOTICE from the root directory. This is observed even in the old releases l

Re: [VOTE] Release Apache Iceberg 1.7.0 RC0

2024-10-30 Thread Manu Zhang
Thanks Russell for making the release. Not a blocker but I really wish this doc change[1] can be included into 1.7.0. [1] https://github.com/apache/iceberg/pull/11417 On Thu, Oct 31, 2024 at 7:00 AM Russell Spitzer wrote: > Convenience binary artifacts are staged on Nexus. The Maven repository

Re: [VOTE] Release Apache Iceberg 1.7.0 RC0

2024-10-30 Thread Russell Spitzer
Convenience binary artifacts are staged on Nexus. The Maven repository URL is: https://repository.apache.org/content/repositories/orgapacheiceberg-1175/ On Wed, Oct 30, 2024 at 5:31 PM Russell Spitzer wrote: > Sorry forgot binary, doing that now > > On Wed, Oct 30, 2024 at 5:06 PM Russell Spitze

Re: [VOTE] Release Apache Iceberg 1.7.0 RC0

2024-10-30 Thread Russell Spitzer
Sorry forgot binary, doing that now On Wed, Oct 30, 2024 at 5:06 PM Russell Spitzer wrote: > Hey Y'all, > > I propose that we release the following RC as the official Apache Iceberg > 1.7.0 release. > > The commit ID is 91e04c9c88b63dc01d6c8e69dfdc8cd27ee811cc > * This corresponds to the tag: ap

[VOTE] Release Apache Iceberg 1.7.0 RC0

2024-10-30 Thread Russell Spitzer
Hey Y'all, I propose that we release the following RC as the official Apache Iceberg 1.7.0 release. The commit ID is 91e04c9c88b63dc01d6c8e69dfdc8cd27ee811cc * This corresponds to the tag: apache-iceberg-1.7.0-rc0 * https://github.com/apache/iceberg/commits/apache-iceberg-1.7.0-rc0 * https://gith