Re: [VOTE] Release Apache Iceberg 1.5.0 RC4

2024-03-04 Thread Eduard Tudenhoefner
I took a look at the *SHOW TABLES* behavior and I think the difference comes from the fact that Spark's SessionCatalog#listTables()

Re: [VOTE] Release Apache Iceberg 1.5.0 RC4

2024-03-02 Thread Jean-Baptiste Onofré
Hi Ryan Thanks for the update. Agree for a new RC. Let me take a look on your PR. Regards JB On Sat, Mar 2, 2024 at 8:08 PM Ryan Blue wrote: > > I did more digging and I think the reason why queries work and views fail is > that the ResolveViews rule is inserted at the end of the resolution ba

Re: [VOTE] Release Apache Iceberg 1.5.0 RC4

2024-03-02 Thread Ryan Blue
I did more digging and I think the reason why queries work and views fail is that the ResolveViews rule is inserted at the end of the resolution batch. Table resolution runs first because of rule ordering, but there are cases where that isn't necessarily going to happen. Since it's a bad practice t

Re: [VOTE] Release Apache Iceberg 1.5.0 RC4

2024-03-02 Thread Ryan Blue
I opened a PR that I think will fix this to get feedback on the approach: https://github.com/apache/iceberg/pull/9853 On Sat, Mar 2, 2024 at 10:36 AM Ryan Blue wrote: > -1 (binding) > > I'm hitting an exception when testing views that prevents loading tables > in Spark. The problem is that the R

Re: [VOTE] Release Apache Iceberg 1.5.0 RC4

2024-03-02 Thread Ryan Blue
-1 (binding) I'm hitting an exception when testing views that prevents loading tables in Spark. The problem is that the REST catalog I'm using is a view catalog, but the underlying REST service does not support views. As a result, when `loadView` is called, it results in an error instead of `NoSuc

Re: [VOTE] Release Apache Iceberg 1.5.0 RC4

2024-03-01 Thread Daniel Weeks
+1 (binding) Verified sigs/sums/licenses/build/test (Java 17) One thing I noticed while testing views is that there is a discrepancy between the spark catalog behavior of SHOW TABLES and what I see using an Iceberg catalog (jdbc or REST). The "SHOW TABLES" command in spark catalog shows both tab

Re: [VOTE] Release Apache Iceberg 1.5.0 RC4

2024-03-01 Thread Szehon Ho
+1 (binding) - Verified signature - Verified checksum - RAT check - Compiled - Manually ran basic queries on Spark 3.5 On Fri, Mar 1, 2024 at 6:13 AM Fokko Driesprong wrote: > +1 (binding) > > - Checked checksum and signature > - Ran a modified version of dbt-spark to take advantage of the view

Re: [VOTE] Release Apache Iceberg 1.5.0 RC4

2024-03-01 Thread Fokko Driesprong
+1 (binding) - Checked checksum and signature - Ran a modified version of dbt-spark to take advantage of the views, and it worked like a charm! 🥳 Cheers, Fokko Op vr 1 mrt 2024 om 06:43 schreef Ajantha Bhat : > Gentle reminder. > > On Wed, Feb 28, 2024 at 8:34 PM Eduard Tudenhoefner > wrote: >

Re: [VOTE] Release Apache Iceberg 1.5.0 RC4

2024-02-29 Thread Ajantha Bhat
Gentle reminder. On Wed, Feb 28, 2024 at 8:34 PM Eduard Tudenhoefner wrote: > +1 (non-binding) > > * validated checksum and signature > * checked license docs & ran RAT checks > * ran build and tests with JDK11 > * built new docker images and ran through > https://iceberg.apache.org/spark-quicks

Re: [VOTE] Release Apache Iceberg 1.5.0 RC4

2024-02-28 Thread Eduard Tudenhoefner
+1 (non-binding) * validated checksum and signature * checked license docs & ran RAT checks * ran build and tests with JDK11 * built new docker images and ran through https://iceberg.apache.org/spark-quickstart/ * tested with Trino & Presto * tested view support with Spark 3.5 + JDBC/REST catalog

Re: [VOTE] Release Apache Iceberg 1.5.0 RC4

2024-02-28 Thread Jean-Baptiste Onofré
+1 (non binding) I checked: - Signature and checksum are OK - Build is OK on the source distribution - ASF headers are present - No binary file found in the source distribution - Tested on iceland (sample project) + trino and also JDBC Catalog Thanks ! Regards JB On Tue, Feb 27, 2024 at 1:16 PM

[VOTE] Release Apache Iceberg 1.5.0 RC4

2024-02-27 Thread Ajantha Bhat
Hi Everyone, I propose that we release the following RC as the official Apache Iceberg 1.5.0 release. The commit ID is e39ec185d7879c1a310769d33e0b1b6ad12486a9 * This corresponds to the tag: apache-iceberg-1.5.0-rc4 * https://github.com/apache/iceberg/commits/apache-iceberg-1.5.0-rc4 * https://gi