Re: [VOTE] Release Apache Iceberg 1.1.0 RC2

2022-11-22 Thread Gabor Kaszab
Thanks for fixing this, Fokko! Closing this thread and sending out a new vote mail. Gabor On Mon, Nov 21, 2022 at 8:37 PM Driesprong, Fokko wrote: > Hey everyone, > > Unfortunately, I caught another issue that introduces regression: > https://github.com/apache/iceberg/pull/6242 Once that's in,

Re: [VOTE] Release Apache Iceberg 1.1.0 RC2

2022-11-21 Thread Driesprong, Fokko
Hey everyone, Unfortunately, I caught another issue that introduces regression: https://github.com/apache/iceberg/pull/6242 Once that's in, we can cut another RC. Kind regards, Fokko Driesprong Op ma 21 nov. 2022 om 11:31 schreef Gabor Kaszab : > Hi Everyone, > > I propose that we release the f

[VOTE] Release Apache Iceberg 1.1.0 RC2

2022-11-21 Thread Gabor Kaszab
Hi Everyone, I propose that we release the following RC as the official Apache Iceberg 1.1.0 release. The commit ID is 132cb94fea66644bdefe0c3608693cf317a72f3f * This corresponds to the tag: apache-iceberg-1.1.0-rc3 * https://github.com/apache/iceberg/commits/apache-iceberg-1.1.0-rc3 * https://g

Re: [VOTE] Release Apache Iceberg 1.1.0 RC2

2022-11-21 Thread Gabor Kaszab
Thanks for spotting this break and giving a fix, Fokko! Let me start another thread for the new RC. Gabor On Sun, Nov 20, 2022 at 9:27 PM Driesprong, Fokko wrote: > Thanks! Would be great to get this one in before RC3 as well: > https://github.com/apache/iceberg/pull/6195 > > Op zo 20 nov. 2022

Re: [VOTE] Release Apache Iceberg 1.1.0 RC2

2022-11-20 Thread Driesprong, Fokko
Thanks! Would be great to get this one in before RC3 as well: https://github.com/apache/iceberg/pull/6195 Op zo 20 nov. 2022 om 21:03 schreef Ryan Blue : > I just merged Fokko's fix for the breaking change, so we should be > unblocked now. Thanks, Fokko! > > On Sat, Nov 19, 2022 at 3:30 PM Ryan B

Re: [VOTE] Release Apache Iceberg 1.1.0 RC2

2022-11-20 Thread Ryan Blue
I just merged Fokko's fix for the breaking change, so we should be unblocked now. Thanks, Fokko! On Sat, Nov 19, 2022 at 3:30 PM Ryan Blue wrote: > Thanks, Fokko! I just reviewed the PR and it's almost ready to go. > > On Sat, Nov 19, 2022 at 3:01 PM Driesprong, Fokko > wrote: > >> Hey everyone

Re: [VOTE] Release Apache Iceberg 1.1.0 RC2

2022-11-19 Thread Ryan Blue
Thanks, Fokko! I just reviewed the PR and it's almost ready to go. On Sat, Nov 19, 2022 at 3:01 PM Driesprong, Fokko wrote: > Hey everyone, > > Wanted to let you know that I got a working fix for the breaking API: > https://github.com/apache/iceberg/pull/6220 Let me know what you think. > > Kind

Re: [VOTE] Release Apache Iceberg 1.1.0 RC2

2022-11-19 Thread Driesprong, Fokko
Hey everyone, Wanted to let you know that I got a working fix for the breaking API: https://github.com/apache/iceberg/pull/6220 Let me know what you think. Kind regards, Fokko Driesprong Op za 19 nov. 2022 om 14:20 schreef leilei hu : > +1(non-binding) > verified(java 8): > > - Create table usi

Re: [VOTE] Release Apache Iceberg 1.1.0 RC2

2022-11-19 Thread leilei hu
+1(non-binding) verified(java 8): - Create table using HiveCatalog and HadoopCatalog - Spark Structured Streaming with Spark 3.2.1 - Spark query with Spark’s DataSourceV2 API - Ran build with JDK8 > 2022年11月18日 上午12:39,Szehon Ho 写道: > > +1 (non-binding)

Re: [VOTE] Release Apache Iceberg 1.1.0 RC2

2022-11-17 Thread Driesprong, Fokko
-1 (non-binding) For testing the release I plugged in the latest RC2 in Trino and found out that we have regression: https://github.com/trinodb/trino/pull/15079/files It throws this exception: java.lang.UnsupportedOperationException: hash(value) is not supported on the base Bucket class at o

Re: [VOTE] Release Apache Iceberg 1.1.0 RC2

2022-11-17 Thread Eduard Tudenhoefner
+1 (non-binding) - validated checksum and signature - checked license docs & ran RAT checks - ran build and tests with JDK11 On Thu, Nov 17, 2022 at 11:30 AM Gabor Kaszab wrote: > Hi Everyone, > > I propose that we release the following RC as the official Apache Iceberg > 1.1.0 relea

Re: [VOTE] Release Apache Iceberg 1.1.0 RC2

2022-11-17 Thread Ajantha Bhat
@Szehon: This failure looks to be the same as #6060. I did report two flaky tests 3 weeks ago. But we didn't investigate it I guess. https://github.com/apache/iceberg/issues/6060 https://github.com/apache/iceberg/issues/5986 Thanks, Ajantha On Thu, Nov 17, 2022 at 10:09 PM Szehon Ho wrote: > +1

Re: [VOTE] Release Apache Iceberg 1.1.0 RC2

2022-11-17 Thread Szehon Ho
+1 (non-binding) 1. Verify signature 2. Verify checksum 3. License RAT check 4. Run unit test, Actually got a failure: org.apache.iceberg.spark.extensions.TestCopyOnWriteDelete > testDeleteWithSnapshotIsolation[catalogName = spark_catalog, implementation = org.apache.iceberg.spark.SparkSessionCa

[VOTE] Release Apache Iceberg 1.1.0 RC2

2022-11-17 Thread Gabor Kaszab
Hi Everyone, I propose that we release the following RC as the official Apache Iceberg 1.1.0 release. The commit ID is b3eaf0c6cb9cf6357a925c7443baadd54515a971 * This corresponds to the tag: apache-iceberg-1.1.0-rc2 * https://github.com/apache/iceberg/commits/apache-iceberg-1.1.0-rc2 * https://g