-1 (non-binding)
For testing the release I plugged in the latest RC2 in Trino and found out
that we have regression: https://github.com/trinodb/trino/pull/15079/files
It throws this exception:
java.lang.UnsupportedOperationException: hash(value) is not supported on
the base Bucket class
at org.apache.iceberg.transforms.Bucket.hash(Bucket.java:90)
at org.apache.iceberg.transforms.Bucket.apply(Bucket.java:99)
at org.apache.iceberg.transforms.Bucket.apply(Bucket.java:38)
at
io.trino.plugin.iceberg.IcebergPageSink.applyTransform(IcebergPageSink.java:372)
at
io.trino.plugin.iceberg.IcebergPageSink.getPartitionData(IcebergPageSink.java:364)
at
io.trino.plugin.iceberg.IcebergPageSink.getWriterIndexes(IcebergPageSink.java:288)
at
io.trino.plugin.iceberg.IcebergPageSink.writePage(IcebergPageSink.java:215)
at
io.trino.plugin.iceberg.IcebergPageSink.doAppend(IcebergPageSink.java:210)
at
io.trino.plugin.iceberg.IcebergPageSink.appendPage(IcebergPageSink.java:161)
We've removed the source type from the transform
<https://github.com/apache/iceberg/pull/5601>, so we can do lazy binding
which is very nice, but this wasn't deprecated in 1.0.0
<https://github.com/apache/iceberg/blob/1.0.x/api/src/main/java/org/apache/iceberg/transforms/Transform.java#L42>.
I'm not sure if we can make this backward compatible without diving into
the details, mostly because we've also built on top of it
<https://github.com/apache/iceberg/pull/5707>.
Best, Fokko
Op do 17 nov. 2022 om 18:16 schreef Eduard Tudenhoefner <edu...@tabular.io>:
> +1 (non-binding)
>
> - validated checksum and signature
> - checked license docs & ran RAT checks
> - ran build and tests with JDK11
>
>
> On Thu, Nov 17, 2022 at 11:30 AM Gabor Kaszab <gaborkas...@apache.org>
> wrote:
>
>> Hi Everyone,
>>
>> I propose that we release the following RC as the official Apache Iceberg
>> 1.1.0 release.
>>
>> The commit ID is b3eaf0c6cb9cf6357a925c7443baadd54515a971
>> * This corresponds to the tag: apache-iceberg-1.1.0-rc2
>> * https://github.com/apache/iceberg/commits/apache-iceberg-1.1.0-rc2
>> *
>> https://github.com/apache/iceberg/tree/b3eaf0c6cb9cf6357a925c7443baadd54515a971
>>
>> The release tarball, signature, and checksums are here:
>> * https://dist.apache.org/repos/dist/dev/iceberg/apache-iceberg-1.1.0-rc2
>>
>> You can find the KEYS file here:
>> * https://dist.apache.org/repos/dist/dev/iceberg/KEYS
>>
>> Convenience binary artifacts are staged on Nexus. The Maven repository URL
>> is:
>> * https://repository.apache.org/content/repositories/orgapacheiceberg-1111/
>>
>> Please download, verify, and test.
>>
>> Please vote in the next 72 hours.
>>
>> [ ] +1 Release this as Apache Iceberg 1.1.0
>> [ ] +0
>> [ ] -1 Do not release this because...
>>
>> Again, thanks to *Fokko* for running the RC creation steps for me!
>>
>>
