Re: [DISCUSS] Community code reviews

Sorry I missed it! Thanks for the heads up! El mié., 27 feb. 2019 a las 21:02, Ryan Blue () escribió: > Renato, > > There is a separate list for github updates, iss...@iceberg.apache.org. > We used to send the notifications to the dev list, but it was a lot of > traffic. > > On Wed, Feb 27, 2019

Re: [DISCUSS] Community code reviews

Renato, There is a separate list for github updates, iss...@iceberg.apache.org. We used to send the notifications to the dev list, but it was a lot of traffic. On Wed, Feb 27, 2019 at 11:35 AM Renato Marroquín Mogrovejo < renatoj.marroq...@gmail.com> wrote: > Also should the open PRs be announce

Re: [DISCUSS] Community code reviews

Also should the open PRs be announced on the mailing list? or is it a matter of checking constantly on GitHub? For example, in other projects new PRs are usually announced when posted into JIRA. El mié., 27 feb. 2019 a las 18:27, Ryan Blue () escribió: > Okay, let's amend my suggestion to say tha

Re: [DISCUSS] Community code reviews

Okay, let's amend my suggestion to say that the expectation is that the PR must be available for at least 2 days. Self +1 and merge in 2 minutes is a behavior that I would consider abusing the rule. If there are no other suggestions, I'll start a vote thread. On Wed, Feb 27, 2019 at 12:03 AM Anto

Re: [DISCUSS] Community code reviews

+1 from me. As it was said, I think we need to reconsider this again once Iceberg has more committers. > On 27 Feb 2019, at 04:19, RD wrote: > > +1 > > On Tue, Feb 26, 2019 at 5:49 PM Jacques Nadeau > wrote: > I'm +1 (non-binding) if you allow a window for review (

Re: [DISCUSS] Community code reviews

+1 On Tue, Feb 26, 2019 at 5:49 PM Jacques Nadeau wrote: > I'm +1 (non-binding) if you allow a window for review (for example, I > think others have suggested 1-2 business day before self+1). The post, > self +1, merge in two minutes is not great situation for anyone. > -- > Jacques Nadeau > CTO

Re: [DISCUSS] Community code reviews

I'm +1 (non-binding) if you allow a window for review (for example, I think others have suggested 1-2 business day before self+1). The post, self +1, merge in two minutes is not great situation for anyone. -- Jacques Nadeau CTO and Co-Founder, Dremio On Tue, Feb 26, 2019 at 4:51 PM Ryan Blue wro

[DISCUSS] Community code reviews

Hi everyone, I’d like to give a shout out to some of the awesome people that have joined this community and taken the time to review pull requests: Matt Cheah, Anton Okolnychyi, Ratandeep Ratti, Filip Bocse, and Uwe Korn. Thanks to all of you! This work is really helpful to growing community and