> 2.2 Do not upgrade Cargo.toml, and let the application be responsible for the
> transitive dependencies' version. Instead, we upgrade in Cargo.lock which
> means "we've tested the latest version".
I prefer this approach. I believe we should disable dependabot from upgrading
our patch versions
Hi Renjie,
Yes you are right that `datafusion-iceberg` will not break. I somehow
mistakenly thought that we cannot compile `datafusion` with a newer rust
toolchain... Sorry for the mistake.
Regarding the motivations
> 1. Use new(not latest) features in stable rust as rust is still evolving.
In
Oh, sorry for the mistake.
My vote should be non-binding.
On Wed, Feb 12, 2025, at 14:23, Xuanwo wrote:
> Here is my +1 binding.
>
> The current status of `distinct_count` is quite confusing, which has also led
> to additional discussions in `iceberg-rust` about whether we need to add it
> and
Hi, xxchan:
In fact, datafusion is not a consumer of iceberg-rust, in fact,
`datafusion-iceberg` is a consumer of both `iceberg` and `datafusion`,
which is maintained in `iceberg-rust` repo, so a more aggressive msrv
policy will not break `datafusion-iceberg`.
On Sun, Feb 23, 2025 at 8:40 PM xxc
Hi,
I want to explain why we need to upgrade msrv from time to time:
1. Use new(not latest) features in stable rust as rust is still evolving.
2. Use newer versions of iceberg-rust's dependencies, which may include
important bug fixes and performance improvements. I've seen dependent bot
auto upg
Fokko, what is the next step to merging one of the two PRs?
Jacob Marble
🔥🐅
On Thu, Feb 13, 2025 at 8:01 AM Jacob Marble
wrote:
> Xuanwo, do you favor deprecating or removing `distinct_count`?
>
> Due to lack of any real implementation, I myself favor removal (PR 12183).
>
> Jacob Marble
> 🔥🐅
Yes it makes sense to include #12389 in 1.8.1.
My PR about license fix (
https://github.com/apache/iceberg/pull/12365
) is also ready for review (for 1.8.1).
Regards
JB
Le dim. 23 févr. 2025 à 13:53, Ajantha Bhat a
écrit :
> @Eduard: Please include the below fix for 1.8.1 RC1.
> https://github
@Eduard: Please include the below fix for 1.8.1 RC1.
https://github.com/apache/iceberg/pull/12389
Thanks Alex for the quick fix!
I have added it to the 1.8.1 milestone.
- Ajantha
On Thu, Feb 20, 2025 at 10:04 PM Jean-Baptiste Onofré
wrote:
> I'm working on the licensing fix.
>
> Regards
> JB
>
Hi,
To clarify, if we want to adopt the "at least three months" policy, we will
need to wait for 3 months before upgrading to 1.85.
And I believe we don't want to break Datafusion integration, so we will
have to use the "at least six months" policy (or more conservative).
xxchan
On Sun, Feb 23,
Hi,
As Xuanwo mentions the "at least three months," policy looks good to me.
Also, it's time to upgrade to Rust 1.85 (the first version to support
Edition 2024!). See: https://github.com/apache/iceberg-rust/pull/987
10 matches
Mail list logo
