@Eduard: Please include the below fix for 1.8.1 RC1. https://github.com/apache/iceberg/pull/12389
Thanks Alex for the quick fix! I have added it to the 1.8.1 milestone. - Ajantha On Thu, Feb 20, 2025 at 10:04 PM Jean-Baptiste Onofré <j...@nanthrax.net> wrote: > I'm working on the licensing fix. > > Regards > JB > > On Thu, Feb 20, 2025 at 3:03 PM Eduard Tudenhöfner > <etudenhoef...@apache.org> wrote: > > > > @Yuya you're absolutely right and thanks for reporting this. This was a > mistake on my part that I didn't catch. I've created > https://github.com/apache/iceberg/pull/12351 to fix this. > > > > I'm cancelling this RC and will create RC1 once that PR and the > licensing stuff has been fixed. > > > > > > > > On Thu, Feb 20, 2025 at 11:22 AM Yuya Ebihara < > yuya.ebih...@starburstdata.com> wrote: > >> > >> Hi, > >> > >> Thank you for preparing RC, Eduard. > >> > >> I tested 1.8.1 on Trino. The S3-compatible storage issue has been > resolved, but Unity catalog and tabulario/iceberg-rest:1.6.0 tests are > still failing. > >> Those catalogs don't return endpoints in /v1/config, so they fall back > to DEFAULT_ENDPOINTS. > >> Thus, RESTSessionCatalog internally calls unsupported HEAD endpoints > and requests to check the existence of namespace/table/view fail. > >> > >> BR, > >> Yuya > >> > >> On Thu, Feb 20, 2025 at 7:00 PM Jean-Baptiste Onofré <j...@nanthrax.net> > wrote: > >>> > >>> +0 (non binding) > >>> > >>> I checked: > >>> - hash and checksum are good > >>> - LICENSE and NOTICE are good in the source distribution > >>> - no binary file found in the source distribution > >>> - ASF header is present in all expected file > >>> - able to build from the source distribution > >>> - I did "smoke tests" with Spark and Polaris without problem > >>> - the LICENSE is iceberg-aws-bundle is not correct: > >>> - netty-buffer version mentioned in LICENSE is 4.1.112.Final, but > >>> the version actually shaded in jar is 4.1.115.Final (but it's correct > >>> in NOTICE) > >>> - aws-crt version mentioned in LICENSE is 0.33.6, but the version > >>> actually shaded in jar is 0.33.3 (and it's not present in NOTICE) > >>> - the LICENSE in iceberg-azure-bundle is not correct: > >>> - azure-identity version mentioned in LICENSE is 1.14.2, but the > >>> version actually shaded in jar is 1.15.0 > >>> - the LICENSE in iceberg-gcp-bundle is not correct: > >>> - grpc-google-cloud-storage-v2 version mentioned in LICENSE is > >>> 2.22.5-alpha, but the version actually shaded in jar is 2.47.0 > >>> - proto-google-cloud-storage-v2 version mentioned in LICENSE is > >>> 2.22.5-alpha, but the version actually shaded in jar is 2.47.0 > >>> - the LICENSE in kafka-connect-runtime main/hive distributions is not > correct: > >>> - opentelemetry artifacts are missing in LICENSE > >>> > >>> As said in a previous PR comment, when reviewing dependabot PRs, the > >>> reviewer should add a commit directly in the dependabot PR keeping > >>> LICENSE/NOTICE in sync. If it's too painful, I think it's acceptable > >>> to use "major" dependencies version in the LICENSE/NOTICE (like 1.5.x > >>> instead of 1.5.6). > >>> > >>> I will propose PRs to fix the versions in LICENSE/NOTICE and use > >>> "major" versions. > >>> > >>> Regards > >>> JB > >>> > >>> On Thu, Feb 20, 2025 at 9:41 AM Eduard Tudenhoefner > >>> <etudenhoef...@gmail.com> wrote: > >>> > > >>> > Hi Everyone, > >>> > > >>> > I propose that we release the following RC as the official Apache > Iceberg 1.8.1 release. > >>> > > >>> > The commit ID is 673192d9152a5532f2a84aa2fc815cfa16f7f203 > >>> > * This corresponds to the tag: apache-iceberg-1.8.1-rc0 > >>> > * https://github.com/apache/iceberg/commits/apache-iceberg-1.8.1-rc0 > >>> > * > https://github.com/apache/iceberg/tree/673192d9152a5532f2a84aa2fc815cfa16f7f203 > >>> > > >>> > The release tarball, signature, and checksums are here: > >>> > * > https://dist.apache.org/repos/dist/dev/iceberg/apache-iceberg-1.8.1-rc0 > >>> > > >>> > You can find the KEYS file here: > >>> > * https://downloads.apache.org/iceberg/KEYS > >>> > > >>> > Convenience binary artifacts are staged on Nexus. The Maven > repository URL is: > >>> > * > https://repository.apache.org/content/repositories/orgapacheiceberg-1183/ > >>> > > >>> > Please download, verify, and test. > >>> > > >>> > Please vote in the next 72 hours. > >>> > > >>> > [ ] +1 Release this as Apache Iceberg 1.8.1 > >>> > [ ] +0 > >>> > [ ] -1 Do not release this because... > >>> > > >>> > Only PMC members have binding votes, but other community members are > encouraged to cast > >>> > non-binding votes. This vote will pass if there are 3 binding +1 > votes and more binding > >>> > +1 votes than -1 votes. > >>> > >
