Re: [VOTE] Update partition stats spec for V3

+1 On Sat, Feb 1, 2025 at 11:05 AM huaxin gao wrote: > +1 (non-binding) > > On Sat, Feb 1, 2025 at 8:50 AM Manish Malhotra < > manish.malhotra.w...@gmail.com> wrote: > >> +1(nonbinding) >> >> On Sat, Feb 1, 2025 at 2:49 AM Russell Spitzer >> wrote: >> >>> +1 >>> >>> On Sat, Feb 1, 2025 at 3:01 

Re: [VOTE] Update partition stats spec for V3

+1 (non-binding) On Sat, Feb 1, 2025 at 8:50 AM Manish Malhotra < manish.malhotra.w...@gmail.com> wrote: > +1(nonbinding) > > On Sat, Feb 1, 2025 at 2:49 AM Russell Spitzer > wrote: > >> +1 >> >> On Sat, Feb 1, 2025 at 3:01 AM Anton Okolnychyi >> wrote: >> >>> Hi all, >>> >>> I propose the foll

Re: [VOTE] Update partition stats spec for V3

+1(nonbinding) On Sat, Feb 1, 2025 at 2:49 AM Russell Spitzer wrote: > +1 > > On Sat, Feb 1, 2025 at 3:01 AM Anton Okolnychyi > wrote: > >> Hi all, >> >> I propose the following updates to our partition stats spec in V3: >> >> - Modify `position_delete_record_count` to include a sum of position

Re: FileRewrite API refactor

We probably still have to support it as long as we have V2 Table support right? On Fri, Jan 31, 2025 at 9:13 AM Péter Váry wrote: > We could simplify the API a bit, if we omit DeleteFileRewrite. > Since Anton's work around the Puffin delete vectors, this will become > obsolete anyway, and focusi

Re: [VOTE] Update partition stats spec for V3

+1 On Sat, Feb 1, 2025 at 3:01 AM Anton Okolnychyi wrote: > Hi all, > > I propose the following updates to our partition stats spec in V3: > > - Modify `position_delete_record_count` to include a sum of position > deletes across position delete files and DVs > - Keep `position_delete_file_count`

Re: guideline for interface change

In the API module we tend to be very careful and follow a deprecation schedule. So we would deprecate the old method and make a new one with the different return type. This would then be removed in the next big release. On Sat, Feb 1, 2025 at 8:03 AM Péter Váry wrote: > Can we deprecate the old

Re: [DISCUSS] Clarify delete counts handling in partition stats

Sounds reasonable, I think the intent was that N/A is different then 0 but that only makes sense for V1. For V2/V3 0 makes sense On Sat, Feb 1, 2025 at 3:15 AM Anton Okolnychyi wrote: > Hi all, > > I propose to clarify our delete counts handling in partition stats. We > have the following metric