In the API module we tend to be very careful and follow a deprecation schedule. So we would deprecate the old method and make a new one with the different return type. This would then be removed in the next big release.
On Sat, Feb 1, 2025 at 8:03 AM Péter Váry <peter.vary.apa...@gmail.com> wrote: > Can we deprecate the old method, and provide a default implementation for > the new method using the old one? > > This would keep the old functionality until the deprecated method is > removed. > > On Sat, Feb 1, 2025, 02:01 Aihua Xu <aihu...@gmail.com> wrote: > >> Hi folks, >> >> What is the general guideline for interface change? I'm trying to change >> >> PrimitiveType Types::fromPrimitiveString() => Type Types::fromTypeString() >> >> in >> https://github.com/apache/iceberg/pull/11831/files#diff-736caed551a388d34b08f223954ae7ecb2fdac9d90a4098ceedd95207d7efd4dR1149-R1152 >> to add variant type support. >> >> Would it be fine to introduce such an incompatible change? >> >> Thanks, >> Aihua >> >>
