Re: 1.7.1 breaking change related to ADLS support

2024-12-16 Thread Jean-Baptiste Onofré
Hi Alex, It was exactly my concern (and question) when I did the review on the PR. I agree it's breaking change and definitely not good in a micro/patch release. As 1.7.0 is still working, I would propose to wait 1.8.0 if possible: I'm actually preparing a new thread with 1.8.0 proposal (in term

1.7.1 breaking change related to ADLS support

2024-12-16 Thread Alex Reid
Just a heads up, but I believe this PR ( https://github.com/apache/iceberg/pull/11504) that was added to the 1.7.1 introduced a breaking change for anyone previously supporting ADLSFileIO / credentials with sasTokens. I added some details in the PR com

Re: [DISCUSS] Hive Support

2024-12-16 Thread rdb...@gmail.com
> I'm not sure there's an upgrade path before Spark 4.0. Any ideas? We can at least separate the concerns. We can remove the runtime modules that are the main issue. If we compile against an older version of the Hive metastore module (leaving it unchanged) that at least has a dramatically reduced

Re: [Announce] Singapore Apache Iceberg Community Meetup

2024-12-16 Thread Denny Lee
merci beaucoup! :) On Mon, Dec 16, 2024 at 10:50 AM Kevin Liu wrote: > Hey Denny, > > Here's one with a better resolution, > https://drive.google.com/file/d/1H2scgq70fJU8AMLXzOadOdKfVPjHLDH9/view?usp=sharing > > Best, > Kevin Liu > > On Mon, Dec 16, 2024 at 10:35 AM Denny Lee wrote: > >> Hey Ke

Re: [Announce] Singapore Apache Iceberg Community Meetup

2024-12-16 Thread Kevin Liu
Hey Denny, Here's one with a better resolution, https://drive.google.com/file/d/1H2scgq70fJU8AMLXzOadOdKfVPjHLDH9/view?usp=sharing Best, Kevin Liu On Mon, Dec 16, 2024 at 10:35 AM Denny Lee wrote: > Hey Kevin, > > Do you have a bigger image for this event so we can help promote the > event vi

Re: [Announce] Singapore Apache Iceberg Community Meetup

2024-12-16 Thread Denny Lee
Hey Kevin, Do you have a bigger image for this event so we can help promote the event via social media? Thanks! Denny On Fri, Dec 13, 2024 at 3:06 PM Kevin Liu wrote: > Hey everyone, > > The Iceberg community meetup has expanded to Singapore! The next Singapore > meetup will be on Wednesday,

Re: [DISCUSS] Remove snapshot-id from IRC SetStatisticsUpdate

2024-12-16 Thread Jean-Baptiste Onofré
Hi, I saw the discussion on Slack. Yeah, it's redundant. I know some catalogs only consider the snapshot id in SetStatisticsUpdate. Regards JB On Fri, Dec 13, 2024 at 8:03 PM Christian wrote: > > Dear all, > > I believe we currently have a redundancy in the IRC SetStatisticsUpdate [1]. > SetSta

Re: [DISCUSS] Remove snapshot-id from IRC SetStatisticsUpdate

2024-12-16 Thread Fokko Driesprong
Hey Christian, Great catch, I would also be in favor of removing the outer one. I don't see any value in having them both. Kind regards, Fokko Op ma 16 dec 2024 om 14:26 schreef Jean-Baptiste Onofré : > Hi, > > I saw the discussion on Slack. Yeah, it's redundant. > I know some catalogs only con

Re: [Discuss] Document Snapshot Summary Optional Fields for Standardization

2024-12-16 Thread Fokko Driesprong
I'm in favor of this as well. While working on PyIceberg I had to deduce this from the Java code, having a more condensed version in the appendix of the spec would be great. Kind regards, Fokko Op ma 16 dec 2024 om 14:21 schreef Jean-Baptiste Onofré : > Hi, > > yes I agree, I don't think we have

Re: [Discuss] Document Snapshot Summary Optional Fields for Standardization

2024-12-16 Thread Jean-Baptiste Onofré
Hi, yes I agree, I don't think we have to couple of spec version. Regards JB On Wed, Dec 11, 2024 at 11:17 PM Russell Spitzer wrote: > > I want to float this back up, I think this is a really good idea for cross > engine support. I don't think we have to tie this to any specific Spec > versio

Re: [DISCUSS] Spark Catalog - Drop vs Drop with Purge

2024-12-16 Thread Jean-Baptiste Onofré
It sounds good to me. Thanks ! Regards JB On Wed, Dec 11, 2024 at 7:20 PM Russell Spitzer wrote: > > Hi Y'all! > > Today we had a little discussion on the Apache Iceberg Catalog Community Sync > about DROP and DROP WITH PURGE. Currently the SparkCatalog implementation > inside of the reference l