Re: [DISCUSS] Define calendar used in specification?

2024-09-12 Thread Micah Kornfield
> > The spec purposely avoids timestamp conversion. Iceberg returns values as > they are passed from the engine and it is the engine's responsibility to do > any date/time conversion. I don't think that we should change this and take > responsibility in Iceberg. I'm not sure I understand this and

Re: Time-based partitioning on long column type

2024-09-12 Thread rdb...@gmail.com
I was thinking about adding to the specification how the current date/time transforms work with source columns that are longs. I don't think it helps much to introduce a new transform, although that would make the interpretation of the source data more obvious to users applying the transform. On W

Re: [DISCUSS] Define calendar used in specification?

2024-09-12 Thread rdb...@gmail.com
The spec purposely avoids timestamp conversion. Iceberg returns values as they are passed from the engine and it is the engine's responsibility to do any date/time conversion. I don't think that we should change this and take responsibility in Iceberg. On Thu, Sep 12, 2024 at 12:32 AM Bart Samwel

Re: [DISCUSS] REST: AuthManager API #10753

2024-09-12 Thread Dmitri Bourlatchkov
There is no overlap. I mean that we're improving storage credentials flows, so might as well make progress on improving client <-> catalog server authentication flows too :) On Thu, Sep 12, 2024 at 9:38 AM Eduard Tudenhöfner wrote: > @Dmitri can you please share what overlap you see between thes

Re: [DISCUSS] REST: AuthManager API #10753

2024-09-12 Thread Eduard Tudenhöfner
@Dmitri can you please share what overlap you see between these two PRs? The second PR aims at standardizing credentials used for different storage providers in the OpenAPI spec. On Thu, Sep 12, 2024 at 3:09 PM Dmitri Bourlatchkov wrote: > Apologies if I missed earlier discussions about this PR.

[DISCUSS] REST: AuthManager API #10753

2024-09-12 Thread Dmitri Bourlatchkov
Apologies if I missed earlier discussions about this PR. Would it be possible to revive the reviews / exchange of ideas about the proposed AuthManager [1]? I think it is quite relevant in light of the recent changes to the credentials configuration [2], even though it deals with the authenticatio

Re: [DISCUSS] Define calendar used in specification?

2024-09-12 Thread Bart Samwel
I have some historical context that may or may not be relevant. I still remember how we did the transition for Spark. This was ca. 2019, and there were still many people mixing Spark 2.x and 3.0. Also, many other systems were still using Java 7 which only supported Julian. As a result, Spark 3.0+ c

Re: [DISCUSS] Define calendar used in specification?

2024-09-12 Thread Manu Zhang
Spark doc refers to this Java 8 page https://docs.oracle.com/javase/8/docs/api/java/time/chrono/IsoChronology.html, which says > > This chronology defines the rules of the ISO calendar system. This > calendar system is based on the ISO-8601 standard, which is the *de facto* > world > calendar. > +