Re: [VOTE] Release Apache Iceberg 1.6.1 RC2

2024-08-26 Thread Ajantha Bhat
+1 (non-binding) * validated checksum and signature * checked license docs & ran RAT checks * ran build and tests with JDK11 - Ajantha On Tue, Aug 27, 2024 at 9:21 AM Amogh Jahagirdar <2am...@gmail.com> wrote: > +1 (binding) > > Verified signatures, checksums, RAT checks. Ran build and tests wi

Re: [DISCUSS] Improving Position Deletes in V3

2024-08-26 Thread Manu Zhang
Anton, Thanks for the write-up. It's very entertaining to read. I left some minor comments on the doc. +1 to the proposal. Regards, Manu On Tue, Aug 27, 2024 at 7:21 AM Steven Wu wrote: > Anton, > > Thanks a lot for the improvement proposal and great write-up with > quantitative supporting arg

Re: [VOTE] Release Apache Iceberg 1.6.1 RC2

2024-08-26 Thread Amogh Jahagirdar
+1 (binding) Verified signatures, checksums, RAT checks. Ran build and tests with JDK11. Thanks, Amogh Jahagirdar On Mon, Aug 26, 2024 at 6:21 AM Renjie Liu wrote: > +1 (binding) > > - Verified signatures, checksums > - Ran `./gradlew build` and all tests passed, jdk 17 > > On Sun, Aug 25, 20

Re: [VOTE] Merge REST Spec change to add RemovePartitionSpecsUpdate update type

2024-08-26 Thread Manu Zhang
+1 (non-binding) On Tue, Aug 27, 2024 at 11:00 AM xianjin wrote: > +1 (non-binding) > Sent from my iPhone > > On Aug 27, 2024, at 4:22 AM, Fokko Driesprong wrote: > >  > +1 > > Op ma 26 aug 2024 om 22:00 schreef Yufei Gu : > >> +1 >> Yufei >> >> >> On Mon, Aug 26, 2024 at 11:06 AM Ryan Blue >

Re: [VOTE] Merge REST Spec change to add RemovePartitionSpecsUpdate update type

2024-08-26 Thread xianjin
+1 (non-binding)Sent from my iPhoneOn Aug 27, 2024, at 4:22 AM, Fokko Driesprong wrote:+1Op ma 26 aug 2024 om 22:00 schreef Yufei Gu :+1YufeiOn Mon, Aug 26, 2024 at 11:06 AM Ryan Blue wrote:+1On Mon, Aug 26, 2024 at 11:04 AM Amogh Jahagirdar <2am...@gmail.com> wrote:I've op

Re: [DISCUSS] Drop Hive 2 support

2024-08-26 Thread Anton Okolnychyi
Are we aware of any engines that can be affected by this change? пн, 26 серп. 2024 р. о 17:34 Manu Zhang пише: > Hi all, > > I'd like to start a discussion on dropping Hive 2 support, which reached > EOL three months ago[1]. It's also a prerequisite for migration to Hadoop > 3, as shown by Steve

[DISCUSS] Drop Hive 2 support

2024-08-26 Thread Manu Zhang
Hi all, I'd like to start a discussion on dropping Hive 2 support, which reached EOL three months ago[1]. It's also a prerequisite for migration to Hadoop 3, as shown by Steve's PR[2]. For your reference, I have a draft PR[3] to show the needed changes. Since we've not deprecated Hive 2 support y

Re: [DISCUSS] Improving Position Deletes in V3

2024-08-26 Thread Steven Wu
Anton, Thanks a lot for the improvement proposal and great write-up with quantitative supporting arguments. +1 from my side. Thanks, Steven On Wed, Aug 21, 2024 at 2:29 PM Anton Okolnychyi wrote: > Hey folks, > > As discussed during the sync, I've been working on a proposal to improve > the

Re: Type promotion in v3

2024-08-26 Thread Amogh Jahagirdar
Just caught up on this discussion, thanks all for the insights! I largely agree with Ryan's point that read-time transformation is different from a normal type promotion even though the read-time transformation may seem logically equivalent. The compelling part of leveraging the upper/lower bounds

Re: [VOTE] Merge REST Spec change to add RemovePartitionSpecsUpdate update type

2024-08-26 Thread Fokko Driesprong
+1 Op ma 26 aug 2024 om 22:00 schreef Yufei Gu : > +1 > Yufei > > > On Mon, Aug 26, 2024 at 11:06 AM Ryan Blue > wrote: > >> +1 >> >> On Mon, Aug 26, 2024 at 11:04 AM Amogh Jahagirdar <2am...@gmail.com> >> wrote: >> >>> I've opened a PR [1] to add a RemovePartitionSpecsUpdate update type so >>>

Re: [VOTE] Merge REST Spec change to add RemovePartitionSpecsUpdate update type

2024-08-26 Thread Yufei Gu
+1 Yufei On Mon, Aug 26, 2024 at 11:06 AM Ryan Blue wrote: > +1 > > On Mon, Aug 26, 2024 at 11:04 AM Amogh Jahagirdar <2am...@gmail.com> > wrote: > >> I've opened a PR [1] to add a RemovePartitionSpecsUpdate update type so >> that removing partition specs update operation against REST catalogs

Re: [Discuss] test logging is broken and Avro 1.12.0 upgraded slf4j-api dep to 2.x

2024-08-26 Thread Steve Zhang
I believe dependabot tried to upgrade self4j to 2.x in [1] but JB mentioned there's -1 on this upgrade, maybe he has more context. [1]https://github.com/apache/iceberg/pull/9688 Thanks, Steve Zhang > On Aug 24, 2024, at 7:37 PM, Steven Wu wrote: > > Hi, > > It seems that test logging is br

Re: [VOTE] Merge REST Spec change to add RemovePartitionSpecsUpdate update type

2024-08-26 Thread Ryan Blue
+1 On Mon, Aug 26, 2024 at 11:04 AM Amogh Jahagirdar <2am...@gmail.com> wrote: > I've opened a PR [1] to add a RemovePartitionSpecsUpdate update type so > that removing partition specs update operation against REST catalogs can be > supported. See the discuss thread [2] for more context. > > Plea

[VOTE] Merge REST Spec change to add RemovePartitionSpecsUpdate update type

2024-08-26 Thread Amogh Jahagirdar
I've opened a PR [1] to add a RemovePartitionSpecsUpdate update type so that removing partition specs update operation against REST catalogs can be supported. See the discuss thread [2] for more context. Please vote on merging this change. The vote will remain open for at least 72 hours. [] +1 [

Re: [DISCUSS] Adding RemovePartitionSpecsUpdate update type to REST

2024-08-26 Thread Amogh Jahagirdar
Thanks everyone, it seems as though there's general support for this. Since this has been open for a while for discussion, and this is a spec change I will start a separate vote thread. On Thu, Aug 22, 2024 at 12:28 PM Ryan Blue wrote: > +1 > > On Tue, Aug 20, 2024 at 1:56 AM Fokko Driesprong w

Re: [VOTE] Release Apache Iceberg 1.6.1 RC2

2024-08-26 Thread Renjie Liu
+1 (binding) - Verified signatures, checksums - Ran `./gradlew build` and all tests passed, jdk 17 On Sun, Aug 25, 2024 at 1:52 AM Fokko Driesprong wrote: > +1 (binding) > > - Verified signatures, checksums and ran the tests locally > > Kind regards, > Fokko > > Op vr 23 aug 2024 om 20:51 schre