Re: [EXTERNAL] Re: Branch-3 backports and build stability

2023-02-10 Thread Vihang Karajgaonkar
Thanks a lot Stamatis for starting this thread. I really appreciate all the efforts to stabilize branch-3 to get it to a releasable state and I agree that we should get it to a green state before opening it for PRs not related to test failures. I can help with the effort as well. If we want to get

Re: [EXTERNAL] Re: Branch-3 backports and build stability

2023-02-16 Thread vihang karajgaonkar
Raj wrote: > Hi Vihang, > > Yes the tests are failing locally as well with the same issue. > > Thanks, > Aman. > > Get Outlook for Android<https://aka.ms/AAb9ysg> > ____ > From: Vihang Karajgaonkar > Sent: Friday, February 10, 202

Re: [EXTERNAL] Re: Proposal to deprecate Hive on Spark from branch-3

2023-02-23 Thread vihang karajgaonkar
+1 to deprecate Hive on Spark. I feel directly removing it in a minor release is probably a bad idea. Most users will upgrade to 3.2 first and go to 4.0 later. If we deprecate it in 3.2 it transitions well into its removal as users upgrade to 4.0 eventually. If the goal to stabilize the branch-3,

Re: [EXTERNAL] Re: Proposal to deprecate Hive on Spark from branch-3

2023-02-27 Thread vihang karajgaonkar
absence of community aspiration to fix them properly > > > > regarding the motivation: "This would ensure that branch-3 is aligned > with > > the master as done in ..." <-- I don't think we're targeting this, we > are > > about to make 3.x rele

Re: [EXTERNAL] Re: Branch-3 backports and build stability

2023-03-03 Thread vihang karajgaonkar
t. > > > > I would like to thank everyone who has participated in this effort and > > made it possible till this stage. Also, if the contributors can take > > ownership of these new test case failures and fix them, it will be of > great > > help. > > > >

Re: [EXTERNAL] Re: Branch-3 backports and build stability

2023-03-17 Thread vihang karajgaonkar
on this. Can you try using -Pqsplits,itests. > Also, I usually give a -o option after doing a clean install. > > Thanks, > Aman. > > Get Outlook for Android<https://aka.ms/AAb9ysg> > > > From: vihang karajgaonkar > Sent: Saturday, 4

Re: [EXTERNAL] Re: Branch-3 backports and build stability

2023-03-19 Thread vihang karajgaonkar
or revert option is same as point 1. > 3. > testBootstrapReplLoadRetryAfterFailureForPartitions() - This I have not > investigated till now. > 4. > mm_all.q - This I have not investigated till now. > > Thanks, > Aman. > > From: vihang kara

Re: [EXTERNAL] Re: Branch-3 backports and build stability

2023-03-28 Thread vihang karajgaonkar
The entire effort can be tracked here > HIVE-26836<https://issues.apache.org/jira/browse/HIVE-26836>. We are > ready to push new features and improvements on branch-3 now. > > I really want to thank Vihang Karajgaonkar, Chris Nauroth, Lazlo Bodor, > Stamatis Zampetakis and Sanka

Re: [EXTERNAL] Re: Branch-3 backports and build stability

2023-05-07 Thread vihang karajgaonkar
e be particularly cautious with > anything that touches the metastore schema and Thrift APIs. > > Best, > Stamatis > > On Wed, Mar 29, 2023, 4:36 AM vihang karajgaonkar > wrote: > > > Thanks a lot Aman for all your efforts on this. Really appreciate the > > initiative

Re: [EXTERNAL] Re: Branch-3 backports and build stability

2023-05-09 Thread Vihang Karajgaonkar
> > Thanks, > Aman. > > Get Outlook for Android<https://aka.ms/AAb9ysg> > > From: vihang karajgaonkar > Sent: Monday, May 8, 2023 4:57:24 AM > To: dev@hive.apache.org > Subject: Re: [EXTERNAL] Re: Branch-3 backports and build stab

[DISCUSS] Nightly snaphot builds

2023-05-22 Thread vihang karajgaonkar
Hello Team, I have observed that it is a common use-case where users would like to test out unreleased features/bug fixes either to unblock them or test out if the bug fixes really work as intended in their environments. Today in the case of Apache Hive, this is not very user friendly because it r

Re: [DISCUSS] Nightly snaphot builds

2023-05-23 Thread vihang karajgaonkar
t; > +1 on the idea. > > > > > > This is a great idea to quickly test if a certain feature is working as > > > expected on a certain branch. > > > This way we test data loss, correctness, or any other unexpected > > scenarios > > > that

Re: [DISCUSS] Nightly snaphot builds

2023-05-24 Thread vihang karajgaonkar
t; > > Best, > > Stamatis > > > > [1] http://ci.hive.apache.org/job/hive-nightly/ > > > > > > On Tue, May 23, 2023 at 9:03 AM vihang karajgaonkar > wrote: > >> > >> I think there are many benefits like others in this thread suggested

Re: [DISCUSS] Nightly snaphot builds

2023-05-24 Thread vihang karajgaonkar
g On Wed, May 24, 2023 at 10:07 AM vihang karajgaonkar wrote: > The nightly job http://ci.hive.apache.org/job/hive-nightly/ is great. Can > we have this for branch-3 as well since we have been backporting a lot of > PRs to branch-3 lately. > > Thanks, > Vihang > > > >

Re: [DISCUSS] Nightly snaphot builds

2023-05-25 Thread vihang karajgaonkar
> pipeline script ever since it was introduced :D > > cheers, > Zoltan > > On 5/25/23 01:26, vihang karajgaonkar wrote: > > I created https://issues.apache.org/jira/browse/HIVE-27371 to have > nightly > > builds for branch-3. Once that is merged, I think we can hav

Re: [DISCUSS] Nightly snaphot builds

2023-05-26 Thread vihang karajgaonkar
Thanks Zoltan. Makes sense. Also, we should definitely strive to release within 180 days especially when there are lots of commits to a branch. -Vihang On Fri, May 26, 2023 at 12:04 AM Zoltan Haindrich wrote: > On 5/25/23 19:58, vihang karajgaonkar wrote: > > I just tried the job and

Re: Re: Reg: Discussion on removal of deprecated APIs in the HMS thrift interface

2023-06-07 Thread vihang karajgaonkar
+1 on removing unreleased and deprecated APIs. For the APIs which have been released, we should mark them deprecated first and remove them only in the next major release. As many of you know, Hive metastore APIs are used by many other systems outside Hive too and we should be careful not make break

Hive 4.0 branching

2023-06-07 Thread vihang karajgaonkar
Hello Dev community, I noticed that we have a branch-4.0.0-alpha1 and branch-4.0.0-alpha-2 but I don't see a branch-4. Does anyone know which branch would be used to cut out the final 4.0.0 release and when would a branch-4 be available? Thanks, Vihang

Re: [EXTERNAL] Re: [DISCUSS] End of life for Hive 1.x, 2.x, 3.x

2024-01-16 Thread vihang karajgaonkar
I was confused about the subject line since it says 3.x as well along with 1.x and 2.x. Does this discussion include all 1.x, 2.x and 3.x or just 1.x and 2.x? I think it makes sense to EOL 1.x. Looks like 2.x is still being maintained by Chao and I think we were backporting PRs to the 3.x line pre

Re: [EXTERNAL] Re: [VOTE] Mark Hive 1.x EOL

2024-01-17 Thread Vihang Karajgaonkar
+1 On Wed, Jan 17, 2024 at 3:48 PM Larry Z. wrote: > +1 (binding) > > On Wed, Jan 17, 2024 at 9:46 AM Chao Sun wrote: > > > +1 (binding) > > > > On Wed, Jan 17, 2024 at 1:24 AM Alessandro Solimando > > wrote: > > > > > > +1 (non binding) > > > > > > On Wed, 17 Jan 2024 at 10:23, Denys Kuzmenko

Re: [DISCUSS] Release of standalone-metastore

2018-05-29 Thread Vihang Karajgaonkar
How about cutting out a branch-3.0.1 and releasing 3.0.1 with the pom.xml fixed? My concern with above approach is we haven't tested standalone-metastore when deployed independent of Hive. So we don't know if there is something is fundamentally broken in that mode and given that we don't know when

Re: [DISCUSS] Release of standalone-metastore

2018-05-30 Thread Vihang Karajgaonkar
gt; > On Tue, May 29, 2018 at 3:29 PM Vihang Karajgaonkar > > > wrote: > > > > > How about cutting out a branch-3.0.1 and releasing 3.0.1 with the > pom.xml > > > fixed? My concern with above approach is we haven't tested > > > standalone-metastor

Re: Hive PreCommit Builds

2018-06-05 Thread Vihang Karajgaonkar
Hi Gavin, Thanks for your email. We are very aware of the current situation with the Hive precommit and we are working on improving our infrastructure to support multiple patch runs. This is being tracked by some of the sub-tasks under HIVE-19425. While we are working on it if you have any ideas o

Re: Precommit branch patches pickup order

2018-06-13 Thread Vihang Karajgaonkar
Based on my knowledge, it picks up only one which is the latest. On Wed, Jun 13, 2018 at 1:33 PM, Prasanth Jayachandran < pjayachand...@hortonworks.com> wrote: > Does anyone know if 2 patches are uploaded for a jira (say > HIVE-12345.patch and HIVE-12345-branch-3.patch) for different branches, >

Re: Ptest timeouts

2018-06-19 Thread Vihang Karajgaonkar
The disk utilization is around ~90%. I am not sure if its related though. I will remove older directories to clean it up to see if helps. On Tue, Jun 19, 2018 at 10:44 AM, Thejas Nair wrote: > + Vihang > > > On Tue, Jun 19, 2018 at 1:55 AM, Prasanth Jayachandran > wrote: > > Precommit tests hav

Re: Ptest timeouts

2018-06-19 Thread Vihang Karajgaonkar
Sorry my bad, the disk utilization was not looking bad actually. It was around ~10% not 90%. Which tests are timing out? The last couple of runs that I saw didn't show any timeouts. On Tue, Jun 19, 2018 at 3:35 PM, Vihang Karajgaonkar wrote: > The disk utilization is around ~90%. I am

Re: [ANNOUNCE] New committer: Adam Szita

2018-06-20 Thread Vihang Karajgaonkar
Congrats Adam! On Wed, Jun 20, 2018 at 8:45 PM, Zoltan Haindrich wrote: > Congratulations Ádám! > > On 20 June 2018 22:20:16 CEST, Deepak Jaiswal > wrote: > >Congratulations Adam. > > > >On 6/20/18, 12:02 PM, "Ashutosh Chauhan" wrote: > > > >Apache Hive's Project Management Committee (PMC) ha

Re: New committer announcement : Marta Kuczora

2018-06-20 Thread Vihang Karajgaonkar
Congrats Marta! On Wed, Jun 20, 2018 at 8:46 PM, Zoltan Haindrich wrote: > Congratulations Márta! > > On 20 June 2018 22:20:30 CEST, Deepak Jaiswal > wrote: > >Congratulations Marta. > > > >On 6/20/18, 12:06 PM, "Ashutosh Chauhan" wrote: > > > >Apache Hive's Project Management Committee (PMC)

Re: Hive QA logs not accessible

2018-06-25 Thread Vihang Karajgaonkar
Are you looking for logs for successful tests? I had submitted a change recently which stops skips downloading logs for successful tests to shave off ~10 min time from each run. I found that the job was spending too much time copying over ~20G of logs from worker nodes to the server. Can you give t

Re: Hive QA logs not accessible

2018-06-25 Thread Vihang Karajgaonkar
cessful runs. However, I think there is a problem with Hive QA, the > queue is gone and I submitted a patch more than 10 minutes ago and it > hasn’t started or enqueued yet. > > https://builds.apache.org/view/H-L/view/Hive/job/PreCommit-HIVE-Build/ > > Regards, > Deepak &

Re: Hive QA logs not accessible

2018-06-25 Thread Vihang Karajgaonkar
e but tests started to appear, so all is good now. > > Regards, > Deepak > > On 6/25/18, 12:24 PM, "Vihang Karajgaonkar" > wrote: > > I see there are 6 builds in the queue right now (which is > unusually small). > What is the JIRA n

Re: Hive QA logs not accessible

2018-06-25 Thread Vihang Karajgaonkar
It looks like a infrastructure issue. Whenever H19 node tries to execute the pre-commit job it fails because it cannot download maven artifacts which fails the compilation process for Ptest Client. On Mon, Jun 25, 2018 at 2:23 PM, Vihang Karajgaonkar wrote: > Hmm .. you are right. The bui

Re: Apache Hive 3.1. release preparation

2018-06-25 Thread Vihang Karajgaonkar
I think it would be useful to do a metastore 3.1 release as well along with the release. In order to do that we should deploy metastore in standalone mode, make sure it works as expected and also document how to install and use metastore as a standalone module. On Mon, Jun 25, 2018 at 3:00 PM, Vin

Re: Apache Hive 3.1. release preparation

2018-06-26 Thread Vihang Karajgaonkar
on metastore 3.1. Any thoughts? On Mon, Jun 25, 2018 at 3:16 PM, Vihang Karajgaonkar wrote: > I think it would be useful to do a metastore 3.1 release as well along > with the release. In order to do that we should deploy metastore in > standalone mode, make sure it works as expected

Re: HiveQA is broken

2018-06-26 Thread Vihang Karajgaonkar
This is what its doing: + git clone --depth 1 https://github.com/apache/hive.git hive Cloning into 'hive'... + cd hive/testutils/ptest2 + mvn clean package -B -DskipTests -Drat.numUnapprovedLicenses=1000 -Dmaven.repo.local=/home/jenkins/jenkins-slave/workspace/PreCommit-HIVE-Build/.m2/repository

Re: HiveQA is broken

2018-06-26 Thread Vihang Karajgaonkar
Interesting.. the jenkins job on the client side does use Java 7. Let me try updating it to use Java 8. On Tue, Jun 26, 2018 at 11:52 AM, Sergey Shelukhin wrote: > Might be related to > https://stackoverflow.com/questions/50946420/could-not- > transfer-artifact-ht > tps-repo-maven-apache-org-mav

Re: HiveQA is broken

2018-06-26 Thread Vihang Karajgaonkar
After updating to jdk-8 on the jenkins side and making some change on the server side, it looks like its chugging along again. Will keep an eye. On Tue, Jun 26, 2018 at 11:56 AM, Vihang Karajgaonkar wrote: > Interesting.. the jenkins job on the client side does use Java 7. Let me > try up

Re: Apache Hive 3.1. release preparation

2018-06-27 Thread Vihang Karajgaonkar
different sequence. > Not having to serialize these releases would help with smaller release > cycles. > > Thanks, > Thejas > > > > On Tue, Jun 26, 2018 at 9:59 AM, Vihang Karajgaonkar > wrote: > > +1 for releasing Hive 3.1. I can be the RM for the metastore 3.1 rele

Fwd: Jenkins Upgrade

2018-06-28 Thread Vihang Karajgaonkar
FYI -- Forwarded message -- From: Gav Date: Thu, Jun 28, 2018 at 12:25 PM Subject: Jenkins Upgrade To: builds , operati...@apache.org Hi All, This is to advise that Jenkins will be going offline for a main instance and plugins upgrade this coming Sunday. I'll start around 9am U

Re: Change patch naming convention

2018-07-17 Thread Vihang Karajgaonkar
It doesn't matter if you use a dot v/s a dash to separate the patch version with the profile name (same as branch name but its technically different). See https://issues.apache.org/jira/browse/HIVE-18885 as an example where I had submitted both the naming styles and precommit picked it up. Having s

Re: Change patch naming convention

2018-07-20 Thread Vihang Karajgaonkar
om the Hive QE comments it seems that your first two patches > were > also applied on master instead of branch-3. > > Regards, > Daniel > > On Tue, Jul 17, 2018 at 6:29 PM Vihang Karajgaonkar > wrote: > > > It doesn't matter if you use a dot v/s a dash to separ

Re: [VOTE] Apache Hive 3.1.0 Release Candidate 0

2018-07-20 Thread Vihang Karajgaonkar
Shouldn't these links include the metastore tar balls as well? I thought the plan was to release Metastore 3.1 along with Hive 3.1 based on the discussion we had on this list a few weeks ago. I am currently in process of verifying the standalone-metastore for branch-3.1 On Wed, Jul 18, 2018 at 6:1

Re: [VOTE] Apache Hive 3.1.0 Release Candidate 1

2018-07-24 Thread Vihang Karajgaonkar
- Built the source and ran some basic hive commands - Built standalone-metastore and deployed it with a non-hive application. Tested basic metastore operations like create, alter, drop on tables and partitions - Verified the signature for the tar files RC1 looks good to me. +1 (non

Re: [ANNOUNCE] New PMC Member : Peter Vary

2018-07-30 Thread Vihang Karajgaonkar
Congrats Peter! On Mon, Jul 30, 2018 at 4:04 PM, Prasanth Jayachandran < pjayachand...@hortonworks.com> wrote: > Congratulations Peter! > > Thanks > Prasanth > > > > On Mon, Jul 30, 2018 at 12:21 PM -0700, "Xuefu Zhang" > mailto:xu...@uber.com.INVALID>> wrote: > > > Congratulations, Peter! > > On

Re: [ANNOUNCE] New PMC Member : Vineet Garg

2018-07-30 Thread Vihang Karajgaonkar
Congrats Vineet! On Mon, Jul 30, 2018 at 4:04 PM, Prasanth Jayachandran < pjayachand...@hortonworks.com> wrote: > Congratulations Vineet! > > Thanks > Prasanth > > > > On Mon, Jul 30, 2018 at 12:11 PM -0700, "Xuefu Zhang" > mailto:xu...@uber.com.INVALID>> wrote: > > > Congratulations! > > On Mon,

Re: [ANNOUNCE] New PMC Member : Sahil Takiar

2018-07-30 Thread Vihang Karajgaonkar
Congratulations Sahil! On Mon, Jul 30, 2018 at 4:05 PM, Prasanth Jayachandran < pjayachand...@hortonworks.com> wrote: > Congratulations Sahil! > > Thanks > Prasanth > > > > On Mon, Jul 30, 2018 at 12:33 PM -0700, "Xuefu Zhang" > mailto:xu...@uber.com.INVALID>> wrote: > > > Congrats, Sahil! > > On

Re: [ANNOUNCE] New committer: Slim Bouguerra

2018-07-30 Thread Vihang Karajgaonkar
Congrats Slim! On Mon, Jul 30, 2018 at 4:35 PM, Deepak Jaiswal wrote: > Congrats Slim! > > On 7/30/18, 4:03 PM, "Prasanth Jayachandran" < > pjayachand...@hortonworks.com> wrote: > > Congratulations Slim! > > > On Jul 30, 2018, at 4:00 PM, Sergey Shelukhin < > ser...@hortonworks.com> wro

Re: [ANNOUNCE] New PMC Member : Vihang Karajgaonkar

2018-07-30 Thread Vihang Karajgaonkar
y > > wrote: > > > > > Congratulations Vihang! > > > > > > > On Jul 29, 2018, at 22:32, Vineet Garg wrote: > > > > > > > > Congratulations Vihang! > > > > > > > >> On Jul 26, 2018, at 11:27 AM, Ashutosh Chauhan > >

Re: ptests fail due to a port conflict

2018-08-14 Thread Vihang Karajgaonkar
MiniHS2 retries upto 10 times to find a free port from what I see here , unless this particular test is not using that. On Tue, Aug 14, 2018 at 1:20 PM, Sergey Shelukhin wrote: >

Re: [ANNOUNCE] New committer: Andrew Sherman

2018-09-20 Thread Vihang Karajgaonkar
Congratulations Andrew! On Tue, Sep 4, 2018 at 11:00 AM Vaibhav Gumashta wrote: > Congratulations Andrew! > > On 9/4/18, 10:36 AM, "Sahil Takiar" wrote: > > Congrats Andrew! > > On Tue, Sep 4, 2018 at 12:02 AM Antal Sinkovits > wrote: > > > Congratulations Andrew! > > >

Re: [ANNOUNCE] New committer: Janaki Lahorani

2018-10-09 Thread Vihang Karajgaonkar
Congratulations Janaki! On Tue, Oct 9, 2018 at 8:27 AM Andrew Sherman wrote: > Congratulations Janaki! > > On Mon, Oct 8, 2018 at 10:05 PM Ashutosh Chauhan > wrote: > > > Apache Hive's Project Management Committee (PMC) has invited Janaki > > Lahorani to become a committer, and we are pleased t

Re: skip batching of tests

2018-10-17 Thread Vihang Karajgaonkar
> > master-mr2.properties has to be updated on the ptest servers and restarted > afaik (atleast it used to be). Don't think we need a restart. Just updating the properties file should be enough. I have updated the test configuration so that these tests are skipped from batching for now. I still

Re: [ANNOUNCE] New committer: Nishant Bangarwa

2018-10-19 Thread Vihang Karajgaonkar
Congrats Nishant! On Fri, Oct 19, 2018 at 11:02 AM, Deepak Jaiswal wrote: > Congratulations! > > On 10/19/18, 10:14 AM, "Vineet Garg" wrote: > > Congrats Nishant! > > > On Oct 19, 2018, at 8:36 AM, Gunther Hagleitner < > ghagleit...@hortonworks.com> wrote: > > > > Congrats Nish

Re: Precommit build timing out

2018-10-23 Thread Vihang Karajgaonkar
I took a quick look at it from the server side. It seems ok. I think the jenkins node is not able to ping the ptest server. On Tue, Oct 23, 2018 at 4:13 PM, Jesus Camacho Rodriguez < jcamachorodrig...@hortonworks.com> wrote: > Hi, > > Last three builds have timed out after 8 hours. Any idea on wh

Re: Precommit build timing out

2018-10-24 Thread Vihang Karajgaonkar
Restarted ptest server and confirmed its back up and running. There was some outage on the jenkins side as well as GCE yesterday. Not sure what caused it really, but looks ok now. On Tue, Oct 23, 2018 at 4:48 PM, Vihang Karajgaonkar wrote: > I took a quick look at it from the server side.

Re: [ANNOUNCE] New PMC Member : Zoltan

2018-10-31 Thread Vihang Karajgaonkar
Congrats Zoltan! On Wed, Oct 31, 2018 at 1:10 AM, Peter Vary wrote: > Congratulations Zoltan! > Well deserved! > > > On Oct 31, 2018, at 06:16, Prasanth Jayachandran < > pjayachand...@hortonworks.com> wrote: > > > > Congratulations! > > > >> On Oct 30, 2018, at 10:15 PM, Deepak Jaiswal > wrote:

Re: Ptests not working

2018-10-31 Thread Vihang Karajgaonkar
Created https://issues.apache.org/jira/browse/INFRA-17193 On Wed, Oct 31, 2018 at 1:30 AM, Peter Vary wrote: > Likely not ptest issue, but restarted ptest anyway. > > It says: > (pending—Waiting for next available executor on Hadoop < > https://builds.apache.org/label/Hadoop>) > > So maybe Apach

Re: Ptests not working

2018-10-31 Thread Vihang Karajgaonkar
Okay, looks like there was some jenkins issue which was fixed yesterday. But by that time the queue became very large. Also, many of executors are down due to disk issue INFRA-17188 <https://issues.apache.org/jira/browse/INFRA-17188> On Wed, Oct 31, 2018 at 10:49 AM, Vihang Karajgaonkar

Re: Ptests not working

2018-11-01 Thread Vihang Karajgaonkar
Precommit jobs are back up. The older precommit queue was drained by the infrastructure team so you may have to re-submit the patch in case you don't see it in the current queue. On Wed, Oct 31, 2018 at 12:18 PM, Vihang Karajgaonkar wrote: > Okay, looks like there was some jenkins iss

Re: [ANNOUNCE] New committer: Bharathkrishna Guruvayoor Murali

2018-12-02 Thread Vihang Karajgaonkar
Congratulations Bharath! On Sun, Dec 2, 2018 at 9:33 AM Sahil Takiar wrote: > Congrats Bharath! > > On Sun, Dec 2, 2018 at 11:14 AM Andrew Sherman > wrote: > > > Congratulations Bharath! > > > > On Sat, Dec 1, 2018 at 10:26 AM Ashutosh Chauhan > > wrote: > > > > > Apache Hive's Project Managem

[DISCUSS]: Commit guidelines for PRs

2020-06-30 Thread Vihang Karajgaonkar
Thanks to all who worked on the new testing infrastructure. It definitely looks like a step up from the older test infrastructure. I wanted to know if there are any new guidelines for a committer for merging the PRs. Earlier we used to create one patch file for each JIRA and push it to the master

Re: Contributions from dataproc-metastore

2021-02-04 Thread Vihang Karajgaonkar
Thanks Zoltan for your email. Just to give some context, dataproc-metastore is Google's metastore compatible cloud service. The good news is that they are happy and willing to contribute any improvements/fixes to Apache Hive (metastore specifically) instead of forking out the repository. They also

Re: Contributions from dataproc-metastore

2021-02-08 Thread Vihang Karajgaonkar
and Zoltan did well to raise awareness > > > around this topic. > > > Of course, not everyone is familiar with these processes so as Vihang > > > pointed out it would be good to improve the documentation and point > > people > > > to that when necessary. &g

Review Request 62453: HIVE-17371 : Move tokenstores to metastore module

2017-09-22 Thread Vihang Karajgaonkar
9f0ca829b1e3a469a3275c54a74d90278fc030fa Diff: https://reviews.apache.org/r/62453/diff/1/ Testing --- HiveQA Thanks, Vihang Karajgaonkar

Re: Review Request 62487: HIVE-17563: CodahaleMetrics.JsonFileReporter is not updating hive.service.metrics.file.location

2017-09-22 Thread Vihang Karajgaonkar
/JsonFileMetricsReporter.java Line 53 (original), 68 (patched) <https://reviews.apache.org/r/62487/#comment262345> Its not clear looking at the code why we are using java.nio.file.Path instead of org.apache.hadoop.fs.Path. Can you please add a comment explain the same? - Vihang Karajg

Re: HIVE-9800 how to trigger

2017-09-22 Thread Vihang Karajgaonkar
The jenkins job to test schema changes is currently not working. HIVE-15349 was created to fix that. I think we should fix that soon, I remember I had fixed some simple syntax errors in our db scripts which would have been caught if this job was wo

Re: [Announce] New committer: Sankar Hariappan

2017-09-30 Thread Vihang Karajgaonkar
Congrats Sankar! On Sat, Sep 30, 2017 at 7:51 AM, Sushanth Sowmyan wrote: > Welcome aboard! :) > > On Sep 30, 2017 3:28 AM, "Barna Zsombor Klara" > > wrote: > > Congrats Sankar! > > Rajesh Balamohan (időpont: 2017. szept. 30., Szo, > 2:24) ezt írta: > > > Congrats Sankar!! > > > > ~Rajesh.B >

Re: [Announce] New committer: Anishek Agarwal

2017-09-30 Thread Vihang Karajgaonkar
Congrats Anishek! On Sat, Sep 30, 2017 at 7:51 AM, Sushanth Sowmyan wrote: > Welcome aboard! :) > > On Sep 30, 2017 3:27 AM, "Barna Zsombor Klara" > > wrote: > > > Congratulations Anishek! > > > > Rajesh Balamohan (időpont: 2017. szept. 30., > Szo, > > 2:25) ezt írta: > > > > > Congrats Anishe

Re: Review Request 62453: HIVE-17371 : Move tokenstores to metastore module

2017-10-05 Thread Vihang Karajgaonkar
4abcec789476982389b3c0bc34d4990c59dbf9da standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/utils/SecurityUtils.java 9f0ca829b1e3a469a3275c54a74d90278fc030fa Diff: https://reviews.apache.org/r/62453/diff/2/ Changes: https://reviews.apache.org/r/62453/diff/1-2/ Testing --- HiveQA Thanks, Vihang

Re: Review Request 62453: HIVE-17371 : Move tokenstores to metastore module

2017-10-06 Thread Vihang Karajgaonkar
, Vihang Karajgaonkar

Re: ptests are broken

2017-10-20 Thread Vihang Karajgaonkar
Looks like the ptests is are working back now. I guess HIVE-17864 fixed it. On Thu, Oct 19, 2017 at 10:44 PM, Zoltan Haindrich wrote: > Hello, > > It seems like ptests are broken down :) > From the logs I suspect that the problem is possibly caused by the version > change of testutils/ptest2/pom

pre-commit not working?

2017-10-23 Thread Vihang Karajgaonkar
https://builds.apache.org/job/PreCommit-HIVE-Build/# does not seem to be picking up new patches. I checked on the ptest server side and it seems to be working fine. The build queue shows a weird "(pending—H14 doesn’t have label Hadoop; H15 doesn’t have label Hadoop; " message which I haven't seen

Re: pre-commit not working?

2017-10-24 Thread Vihang Karajgaonkar
t; On Mon, Oct 23, 2017 at 5:40 PM, Prasad Nagaraj Subramanya < > prasadn...@gmail.com> wrote: > > > Looks like the Jenkins node with label "Hadoop" has been removed, it > > doesn't show up in Jenkins. > > > > On Mon, Oct 23, 2017 at 5:25 PM, Vihang Kar

Re: ptests are broken

2017-10-25 Thread Vihang Karajgaonkar
Admin/ On Wed, Oct 25, 2017 at 12:40 PM, Sergey Shelukhin wrote: > Still looks broken… there is no running ptest and a few are pending. > > On 17/10/20, 13:03, "Vihang Karajgaonkar" wrote: > > >Looks like the ptests is are working back now. I guess HIVE-17864 fixed >

Re: ptests are broken

2017-10-25 Thread Vihang Karajgaonkar
Link to the INFRA ticket incase you anyone is searching for it. https://issues.apache.org/jira/browse/INFRA-15358 On Wed, Oct 25, 2017 at 12:48 PM, Vihang Karajgaonkar wrote: > It was working for a while and now it looks like it doesn't have any > executors for running the jenkins

Re: Hive metastore TLP

2017-11-01 Thread Vihang Karajgaonkar
Its great to hear that you are considering integrating Metastore to store metadata for Drill. Couple of things to note regarding the timeline though. As pointed by Alan the work being done in HIVE-17159 is on the master branch which currently points to Hive 3.0 The latest release of Hive is 2.3 whi

Re: ptest not picking patches

2017-11-01 Thread Vihang Karajgaonkar
Is there a way to find out if Jenkins was restarted since we submitted the patch? Not sure if we can fix this in our precommit job. There have been far too many instances recently when Jenkins was either restarted or was non-responsive for long durations which delayed testing for our patches. On W

Re: ptest not picking patches

2017-11-02 Thread Vihang Karajgaonkar
day and all of them are gone from the queue. > > > > Thanks > > Prasanth > > > > > >> On Nov 1, 2017, at 11:28 AM, Vihang Karajgaonkar < > vih...@cloudera.com> wrote: > >> > >> Is there a way to find out if Jenkins was restarted

Re: ptest not picking patches

2017-11-02 Thread Vihang Karajgaonkar
I don’t see my jira picked up too HIVE-17834, HIVE-17885. Some patches > gets picked but some of them are not. > > Thanks > Prasanth > > > On Nov 2, 2017, at 11:47 AM, Vihang Karajgaonkar > wrote: > > > > I don't see any problems currently on the queue.

Re: [Announce] New committer: Tao Li

2017-11-03 Thread Vihang Karajgaonkar
Congratulations Tao! On Fri, Nov 3, 2017 at 10:12 AM, Jesus Camacho Rodriguez < jcama...@apache.org> wrote: > Congrats Tao! > > > > > On 11/3/17, 8:32 AM, "Sergio Pena" wrote: > > >Congratulations Tao !!! > > > >On Wed, Nov 1, 2017 at 2:13 PM, Peter Vary wrote: > > > >> Congratulations Tao! :)

Re: Integrating Yetus with Precommit job

2017-11-06 Thread Vihang Karajgaonkar
Thanks Adam for this work. This is definitely useful and a good addition to our test infrastructure. Can we fix the existing issues pointed by Yetus (in a separate JIRA) so that we have a +1 from yetus on the current code? Once that is done, committers can help keep it green as they review patches

Re: Integrating Yetus with Precommit job

2017-11-22 Thread Vihang Karajgaonkar
Thanks Adam for this work! On Wed, Nov 22, 2017 at 5:46 AM, Adam Szita wrote: > This is now done. Patch is committed and we deployed the new war file to > the ptest server. > > Jobs that were waiting in queue at the time of ptest server restart have > been retriggered in Jenkins. > > I hope this

Re: ptests are broken

2017-11-27 Thread Vihang Karajgaonkar
I restarted the Ptest server and submitted a patch. The build seems to be working so far. Will keep a watch on it until it completes. On Mon, Nov 27, 2017 at 8:54 AM, Zoltan Haindrich wrote: > Hello, > > There are some issues with the test execution at > https://builds.apache.org/job/PreCommit-H

Re: ptests are broken

2017-11-27 Thread Vihang Karajgaonkar
Build completed fine. So we are back on track now. On Mon, Nov 27, 2017 at 11:00 AM, Vihang Karajgaonkar wrote: > I restarted the Ptest server and submitted a patch. The build seems to be > working so far. Will keep a watch on it until it completes. > > On Mon, Nov 27, 2017 at 8:5

Re: [Announce] New committer: Deepak Jaiswal

2018-01-08 Thread Vihang Karajgaonkar
Congrats Deepak! On Mon, Jan 8, 2018 at 10:25 AM, Mithun RK wrote: > Congratulations, Deepak! > > On Mon, Jan 8, 2018 at 10:14 AM D K wrote: > > > Congratulations Deepak! > > > > On Fri, Jan 5, 2018 at 2:18 PM, Ashutosh Chauhan > > wrote: > > > > > The Project Management Committee (PMC) for Ap

Re: ptest broken?

2018-01-16 Thread Vihang Karajgaonkar
Looks like the pre-commit admin job which automatically triggers pre-commit hive jobs is broken and has been failing with the following error: + python /home/jenkins/jenkins-slave/workspace/PreCommit-Admin/nightly/jenkinsPrecommitAdmin.py '--jira-filter=https://issues.apache.org/jira/sr/jira.issu

Re: ptest broken?

2018-01-16 Thread Vihang Karajgaonkar
Created https://issues.apache.org/jira/browse/INFRA-15849 Hopefully someone who manages this job takes a look soon. On Tue, Jan 16, 2018 at 11:19 AM, Vihang Karajgaonkar wrote: > Looks like the pre-commit admin job which automatically triggers > pre-commit hive jobs is broken and ha

Re: ptest broken?

2018-01-16 Thread Vihang Karajgaonkar
Okay looks like we need to move from SOAP to REST and change the pre-commit admin job to make it work (check comment on the infra JIRA above). Does anyone know how/who can fix that? I don't have permissions to edit the job. On Tue, Jan 16, 2018 at 11:28 AM, Vihang Karajgaonkar wrote: >

Re: Rebasing standalone-metastore branch

2018-01-16 Thread Vihang Karajgaonkar
Thanks for the headsup Alan. I am okay with the rebasing standalone-metastore branch. Will update my WIP patches accordingly. On Tue, Jan 16, 2018 at 2:01 PM, Alan Gates wrote: > I’ve committed HIVE-17982 to master. I have been rebasing > standalone-metastore after each push of a patch from it

Re: Switched PreCommit-Admin over to Apache Yetus

2018-01-16 Thread Vihang Karajgaonkar
Thanks Allen for fixing the precommit-admin job. All, The issue with precommit hive job reported in https://issues.apache.org/jira/browse/HIVE-18461 is fixed as well. So automated precommit tests should be back for Hive. Incase your patch didn't make the precommit tests during this downtime, you

Re: Hive packaging and the standalone metastore

2018-01-26 Thread Vihang Karajgaonkar
I think its important to keep supporting "hive --service metastore" for backwards compatibility. I also think it would be great to have some separation in the lib/bin if possible so that it is easier for someone who downloads Hive but just wants to deploy a standalone-metastore to identify which ja

Re: Hive packaging and the standalone metastore

2018-01-26 Thread Vihang Karajgaonkar
hink to test. > > Alan. > > On Fri, Jan 26, 2018 at 10:10 AM, Vihang Karajgaonkar > > wrote: > > > I think its important to keep supporting "hive --service metastore" for > > backwards compatibility. I also think it would be great to have some > > s

Re: Long running time for recently added tests in standalone-metastore

2018-01-30 Thread Vihang Karajgaonkar
+1 I think thats a great idea. Hopefully, this will help reducing some load on HiveQA jobs as well. Currently, most of the patches go through multi-iteration HiveQA runs at-least some of which could have been avoided if there is a light-weight test profile which can be run locally. This would be a

Re: Intellij + Checkstyle setup

2018-02-01 Thread Vihang Karajgaonkar
Thanks for sharing Vineet. How is this different than https://github.com/apache/hive/blob/master/dev-support/eclipse-styles.xml I was able to import this in IntelliJ just fine. On Thu, Feb 1, 2018 at 4:42 PM, Vineet Garg wrote: > Hi, > > If you would like to use Intellij’s checkstyle plugin an

Re: ptest seems stuck

2018-02-02 Thread Vihang Karajgaonkar
https://builds.apache.org/job/PreCommit-HIVE-Build/ It looks like there are no executors available to run the job. On Fri, Feb 2, 2018 at 2:15 PM, Deepak Jaiswal wrote: > Hi All, > > It looks like ptest is stuck. Cant figure out the cause. > > Regards, > Deepak >

[DISCUSS] 26 Unit tests failing regularly

2018-02-06 Thread Vihang Karajgaonkar
I see that the regularly failing unit tests on the master branch is slowly climbing up and its close to ~26 now. Many of these don't seem to be "flaky" test failures since they are consistently failing for a while with the same error message. Some of these can be fixed by a simple q.out update whil

Re: Unit Test Failing

2018-02-06 Thread Vihang Karajgaonkar
ailing > which are not related to my code. > > There is a mail by Vihang Karajgaonkar by subject as *[DISCUSS] 26 unit > test failing regularly*. > I had tested my code before and it was working, but after some commits, > there are failing of test cases. > > Please someone help me out. > > Thanks > Madhudeep Petwal >

Re: [DISCUSS] 26 Unit tests failing regularly

2018-02-07 Thread Vihang Karajgaonkar
tCliDriver[ > > auto_sortmerge_join_2] > > > > On 2/6/18, 9:54 AM, "Vihang Karajgaonkar" wrote: > > > > org.apache.hadoop.hive.cli.TestMiniLlapCliDriver. > > testCliDriver[llap_smb] > > > > > > > -- > Sahil Takiar > Software Engineer > takiar.sa...@gmail.com | (510) 673-0309 >

Re: Test scripts for various metastore databases

2018-02-13 Thread Vihang Karajgaonkar
We used to have a job which ran some tests when there were schema changes in the patch. It ran scripts from testutils/metastore to setup and run some basic validation checks (primarily to detect incompatible schema changes and schema upgrades). I think we should run similar tests whenever schema ch

Re: tests on branch-2?

2018-02-20 Thread Vihang Karajgaonkar
branch-2 HiveQA works as long as you name the patch file with convention .-.patch You can take a look at HIVE-18449 for example. On Tue, Feb 20, 2018 at 12:34 PM, Sergey Shelukhin wrote: > Do we have HiveQA set up for branch-2? > I noticed that

  1   2   3   4   5   6   >