r.java
<https://reviews.apache.org/r/23270/#comment83869>
Do we need this?
ql/src/test/queries/clientpositive/correlationoptimizer16.q
<https://reviews.apache.org/r/23270/#comment83870>
I think correlationoptimizer8 is for cases with UNION ALL. Can we add test
queries i
Hi,
Based on our language manual (
https://cwiki.apache.org/confluence/display/Hive/LanguageManual+UDF), seems
we do not support "==" operator. However, in FunctionRegistry, we treat
"==" as "=". I guess we want to make "==" invalid and throw an exception
when a user uses it?
Thanks,
Yin
Let me add Reynold to the thread.
On Fri, Dec 18, 2015 at 12:36 PM, Gopal Vijayaraghavan
wrote:
>
> >We have looked into various options, and it looks like the best option is
> >to copy the ANTLR grammar file from Hive into Spark. Because the grammar
> >file is tightly coupled with Hive's semant
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2001/
---
Review request for hive.
Summary
---
This optimizer exploits intra-query co
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2001/
---
(Updated 2011-12-05 19:12:23.087778)
Review request for hive.
Changes
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2001/
---
(Updated 2011-12-29 18:50:12.277210)
Review request for hive.
Summary
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2001/
---
(Updated 2012-01-29 17:56:48.704757)
Review request for hive.
Changes
---
gt; > findNextChildReduceSinkOperator can return null, do you need to check
> > for this?
findNextChildReduceSinkOperator will not return null since its input will not
be the last ReduceSinkOperator before the FileSinkOperator. For example,
suppose that we have
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2001/
---
(Updated 2012-02-10 20:49:01.177796)
Review request for hive.
Changes
---
Hello All,
When I run hive unit tests, I always can find an error saying the class
of org.apache.hadoop.log.metrics.EventCounter can not be found. Seems the
reason is that in hadoop 0.20.2, the location of EventCounter is
org.apache.hadoop.metrics.jvm.EventCounter, so log4j should load the old
cla
relevant to the patch. Please see
https://issues.apache.org/jira/browse/HIVE-2206?focusedCommentId=13456171&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13456171
for details.
Thanks,
Yin Huai
://issues.apache.org/jira/browse/HIVE-2206?focusedCommentId=13456171&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13456171
for details.
Thanks,
Yin Huai
skewjoinopt19.q to skewjoinopt20.q, I cannot test these
queries on my machine either. All other tests pass.
Thanks,
Yin Huai
skewjoinopt17.q, and skewjoinopt19.q to skewjoinopt20.q, I cannot test these
queries on my machine either. All other tests pass.
Thanks,
Yin Huai
skewjoinopt19.q to skewjoinopt20.q, I cannot test these
queries on my machine either. All other tests pass.
Thanks,
Yin Huai
skewjoinopt19.q to skewjoinopt20.q, I cannot test these
queries on my machine either. All other tests pass.
Thanks,
Yin Huai
skewjoinopt20.q, I cannot test these
queries on my machine either. All other tests pass.
Thanks,
Yin Huai
iew11858
-------
On Sept. 24, 2012, 3:53 p.m., Yin Huai wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7126/
> -
pt5.q, skewjoinopt10.q, skewjoinopt15.q to
skewjoinopt17.q, and skewjoinopt19.q to skewjoinopt20.q, I cannot test these
queries on my machine either. All other tests pass.
Thanks,
Yin Huai
://reviews.apache.org/r/7126/diff/
Testing (updated)
---
All tests pass.
Thanks,
Yin Huai
/clientpositive/nullgroup4.q.out 3dd3c66
ql/src/test/results/clientpositive/nullgroup4_multi_distinct.q.out 9ac4bbc
Diff: https://reviews.apache.org/r/7221/diff/
Testing (updated)
---
All tests pass.
Thanks,
Yin Huai
)
---
All tests pass.
Thanks,
Yin Huai
/results/clientpositive/nullgroup4.q.out 3dd3c66
ql/src/test/results/clientpositive/nullgroup4_multi_distinct.q.out 9ac4bbc
Diff: https://reviews.apache.org/r/7221/diff/
Testing
---
All tests pass.
Thanks,
Yin Huai
/results/clientpositive/nullgroup4.q.out 3dd3c66
ql/src/test/results/clientpositive/nullgroup4_multi_distinct.q.out 9ac4bbc
Diff: https://reviews.apache.org/r/7221/diff/
Testing
---
All tests pass.
Thanks,
Yin Huai
/clientpositive/create_view.q 0af3442
ql/src/test/results/clientpositive/create_view.q.out 3b78f1e
Diff: https://reviews.apache.org/r/7222/diff/
Testing
---
All tests pass.
Thanks,
Yin Huai
Diffs (updated)
-
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 3f2
ql/src/test/queries/clientpositive/create_view.q 0af3442
ql/src/test/results/clientpositive/create_view.q.out 3b78f1e
Diff: https://reviews.apache.org/r/7222/diff/
Testing
---
All tests pass.
Thanks,
Yin Huai
/clientpositive/nullgroup4_multi_distinct.q.out 9ac4bbc
ql/src/test/results/clientpositive/udaf_percentile_approx.q.out 4f85a82
Diff: https://reviews.apache.org/r/7221/diff/
Testing
---
All tests pass.
Thanks,
Yin Huai
l/src/test/results/clientpositive/nullgroup4_multi_distinct.q.out 9ac4bbc
ql/src/test/results/clientpositive/udaf_percentile_approx.q.out 4f85a82
Diff: https://reviews.apache.org/r/7221/diff/
Testing
---
All tests pass.
Thanks,
Yin Huai
Congrats Brock!
On Tue, Jul 16, 2013 at 1:26 PM, Lefty Leverenz wrote:
> Congratulations & hooray, another committer to share the load!
>
> – Lefty
>
>
>
> On Tue, Jul 16, 2013 at 12:49 PM, Mark Grover
> wrote:
>
> > Congrats, Brock!
> >
> > On Tue, Jul 16, 2013 at 12:31 PM, Thejas Nair
> > wro
mac and tests passed.
Thanks,
Yin Huai
Hi Mainak,
Can you try 'ant test -Dtestcase=TestRCFile'? It should work.
Thanks,
Yin
On Fri, Jul 19, 2013 at 10:16 AM, Mainak Ghosh wrote:
>
>
> Hello,
>
> I am new to Hive codebase and was hoping to run some of its test code
> specifically TestRCFile.java. Unfortunately I am not sure what a
>
> Any idea what these are? How to resolve them?
>
> I personally do not have a lot of idea on remote debugging Hive. So a step
> by step manual if present would be of great help.
>
> Thanks and Regards,
> Mainak.
>
>
> [image: Inactive hide details for Yin Huai ---07
94
> > <https://reviews.apache.org/r/12767/diff/1/?file=323664#file323664line194>
> >
> > I think this should read as:
> > // remove the tag from key coming out of reducer and store it in
> > separate variable.
Done
- Yin
---
This is an automatic
s are hbase_stats_empty_partition.q and ppd_key_ranges.q in
TestHBaseCliDriver.
I manually tested these two in my mac and tests passed.
Thanks,
Yin Huai
Errors Success rateTime
26882 0 99.93% 43249.945
Two failures are hbase_stats_empty_partition.q and ppd_key_ranges.q in
TestHBaseCliDriver.
I manually tested these two in my mac and tests passed.
Thanks,
Yin Huai
a debugger with breakpoints inside the code. Any idea how I can
> achieve that?
>
> The problem here is my debugger attaches to the live instance of hive and
> testcase runs using ant.
>
> Thanks and Regards,
> Mainak.
>
> [image: Inactive hide details for Yin Huai ---07/19/2
------
On July 19, 2013, 5 p.m., Yin Huai wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12767/
>
,
Yin Huai
Congratulations Gunther!
On Sun, Jul 21, 2013 at 7:55 AM, Jarek Jarcec Cecho wrote:
> Congratulations Gunther!
>
> Jarcec
>
> On Sun, Jul 21, 2013 at 01:00:31AM -0700, Carl Steinbach wrote:
> > The Apache Hive PMC has voted to make Gunther Hagleitner a
> > committer on the Apache Hive project.
>
Diff: https://reviews.apache.org/r/12795/diff/
Testing
---
Running tests.
Thanks,
Yin Huai
Why is this? Should work regardless, no?
This part is from trunk. I will take a look and see why we need it
- Yin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12795/#review23671
---
On
----
On July 22, 2013, 4:19 a.m., Yin Huai wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12795/
> ---
>
.
Thanks,
Yin Huai
/clientpositive/multi_join_union.q.out 5182bdf
ql/src/test/results/clientpositive/union34.q.out 166062a
Diff: https://reviews.apache.org/r/12795/diff/
Testing
---
Running tests.
Thanks,
Yin Huai
/clientpositive/multiMapJoin2.q.out PRE-CREATION
ql/src/test/results/clientpositive/multi_join_union.q.out 5182bdf
ql/src/test/results/clientpositive/union34.q.out 166062a
Diff: https://reviews.apache.org/r/12795/diff/
Testing
---
Running tests.
Thanks,
Yin Huai
/multi_join_union.q.out 5182bdf
ql/src/test/results/clientpositive/union34.q.out 166062a
Diff: https://reviews.apache.org/r/12795/diff/
Testing
---
Running tests.
Thanks,
Yin Huai
/test/results/clientpositive/multi_join_union.q.out 5182bdf
ql/src/test/results/clientpositive/union34.q.out 166062a
Diff: https://reviews.apache.org/r/12795/diff/
Testing
---
Running tests.
Thanks,
Yin Huai
/multiMapJoin2.q.out PRE-CREATION
ql/src/test/results/clientpositive/multi_join_union.q.out 5182bdf
ql/src/test/results/clientpositive/union34.q.out 166062a
Diff: https://reviews.apache.org/r/12795/diff/
Testing
---
Running tests.
Thanks,
Yin Huai
Hi all,
After importing the trunk to eclipse, I found that eclipse did not load the
hive formatter. Does trunk still have one? If so, where is the location of
it?
Thanks,
Yin
/apache/hadoop/hive/ql/plan/ConditionalResolverCommonJoin.java
<https://reviews.apache.org/r/16172/#comment58602>
Let's change it to log the exception instead of printing the stack trace.
- Yin Huai
On Dec. 11, 2013, 2:12 a.m., Navis Ryu wrote:
>
>
tps://reviews.apache.org/r/16172/#comment58622>
Seems it is not an error? If so, let's not put it in the ErrorMsg.
ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolverCommonJoin.java
<https://reviews.apache.org/r/16172/#comment58623>
Is this one necessary?
- Yin Huai
de in GenMapRedUtils, we do not expect this check
(aliases.contains(mapJoinAlias)) will be true, right? If so, let's add a
comment at here tell other code readers that they should not expect to find any
conflict on aliases.
- Yin Huai
On Dec. 20, 2013,
Congrats Gunther!
On Fri, Dec 27, 2013 at 10:13 AM, Brock Noland wrote:
> Congratulations Gunther!
>
>
> On Fri, Dec 27, 2013 at 9:00 AM, Xuefu Zhang wrote:
>
> > Many congratulations, Gunther!
> >
> > --Xuefu
> >
> >
> > On Thu, Dec 26, 2013 at 8:59 PM, Carl Steinbach wrote:
> >
> > > I am p
/ConditionalResolverCommonJoin.java
<https://reviews.apache.org/r/16172/#comment59277>
For the example in the description of HIVE-5945, the same alias "$INTNAME"
can actually refer to different intermediate tables. So, at here, we will not
update the correct size for an alias "$INTNAME".
/
Testing
---
Thanks,
Yin Huai
/diff/
Testing
---
All tests pass.
Thanks,
Yin Huai
://reviews.apache.org/r/7126/diff/
Testing
---
All tests pass.
Thanks,
Yin Huai
://reviews.apache.org/r/7126/diff/
Testing
---
All tests pass.
Thanks,
Yin Huai
/groupby1.q.xml e1eb209
ql/src/test/results/compiler/plan/groupby2.q.xml 268eb90
ql/src/test/results/compiler/plan/groupby3.q.xml 3e02d15
ql/src/test/results/compiler/plan/groupby5.q.xml 89e1207
Diff: https://reviews.apache.org/r/7126/diff/
Testing
---
All tests pass.
Thanks,
Yin Huai
/
Testing
---
All tests pass.
Thanks,
Yin Huai
/plan/groupby2.q.xml 7b07f02
ql/src/test/results/compiler/plan/groupby3.q.xml a6a1986
ql/src/test/results/compiler/plan/groupby5.q.xml 25e3583
Diff: https://reviews.apache.org/r/7126/diff/
Testing
---
All tests pass.
Thanks,
Yin Huai
t; implementation and how endGroup() is dealt with in processOp()
done
> On Jan. 10, 2013, 2:24 a.m., Ashutosh Chauhan wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/exec/CorrelationLocalSimulativeReduceSinkOperator.java,
> > line 294
> > <https
Does this imply CLSRSOperator cannot have more than one child operator
> > in any case. If so, can you please add comments stating that along with
> > small description why is that?
>
> Yin Huai wrote:
> I thought that, in the original plan, a ReduceSinkOperator
/groupby5.q.xml 632d88e
Diff: https://reviews.apache.org/r/7126/diff/
Testing
---
All tests pass.
Thanks,
Yin Huai
Can you try to set serde properties?
https://cwiki.apache.org/confluence/display/Hive/LanguageManual+DDL#LanguageManualDDL-AddSerDeProperties
I have not tried it, but seems it is the right way to pass configurations
to serde class.
Thanks,
Yin
On Mon, Oct 14, 2013 at 8:20 AM, Rui Martins wrot
+1
On Thu, Oct 17, 2013 at 5:51 PM, Gunther Hagleitner <
ghagleit...@hortonworks.com> wrote:
> +1
>
> Thanks,
> Gunther.
>
>
> On Thu, Oct 17, 2013 at 2:18 PM, Owen O'Malley wrote:
>
> > Ed,
> > I didn't remember being unable to see revisions without a login. That
> is
> > uncool. I'll change
/src/test/results/clientpositive/correlationoptimizer1.q.out dc46a77
Diff: https://reviews.apache.org/r/15101/diff/
Testing
---
HiveQA
Thanks,
Yin Huai
Congrats Xuefu!
On Mon, Nov 4, 2013 at 7:11 AM, Lianhui Wang wrote:
> Congrats Xuefu!
>
>
> 2013/11/4 Thejas Nair
>
> > Congrats Xuefu!
> >
> > On Sun, Nov 3, 2013 at 11:11 PM, Mohammad Islam
> > wrote:
> > > Congrats Xuefu!
> > >
> > > --Mohammad
> > >
> > >
> > > On Sunday, November 3, 2013
Guys,
Seems ConditionalResolverCommonJoin is not working correctly? I created
https://issues.apache.org/jira/browse/HIVE-6668 and set it as a blocker.
thanks,
Yin
On Fri, Mar 14, 2014 at 11:34 AM, Thejas Nair wrote:
> Can you also add HIVE-6647 <
> https://issues.apache.org/jira/browse/HIVE-6
Congrats Thejas!!!
On Tue, Aug 20, 2013 at 4:54 PM, Thejas Nair wrote:
> Thanks everybody!
> This is a great honor. I hope to live up to the expectations!
>
> It is great to see the fresh momentum in hive and I am glad to be able to
> work with the community on it.
> Now I will also do my best
Seems ReduceSinkDeDuplication picked the wrong partitioning columns.
On Fri, Aug 23, 2013 at 9:15 PM, Shahansad KP wrote:
> I think the problem lies with in the group by operation. For this
> optimization to work the group bys partitioning should be on the column 1
> only.
>
> It wont effect th
Created a jira https://issues.apache.org/jira/browse/HIVE-5149
On Sun, Aug 25, 2013 at 9:11 PM, Yin Huai wrote:
> Seems ReduceSinkDeDuplication picked the wrong partitioning columns.
>
>
> On Fri, Aug 23, 2013 at 9:15 PM, Shahansad KP wrote:
>
>> I think the problem lies
forgot to add in my last reply To generate correct results, you can
set hive.optimize.reducededuplication to false to turn off
ReduceSinkDeDuplication
On Sun, Aug 25, 2013 at 9:35 PM, Yin Huai wrote:
> Created a jira https://issues.apache.org/jira/browse/HIVE-5149
>
>
> On
Diff: https://reviews.apache.org/r/13862/diff/
Testing
---
Thanks,
Yin Huai
ql/src/test/results/clientpositive/reduce_deduplicate_extended.q.out 3297ebb
Diff: https://reviews.apache.org/r/13862/diff/
Testing
---
Thanks,
Yin Huai
a52f4eb
ql/src/test/results/clientpositive/groupby_rollup1.q.out f120471
ql/src/test/results/clientpositive/reduce_deduplicate_extended.q.out 3297ebb
Diff: https://reviews.apache.org/r/13862/diff/
Testing
---
Thanks,
Yin Huai
c380a2d
ql/src/test/queries/clientpositive/reduce_deduplicate_extended.q a5e9cdf
ql/src/test/results/clientpositive/reduce_deduplicate_extended.q.out 3297ebb
Diff: https://reviews.apache.org/r/13910/diff/
Testing
---
Thanks,
Yin Huai
On Sept. 2, 2013, 5:39 a.m., Yin Huai wrote:
> > Another sanity check.
Done.
- Yin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13862/#revie
On Sept. 2, 2013, 5:29 a.m., Yin Huai wrote:
> > Thanks for adding comments!
We can have a query like ...
explain select * from (select * from src1 cluster by key) tmp sort by key,
value;
In this case, at first, we have two MR jobs. Since the second job is used for
"sort by&qu
llup1.q.out f120471
ql/src/test/results/clientpositive/reduce_deduplicate_extended.q.out 3297ebb
Diff: https://reviews.apache.org/r/13862/diff/
Testing
---
Thanks,
Yin Huai
;
> > >>>> -- Lefty
> > >>>>
> > >>>>
> > >>>> On Wed, Sep 4, 2013 at 4:17 AM, Sushanth Sowmyan <
> khorg...@gmail.com>
> > >>> wrote:
> > >>>>
> > >>>>> Congrats, Yin!
Sure. Let me take a look at 0.11 branch.
On Wed, Sep 4, 2013 at 2:53 PM, Eric Chu wrote:
> Hi Yin Huai,
>
> This patch doesn't apply cleanly in Hive 11. For example,
> ReduceSinkDeDuplication.java is in
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/ in Hive 11 while the
Hi Eric,
Can you try
https://issues.apache.org/jira/secure/attachment/12601446/HIVE-5149-branch-0.11.patch?
Thanks,
Yin
On Wed, Sep 4, 2013 at 3:14 PM, Yin Huai wrote:
> Sure. Let me take a look at 0.11 branch.
>
>
> On Wed, Sep 4, 2013 at 2:53 PM, Eric Chu wrote:
>
/diff/
Testing
---
Thanks,
Yin Huai
/org/apache/hadoop/hive/serde2/columnar/LazyBinaryColumnarStruct.java
0317024
serde/src/test/org/apache/hadoop/hive/serde2/TestColumnProjectionUtils.java
PRE-CREATION
Diff: https://reviews.apache.org/r/14221/diff/
Testing
---
Thanks,
Yin Huai
---
Thanks,
Yin Huai
nnotation or have an assertion?
serde/src/java/org/apache/hadoop/hive/serde2/ColumnProjectionUtils.java
<https://reviews.apache.org/r/14221/#comment51371>
ok will remove it.
serde/src/java/org/apache/hadoop/hive/serde2/ColumnProjectionUtils.java
<https://reviews.apache.org/r/14221/#
erde2/TestColumnProjectionUtils.java
PRE-CREATION
Diff: https://reviews.apache.org/r/14221/diff/
Testing
---
Thanks,
Yin Huai
/TestColumnProjectionUtils.java
PRE-CREATION
Diff: https://reviews.apache.org/r/14221/diff/
Testing
---
Thanks,
Yin Huai
/serde2/TestColumnProjectionUtils.java
PRE-CREATION
Diff: https://reviews.apache.org/r/14221/diff/
Testing
---
Thanks,
Yin Huai
/TestColumnProjectionUtils.java
PRE-CREATION
Diff: https://reviews.apache.org/r/14221/diff/
Testing
---
Thanks,
Yin Huai
/hadoop/hive/serde2/columnar/LazyBinaryColumnarStruct.java
0317024
serde/src/test/org/apache/hadoop/hive/serde2/TestColumnProjectionUtils.java
PRE-CREATION
Diff: https://reviews.apache.org/r/14221/diff/
Testing
---
Thanks,
Yin Huai
/columnar/LazyBinaryColumnarStruct.java
0317024
serde/src/test/org/apache/hadoop/hive/serde2/TestColumnProjectionUtils.java
PRE-CREATION
Diff: https://reviews.apache.org/r/14221/diff/
Testing
---
Thanks,
Yin Huai
/columnar/LazyBinaryColumnarStruct.java
0317024
serde/src/test/org/apache/hadoop/hive/serde2/TestColumnProjectionUtils.java
PRE-CREATION
Diff: https://reviews.apache.org/r/14221/diff/
Testing
---
Thanks,
Yin Huai
/TestColumnProjectionUtils.java
PRE-CREATION
Diff: https://reviews.apache.org/r/14221/diff/
Testing
---
Thanks,
Yin Huai
[
https://issues.apache.org/jira/browse/HIVE-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14173804#comment-14173804
]
Yin Huai commented on HIVE-7205:
[~navis] Can you update the review board? I will ta
Yin Huai created HIVE-7362:
--
Summary: Enabling Correlation Optimizer by default.
Key: HIVE-7362
URL: https://issues.apache.org/jira/browse/HIVE-7362
Project: Hive
Issue Type: Task
[
https://issues.apache.org/jira/browse/HIVE-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14054303#comment-14054303
]
Yin Huai commented on HIVE-7205:
Sure. I will take a look at it.
Seems the issue is
[
https://issues.apache.org/jira/browse/HIVE-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14054454#comment-14054454
]
Yin Huai commented on HIVE-7205:
[~navis] Simplifying interactions between operator
[
https://issues.apache.org/jira/browse/HIVE-5130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14060292#comment-14060292
]
Yin Huai commented on HIVE-5130:
Design doc in Hive wiki:
https://cwiki.apache
1 - 100 of 684 matches
Mail list logo
