> On July 23, 2013, 2:24 a.m., Gunther Hagleitner wrote: > > - Have you had a chance to run this against hadoop 2? There are some union > > optimizations that only run on 23 (not on 20S) > > - It might be good to try to run the unit tests with this optimization on > > by default to see that there are no exceptions, cases you might have missed. > >
Those cases for union optimizations (union remove) are good. To run the unit tests with this optimization on by default, I also need to turn on join auto convert and no conditional task. It will take me some time to check different results. Will report what I get later. - Yin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12795/#review23673 ----------------------------------------------------------- On July 22, 2013, 4:19 a.m., Yin Huai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12795/ > ----------------------------------------------------------- > > (Updated July 22, 2013, 4:19 a.m.) > > > Review request for hive. > > > Bugs: HIVE-4827 > https://issues.apache.org/jira/browse/HIVE-4827 > > > Repository: hive-git > > > Description > ------- > > https://issues.apache.org/jira/browse/HIVE-4827 > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/OperatorUtils.java 66b84ff > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/CommonJoinTaskDispatcher.java > f98878c > ql/src/java/org/apache/hadoop/hive/ql/plan/MapredWork.java 7cbb1ff > ql/src/test/queries/clientpositive/correlationoptimizer7.q 9b18972 > ql/src/test/queries/clientpositive/multiMapJoin2.q PRE-CREATION > ql/src/test/results/clientpositive/auto_join33.q.out 8fc0e84 > ql/src/test/results/clientpositive/correlationoptimizer1.q.out db3bd78 > ql/src/test/results/clientpositive/correlationoptimizer3.q.out cebddff > ql/src/test/results/clientpositive/correlationoptimizer4.q.out 285a54f > ql/src/test/results/clientpositive/correlationoptimizer6.q.out c40a786 > ql/src/test/results/clientpositive/correlationoptimizer7.q.out ea54431 > ql/src/test/results/clientpositive/multiMapJoin1.q.out 3b3eb3f > ql/src/test/results/clientpositive/multiMapJoin2.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/12795/diff/ > > > Testing > ------- > > Running tests. > > > Thanks, > > Yin Huai > >
