Re: [ANNOUNCE] New Hive Committer - John Pullokkaran

Thanks everyone for all the wishes. On Wed, Oct 1, 2014 at 1:35 PM, Xiaobing Zhou wrote: > Congrats John! > > On Wed, Oct 1, 2014 at 12:54 PM, Matthew McCline > wrote: > >> Congrats! >> >> On Wed, Oct 1, 2014 at 8:19 AM, Carl Steinbach wrote: >> >>

Re: Review Request 26379: Disable cbo for tablesample

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26379/#review55577 --- Ship it! Ship It! - John Pullokkaran On Oct. 6, 2014, 7:50 p.m

Re: Review Request 26209: CBO trunk merge: union11 test fails due to incorrect plan

/PlanModifierForASTConv.java <https://reviews.apache.org/r/26209/#comment96136> May be rename to isEmptyGrpAggr - John Pullokkaran On Oct. 8, 2014, 12:09 a.m., pengcheng xiong wrote: > > --- > This is an automatically g

Re: Review Request 26209: CBO trunk merge: union11 test fails due to incorrect plan

/PlanModifierForASTConv.java <https://reviews.apache.org/r/26209/#comment96137> Instead of double negation check for isEmptyGrpAggr Return true if its empty - John Pullokkaran On Oct. 8, 2014, 12:09 a.m., pengcheng xiong

Re: Review Request 26461: [CBO] Handle filters with non-boolean return type

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26461/#review55923 --- Ship it! Ship It! - John Pullokkaran On Oct. 8, 2014, 10:23 p.m

Re: Review Request 26483: Correctly handle invalid distinct queries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26483/#review56063 --- Ship it! Ship It! - John Pullokkaran On Oct. 9, 2014, 5:42 p.m

Re: Review Request 26528: Use OptiqSemanticException in error condition

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26528/#review56068 --- Ship it! Ship It! - John Pullokkaran On Oct. 9, 2014, 10:21 p.m

Re: Review Request 26577: HIVE-8222: Cleanup CBO code

imator.java <https://reviews.apache.org/r/26577/#comment96573> same as above ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/stats/FilterSelectivityEstimator.java <https://reviews.apache.org/r/26577/#comment96574> This move seems less performant; i know compiler might

Re: Review Request 26577: HIVE-8222: Cleanup CBO code

<https://reviews.apache.org/r/26577/#comment96575> Please don't remove type casts in the code. If you wanto address that adress it seperately. - John Pullokkaran On Oct. 10, 2014, 9:44 p.m., Lars Francke wrote: > >

Re: Review Request 26577: HIVE-8222: Cleanup CBO code

is not key and right is not key then use -1; - John Pullokkaran On Oct. 11, 2014, 8:11 a.m., Lars Francke wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 26577: HIVE-8222: Cleanup CBO code

t97215> in the latest code this change is invalid. Please rebase the patch - John Pullokkaran On Oct. 11, 2014, 8:11 a.m., Lars Francke wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 26725: HIVE-8462 CBO duplicates column

<https://reviews.apache.org/r/26725/#comment97244> Since this fix relies on internal name, i am not sure if it will work for unaliased windowing functions. Try the following select key+value, *, rank().. ,key-value from t1; - John Pullokkaran On Oct. 15, 2014, 1:

Re: Review Request 26721: HIVE-8433 CBO loses a column during AST conversion

49> Instead of introducing a new class why don't you return a Pair - John Pullokkaran On Oct. 15, 2014, 12:44 a.m., Sergey Shelukhin wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 26725: HIVE-8462 CBO duplicates column

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26725/#review56841 --- Ship it! Ship It! - John Pullokkaran On Oct. 15, 2014, 11:07

Re: Review Request 25550: HIVE-8021 CBO: support CTAS and insert ... select

<https://reviews.apache.org/r/25550/#comment98569> Some tests reuses semanticanalyzer possibly from different threads. Its more defensive code than encountered problem. - John Pullokkaran On Oct. 21, 2014, 1:13 a.m., Sergey Shelukhin

Re: Review Request 25550: HIVE-8021 CBO: support CTAS and insert ... select

<https://reviews.apache.org/r/25550/#comment98573> Why not use //? - John Pullokkaran On Oct. 21, 2014, 1:13 a.m., Sergey Shelukhin wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 25550: HIVE-8021 CBO: support CTAS and insert ... select

<https://reviews.apache.org/r/25550/#comment98725> Wouldn't it be better to change this method to be verbose always. May be change the signature to boolean canHandleQuery(QB, topLevelQB, StringBuffer){ Use the implementation under verbose } - John

Re: Review Request 25550: HIVE-8021 CBO: support CTAS and insert ... select

<https://reviews.apache.org/r/25550/#comment98731> !isInTest is missing from topLevelQB && queryProperties.getJoinCount() <= 1 I know usually tests won't set that log level. - John Pullokkaran On Oct. 21, 2014, 1:13 a.m.,

Re: Review Request 25550: HIVE-8021 CBO: support CTAS and insert ... select

<https://reviews.apache.org/r/25550/#comment98732> This seems wrong; because of this CBO wouldn't get excersised in verbose mode. Am i missing something? - John Pullokkaran On Oct. 21, 2014, 1:13 a.m., Sergey Shel

Re: Review Request 25550: HIVE-8021 CBO: support CTAS and insert ... select

<https://reviews.apache.org/r/25550/#comment98729> Seems to be missing if ((!isInTest || conf.getVar(ConfVars.HIVEMAPREDMODE).equalsIgnoreCase("nonstrict")) - John Pullokkaran On Oct. 21, 2014, 1:13 a.m., Sergey

Re: Review Request 25550: HIVE-8021 CBO: support CTAS and insert ... select

<https://reviews.apache.org/r/25550/#comment98962> Seems not used - John Pullokkaran On Oct. 22, 2014, 8:34 p.m., Sergey Shelukhin wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 25550: HIVE-8021 CBO: support CTAS and insert ... select

ent98964> As pointed out last time, wouldn't this cause CBO to never run in Log level info. Caller code is msg = canHandleQuery(qb, true, LOG.isInfoEnabled()); runCBO = runCBO && (msg == null); - John Pullokkaran On Oct

Re: Review Request 25550: HIVE-8021 CBO: support CTAS and insert ... select

tedType && createVwDesc == null; .3 If PreCboCtx err msg is empty then check if CBO can handle Select Query rename canHandleQuery to canHandleSelectQuery - John Pullokkaran On Oct. 22, 2014, 8:34 p.m., Sergey Shelukhin wrote: > >

Re: Review Request 25550: HIVE-8021 CBO: support CTAS and insert ... select

CBO because the statement " + msg)); } } - John Pullokkaran On Oct. 22, 2014, 8:34 p.m., Sergey Shelukhin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 25550: HIVE-8021 CBO: support CTAS and insert ... select

itions); init(false); newAST = fixUpQueryForCTASInsert(cboCtx, newAST) - John Pullokkaran On Oct. 22, 2014, 8:34 p.m., Sergey Shelukhin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://

Re: Review Request 25550: HIVE-8021 CBO: support CTAS and insert ... select

t; This logging is not needed anymore right, since caller logs it. - John Pullokkaran On Oct. 23, 2014, 9:11 p.m., Sergey Shelukhin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 25550: HIVE-8021 CBO: support CTAS and insert ... select

tps://reviews.apache.org/r/25550/#comment99237> Why this change - John Pullokkaran On Oct. 23, 2014, 9:11 p.m., Sergey Shelukhin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 26721: HIVE-8433 CBO loses a column during AST conversion

/ASTConverter.java <https://reviews.apache.org/r/26721/#comment99274> This is unused. - John Pullokkaran On Oct. 22, 2014, 11:18 p.m., Sergey Shelukhin wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 26721: HIVE-8433 CBO loses a column during AST conversion

<https://reviews.apache.org/r/26721/#comment99297> ColumnInfo uses internal name; and "internalName"can not be different from name in ColumnInfo. - John Pullokkaran On Oct. 22, 2014, 11:18 p.m., Sergey Shelukhin wrote: > > ---

Re: Review Request 26721: HIVE-8433 CBO loses a column during AST conversion

<https://reviews.apache.org/r/26721/#comment99298> Can't we use Integer instead of this class? - John Pullokkaran On Oct. 22, 2014, 11:18 p.m., Sergey Shelukhin wrote: > > --- > This is an automatically generated e-m

Re: Review Request 26721: HIVE-8433 CBO loses a column during AST conversion

<https://reviews.apache.org/r/26721/#comment99299> Why #TODO in log message - John Pullokkaran On Oct. 22, 2014, 11:18 p.m., Sergey Shelukhin wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 25550: HIVE-8021 CBO: support CTAS and insert ... select

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25550/#review58363 --- Ship it! Ship It! - John Pullokkaran On Oct. 24, 2014, 8:35 p.m

Re: Review Request 26721: HIVE-8433 CBO loses a column during AST conversion

> On Oct. 24, 2014, 8:12 p.m., John Pullokkaran wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/RowResolver.java, line 346 > > <https://reviews.apache.org/r/26721/diff/4/?file=729400#file729400line346> > > > > Can't we use Integer instead of t

Re: Review Request 26721: HIVE-8433 CBO loses a column during AST conversion

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26721/#review58369 --- Ship it! Ship It! - John Pullokkaran On Oct. 22, 2014, 11:18

Re: Review Request 27065: Expose Hive optiq operator tree to be able to support other sql on hadoop query engines

<https://reviews.apache.org/r/27065/#comment100327> It would be better if you could subclass semantic Analyzer & move the logic there. - John Pullokkaran On Oct. 28, 2014, 6:10 p.m., Na Yang wrote: > > --- > This

Re: Review Request 24981: Handle unary op.

> On Aug. 22, 2014, 5:36 p.m., John Pullokkaran wrote: > > branches/cbo/ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/SqlFunctionConverter.java, > > line 125 > > <https://reviews.apache.org/r/24981/diff/1/?file=667267#file667267line125> > >

Re: Review Request 24981: Handle unary op.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24981/#review51315 --- Ship it! +1 - John Pullokkaran On Aug. 22, 2014, 3:16 p.m

Re: Timeline for release of Hive 0.14

We are working on Hive-5775 (Cost Based Optimizer), we hope to get this in to Hive 14. Thanks John On Thu, Aug 21, 2014 at 11:53 PM, Lefty Leverenz wrote: > Release 0.14 should include HIVE-6586 > (various fixes to > HiveConf.java parameters).

Re: Review Request 25038: implement NDV for partition colum

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25038/#review51549 --- Ship it! Ship It! - John Pullokkaran On Aug. 25, 2014, 9:11 p.m

Re: Review Request 25038: implement NDV for partition colum

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25038/#review51550 --- Ship it! Ship It! - John Pullokkaran On Aug. 25, 2014, 9:11 p.m

Re: Review Request 25313: Use Optiq's native FieldTrimmer instead of HiveRelFieldTrimmer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25313/#review52263 --- Ship it! Ship It! - John Pullokkaran On Sept. 3, 2014, 9:35 p.m

Re: Review Request 25179: HIVE-7905: CBO: more cost model changes

/HiveRelMdRowCount.java <https://reviews.apache.org/r/25179/#comment91104> Can't getRowCount(SemiJoinRel) combine with getRowCount(JoinRelBase) - John Pullokkaran On Sept. 3, 2014, 11:19 p.m., Harish Butani wrote: > > ---

Re: Review Request 25179: HIVE-7905: CBO: more cost model changes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25179/#review52523 --- Ship it! Ship It! - John Pullokkaran On Sept. 3, 2014, 11:19

Re: Review Request 25513: Handle repeated alias.

<https://reviews.apache.org/r/25513/#comment92177> Couldn't we introduce a unique alias in Select plan gen when duplicates are found. Then we wouldn't need to add duplicate entries. - John Pullokkaran On Sept. 10, 2014, 6:59 p.m., Ashuto

Re: Review Request 25541: Handle union type

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25541/#review53064 --- Ship it! Ship It! - John Pullokkaran On Sept. 11, 2014, 3:57

Re: Review Request 25558: [CBO] Handle tables with serde supplied schema

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25558/#review53115 --- Ship it! Ship It! - John Pullokkaran On Sept. 11, 2014, 9:16

Re: Review Request 25598: Handle parameterize type casting

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25598/#review53237 --- Ship it! Ship It! - John Pullokkaran On Sept. 12, 2014, 10:30

Re: Review Request 25605: [CBO] Bug in constant conversion for Date type

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25605/#review53255 --- Ship it! Ship It! - John Pullokkaran On Sept. 13, 2014, 12:23

Re: Review Request 25662: Queries without source table.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25662/#review53413 --- Ship it! Ship It! - John Pullokkaran On Sept. 15, 2014, 8:43

Re: Review Request 25675: Make casting of constants more type specific

> On Sept. 15, 2014, 11:27 p.m., John Pullokkaran wrote: > > Ship It! make sure cbo correctness passes - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25675/#re

Re: Review Request 25675: Make casting of constants more type specific

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25675/#review53437 --- Ship it! Ship It! - John Pullokkaran On Sept. 15, 2014, 11:16

Re: Review Request 25679: Let CBO handle field expression in join condition

> On Sept. 16, 2014, 5:16 a.m., John Pullokkaran wrote: > > Ship It! Conditional on CBO Correctness test pass - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25679/#re

Re: Review Request 25679: Let CBO handle field expression in join condition

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25679/#review53467 --- Ship it! Ship It! - John Pullokkaran On Sept. 16, 2014, 2:07

Re: Review Request 25700: HIVE-8080 CBO: function name may not match UDF name during translation

ve (w.r.t DB) How about built in functions like "toLower"? Could you say .toLower()? - John Pullokkaran On Sept. 16, 2014, 5:23 p.m., Sergey Shelukhin wrote: > > --- > This is an automatically generated e

Re: Review Request 25700: HIVE-8080 CBO: function name may not match UDF name during translation

> On Sept. 16, 2014, 5:30 p.m., John Pullokkaran wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java, line 646 > > <https://reviews.apache.org/r/25700/diff/1/?file=690720#file690720line646> > > > > are all functions qualified in hive (

Re: Review Request 25700: HIVE-8080 CBO: function name may not match UDF name during translation

> On Sept. 16, 2014, 5:30 p.m., John Pullokkaran wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java, line 646 > > <https://reviews.apache.org/r/25700/diff/1/?file=690720#file690720line646> > > > > are all functions qualified in hive (

Re: Review Request 25716: Type coercion for union queries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25716/#review53614 --- Ship it! Ship It! - John Pullokkaran On Sept. 16, 2014, 10:29

Re: Review Request 25700: HIVE-8080 CBO: function name may not match UDF name during translation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25700/#review53774 --- Ship it! Ship It! - John Pullokkaran On Sept. 16, 2014, 5:23

Re: Review Request 25700: HIVE-8080 CBO: function name may not match UDF name during translation

> On Sept. 17, 2014, 11:50 p.m., John Pullokkaran wrote: > > Ship It! Conditional on cbo correctness test pass - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25700/#re

Re: Review Request 25716: Type coercion for union queries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25716/#review53905 --- - John Pullokkaran On Sept. 18, 2014, 11:11 p.m., Ashutosh

Re: Review Request 25716: Type coercion for union queries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25716/#review53907 --- - John Pullokkaran On Sept. 18, 2014, 11:11 p.m., Ashutosh

Re: Review Request 25716: Type coercion for union queries.

> On Sept. 19, 2014, 12:19 a.m., John Pullokkaran wrote: > > Union RR already has translated type; why not use them instead of translating from Optiq type back. - John --- This is an automatically generated e-mail. To rep

Re: Review Request 25716: Type coercion for union queries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25716/#review53979 --- Ship it! Ship It! - John Pullokkaran On Sept. 19, 2014, 5:55

Re: Review Request 25754: HIVE-8111 CBO trunk merge: duplicated casts for arithmetic expressions in Hive and CBO

/GenericUDFBaseNumeric.java <https://reviews.apache.org/r/25754/#comment93860> Avoid CBO name in function. Its a generic function current consumer is CBO. - John Pullokkaran On Sept. 17, 2014, 9:25 p.m., Sergey Shelukhin wrote: > > ---

Re: Review Request 25754: HIVE-8111 CBO trunk merge: duplicated casts for arithmetic expressions in Hive and CBO

/GenericUDFBaseNumeric.java <https://reviews.apache.org/r/25754/#comment93862> Instead of these changes why don't you use FunctionRegistry.getTypeInfoForPrimitiveCategory(a,b) - John Pullokkaran On Sept. 17, 2014, 9:25 p.m., Sergey Shel

Re: Review Request 25856: [CBO] Handle case where top level schema contains repeated alias

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25856/#review54051 --- Ship it! Ship It! - John Pullokkaran On Sept. 19, 2014, 11:05

Re: Review Request 25754: HIVE-8111 CBO trunk merge: duplicated casts for arithmetic expressions in Hive and CBO

/RexNodeConverter.java <https://reviews.apache.org/r/25754/#comment94010> Since DecimalUtility would give you widest type possible for numeric comparisons your tgtDT would always be func return type. am i wrong? - John Pullokkaran On Sept. 19, 2014, 9:50 p.m., Sergey Shelukhin

Re: Review Request 25754: HIVE-8111 CBO trunk merge: duplicated casts for arithmetic expressions in Hive and CBO

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25754/#review54185 --- Ship it! Ship It! - John Pullokkaran On Sept. 19, 2014, 9:50

Re: Review Request 25869: HIVE-8199 CBO Trunk Merge: quote2 test fails due to incorrect literal translation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25869/#review54186 --- Ship it! Ship It! - John Pullokkaran On Sept. 20, 2014, 12:57

Re: Review Request 25956: [CBO] Preserve subquery alias while generating ast

(DB.tblName, Table Alias). - John Pullokkaran On Sept. 23, 2014, 9:41 p.m., Ashutosh Chauhan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Re: Review Request 24595: Invoke cbo only when needed

ess of whether it has Join or not. - John Pullokkaran On Aug. 12, 2014, 7:08 a.m., Ashutosh Chauhan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https

Re: Review Request 24981: Handle unary op.

t;)); registerFunction("--", SqlStdOperatorTable.UNARY_MINUS, hToken(HiveParser.PLUS, "MINUS")); - John Pullokkaran On Aug. 22, 2014, 3:16 p.m., Ashutosh Chauhan wrote: > > --- > This is an automatically generated

Re: Review Request 27401: HIVE-8636 CBO: split cbo_correctness test

tps://reviews.apache.org/r/27401/#comment100556> Why don't we put all CBO subqueries in to a single test? - John Pullokkaran On Oct. 30, 2014, 11:18 p.m., Sergey Shelukhin wrote: > > --- > This is an automatically genera

Re: Review Request 23351: Support direct fetch for lateral views, sub queries, etc.

/SimpleFetchOptimizer.java <https://reviews.apache.org/r/23351/#comment100951> Can't we use ParseContext.topToTable to get to "Table" given a TS object instead of walking the QB tree? - John Pullokkaran On July 9, 2014, 6:55

Re: Review Request 27713: CBO: enable groupBy index

could cause correctness problems for select. - John Pullokkaran On Nov. 14, 2014, 4:42 a.m., pengcheng xiong wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 27713: CBO: enable groupBy index

, (case a is null then 1 else a) as b from r1)r2 group by a; - John Pullokkaran On Dec. 1, 2014, 6:57 p.m., pengcheng xiong wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 28510: HIVE-8974

/reloperators/HiveAggregate.java <https://reviews.apache.org/r/28510/#comment105717> Why can't we reuse HiveAggregateRel? - John Pullokkaran On Nov. 27, 2014, 2:37 p.m., Jesús Camacho Rodríguez wrote: > > --- > This is an aut

Re: Review Request 27713: CBO: enable groupBy index

/RewriteCanApplyCtx.java <https://reviews.apache.org/r/27713/#comment105900> Remove empty spaces - John Pullokkaran On Dec. 2, 2014, 11:18 p.m., pengcheng xiong wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 27713: CBO: enable groupBy index

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27713/#review63710 --- Ship it! Ship It! - John Pullokkaran On Dec. 2, 2014, 11:18 p.m

Re: Review Request 27713: CBO: enable groupBy index

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27713/#review63711 --- Ship it! - John Pullokkaran On Dec. 2, 2014, 11:18 p.m

Re: Review Request 28510: HIVE-8974

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28510/#review64061 --- Ship it! Ship It! - John Pullokkaran On Dec. 3, 2014, 12:45 a.m

Re: Review Request 28941: HIVE-8988

<https://reviews.apache.org/r/28941/#comment109047> Does Hive support grouping function in the schema? If so we would need to change the GB output schema to accomodate this, right? - John Pullokkaran On Dec. 18, 2014, 11:07 p.m., Jesús Camacho Rodríguez

Re: Review Request 28941: HIVE-8988

<https://reviews.apache.org/r/28941/#comment109048> Also does Hive support concatenated grouping ids? - John Pullokkaran On Dec. 18, 2014, 11:07 p.m., Jesús Camacho Rodríguez wrote: > > --- > This is an automatically g

Re: Review Request 28797: Support Union Distinct

tps://reviews.apache.org/r/28797/#comment109053> Could we add KW_UNION -> TOK_UNIONDISTINCT i.e treat "union" as "union distinct" - John Pullokkaran On Dec. 19, 2014, 6:28 p.m., pengcheng xiong wrote: > > -

Re: Review Request 28797: Support Union Distinct

tps://reviews.apache.org/r/28797/#comment109054> Shouldn't the opcode distinguish between ALL/DISTINCT? - John Pullokkaran On Dec. 19, 2014, 6:28 p.m., pengcheng xiong wrote: > > --- > This is an automatically genera

Re: Review Request 28797: Support Union Distinct

tps://reviews.apache.org/r/28797/#comment109055> Why don't we make it a boolean for ALL/Distinct? - John Pullokkaran On Dec. 19, 2014, 6:28 p.m., pengcheng xiong wrote: > > --- > This is an automatically generated e-m

Re: Review Request 28797: Support Union Distinct

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28797/#review65815 --- - John Pullokkaran On Dec. 19, 2014, 6:28 p.m., pengcheng xiong

Re: Review Request 28797: Support Union Distinct

gt; https://reviews.apache.org/r/28797/ > --- > > (Updated Dec. 19, 2014, 6:28 p.m.) > > > Review request for hive and John Pullokkaran. > > > Repository: hive-git > > > Description > --- > > Current version (Hive 0.14) does not support union (or union dist

Re: Review Request 28941: HIVE-8988

<https://reviews.apache.org/r/28941/#comment109259> In Calcite what cols are present between "gbExprNDescLst.size()" to "gbExprNDescLst.size() * 2" ? we seems to be skipping that - John Pullokkaran On Dec. 18, 2014, 11:07 p.m., Jes

Re: Review Request 28941: HIVE-8988

/ASTConverter.java <https://reviews.apache.org/r/28941/#comment109270> It seems cube, rollup would be inlined as grouping set. In AST path this could make a really long tree. Couldn't we instead translate it as cube/rollup? - John Pullokkaran On Dec. 18, 2014, 11:07 p.m., Je

Re: Review Request 28941: HIVE-8988

> On Dec. 22, 2014, 7:15 p.m., John Pullokkaran wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java, line > > 13457 > > <https://reviews.apache.org/r/28941/diff/6/?file=796676#file796676line13457> > > > > Also does Hive suppor

Re: Review Request 29439: UnionProcessor misses results for multi-insert when hive.optimize.union.remove=true

tion to say if childe operators >1 it must be multi table insert. 2) Can't this be done just for union? - John Pullokkaran On Dec. 26, 2014, 10:46 p.m., pengcheng xiong wrote: > > --- > This is an automatically ge

Re: Review Request 29611: Add ProjectRemove rule on CBO path

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29611/#review66930 --- Ship it! Ship It! - John Pullokkaran On Jan. 6, 2015, 12:50 a.m

Re: Review Request 28941: HIVE-8988

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28941/#review67050 --- Ship it! Ship It! - John Pullokkaran On Jan. 5, 2015, 3:47 p.m

Re: Review Request 28941: HIVE-8988

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28941/#review67049 --- Ship it! Ship It! - John Pullokkaran On Jan. 5, 2015, 3:47 p.m

Re: Review Request 29439: UnionProcessor misses results for multi-insert when hive.optimize.union.remove=true

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29439/#review67052 --- Ship it! Ship It! - John Pullokkaran On Jan. 7, 2015, 2:12 a.m

Re: Review Request 29671: Support select distinct *

<https://reviews.apache.org/r/29671/#comment111596> Why do we need Select here since all you are looking for is column names to build ast, can't you get that from srcRel. - John Pullokkaran On Jan. 7, 2015, 9:16 p.m., pengcheng

Re: Review Request 29671: Support select distinct *

<https://reviews.apache.org/r/29671/#comment111597> Fix spacing - John Pullokkaran On Jan. 7, 2015, 9:16 p.m., pengcheng xiong wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 29671: Support select distinct *

<https://reviews.apache.org/r/29671/#comment111598> Fix Spacing - John Pullokkaran On Jan. 7, 2015, 9:16 p.m., pengcheng xiong wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 29671: Support select distinct *

<https://reviews.apache.org/r/29671/#comment111599> You can get RR from relToHiveRR map; i don't think you need this aditional arg. - John Pullokkaran On Jan. 7, 2015, 9:16 p.m., pengcheng xiong wrote: > > ---

  1   2   3   4   5   6   7   8   9   10   >