----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27713/#review62315 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteCanApplyProcFactory.java <https://reviews.apache.org/r/27713/#comment104339> ExprNodeDescUtils.backtrack seems like would pass functions as long as their arguments can be back tracked (i.e they are keys). This might work for filter (assuming their rewrite includes filter). This could cause correctness problems for select. - John Pullokkaran On Nov. 14, 2014, 4:42 a.m., pengcheng xiong wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27713/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2014, 4:42 a.m.) > > > Review request for hive and Sergey Shelukhin. > > > Repository: hive-git > > > Description > ------- > > Right now, even when groupby index is build, CBO is not able to use it. In > this patch, we are trying to make it use groupby index that we build. The > basic problem is that > for SEL1-SEL2-GRY-...-SEL3, > the previous version only modify SEL2, which immediately precedes GRY. > Now, with CBO, we have lots of SELs, e.g., SEL1. > So, the solution is to modify all of them. > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteCanApplyProcFactory.java > 02216de > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteGBUsingIndex.java > 0f06ec9 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteQueryUsingAggregateIndex.java > 74614f3 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteQueryUsingAggregateIndexCtx.java > d699308 > > Diff: https://reviews.apache.org/r/27713/diff/ > > > Testing > ------- > > > Thanks, > > pengcheng xiong > >
