Re: Review Request 69663: HIVE-16976

> On Jan. 11, 2019, 6:07 p.m., Jesús Camacho Rodríguez wrote: > > ql/src/java/org/apache/hadoop/hive/ql/ppd/SyntheticJoinPredicate.java > > Lines 35 (patched) > > > > > > This is not needed? Yes. That is correct. I w

Re: Review Request 69663: HIVE-16976

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69663/#review211896 --- ql/src/java/org/apache/hadoop/hive/ql/ppd/SyntheticJoinPredicate.

Re: Review Request 69663: HIVE-16976

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69663/ --- (Updated Jan. 9, 2019, 5:50 p.m.) Review request for hive, Ashutosh Chauhan, Go

Re: Review Request 69663: HIVE-16976

> On Jan. 7, 2019, 4:41 p.m., Jesús Camacho Rodríguez wrote: > > ql/src/java/org/apache/hadoop/hive/ql/ppd/SyntheticJoinPredicate.java > > Lines 330 (patched) > > > > > > Should we still return null if function text

Re: Review Request 69663: HIVE-16976

> On Jan. 7, 2019, 4:41 p.m., Jesús Camacho Rodríguez wrote: > > ql/src/java/org/apache/hadoop/hive/ql/ppd/SyntheticJoinPredicate.java > > Lines 284 (patched) > > > > > > We should add a call to extended version here

Re: Review Request 69663: HIVE-16976

> On Jan. 7, 2019, 4:41 p.m., Jesús Camacho Rodríguez wrote: > > ql/src/java/org/apache/hadoop/hive/ql/ppd/SyntheticJoinPredicate.java > > Lines 330 (patched) > > > > > > Should we still return null if function text

Re: Review Request 69663: HIVE-16976

> On Jan. 7, 2019, 10:40 p.m., Jesús Camacho Rodríguez wrote: > > ql/src/java/org/apache/hadoop/hive/ql/ppd/SyntheticJoinPredicate.java > > Lines 254 (patched) > > > > > > srcPos and targetPos do not seem to refer to

Re: Review Request 69663: HIVE-16976

> On Jan. 7, 2019, 10:40 p.m., Jesús Camacho Rodríguez wrote: > > ql/src/java/org/apache/hadoop/hive/ql/ppd/SyntheticJoinPredicate.java > > Lines 254 (patched) > > > > > > srcPos and targetPos do not seem to refer to

Re: Review Request 69663: HIVE-16976

> On Jan. 7, 2019, 4:41 p.m., Jesús Camacho Rodríguez wrote: > > ql/src/java/org/apache/hadoop/hive/ql/ppd/SyntheticJoinPredicate.java > > Lines 330 (patched) > > > > > > Should we still return null if function text

Re: Review Request 69663: HIVE-16976

> On Jan. 7, 2019, 4:41 p.m., Jesús Camacho Rodríguez wrote: > > ql/src/java/org/apache/hadoop/hive/ql/ppd/SyntheticJoinPredicate.java > > Line 182 (original) > > > > > > Can you bring this back and delete 'if (sourc

Re: Review Request 69663: HIVE-16976

> On Jan. 7, 2019, 4:41 p.m., Jesús Camacho Rodríguez wrote: > > ql/src/java/org/apache/hadoop/hive/ql/ppd/SyntheticJoinPredicate.java > > Line 182 (original) > > > > > > Can you bring this back and delete 'if (sourc

Re: Review Request 69663: HIVE-16976

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69663/#review211745 --- ql/src/java/org/apache/hadoop/hive/ql/ppd/SyntheticJoinPredicate.

Re: Review Request 69663: HIVE-16976

> On Jan. 7, 2019, 4:41 p.m., Jesús Camacho Rodríguez wrote: > > Can we add some tests for the new feature? The reason there is no test yet is because it does nothing end to end. Both DPP route and semijoin reduction route dont process the predicate yet. > On Jan. 7, 2019, 4:41 p.m., Jesús Ca

Re: Review Request 69663: HIVE-16976

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69663/#review211725 --- Can we add some tests for the new feature? ql/src/java/org/apach

Review Request 69663: HIVE-16976

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69663/ --- Review request for hive, Ashutosh Chauhan, Gopal V, Jesús Camacho Rodríguez, and