Re: Review Request 59697: Fix HiveFilterAggregateTransposeRule when filter is always false

2017-06-03 Thread pengcheng xiong
> On June 1, 2017, 9:08 p.m., pengcheng xiong wrote: > > ql/src/test/results/clientpositive/perf/query4.q.out > > Lines 436 (patched) > > > > > > The pattern TS-FIL(false) is here. I will take another look to see why

Re: Review Request 59697: Fix HiveFilterAggregateTransposeRule when filter is always false

2017-06-03 Thread Ashutosh Chauhan
> On June 1, 2017, 9:08 p.m., pengcheng xiong wrote: > > ql/src/test/results/clientpositive/perf/query4.q.out > > Lines 436 (patched) > > > > > > The pattern TS-FIL(false) is here. I will take another look to see why

Re: Review Request 59697: Fix HiveFilterAggregateTransposeRule when filter is always false

2017-06-02 Thread Jesús Camacho Rodríguez
> On June 1, 2017, 9:08 p.m., pengcheng xiong wrote: > > ql/src/test/results/clientpositive/perf/query4.q.out > > Lines 436 (patched) > > > > > > The pattern TS-FIL(false) is here. I will take another look to see why

Re: Review Request 59697: Fix HiveFilterAggregateTransposeRule when filter is always false

2017-06-01 Thread pengcheng xiong
> On June 1, 2017, 9:08 p.m., pengcheng xiong wrote: > > ql/src/test/results/clientpositive/perf/query4.q.out > > Lines 436 (patched) > > > > > > The pattern TS-FIL(false) is here. I will take another look to see why

Re: Review Request 59697: Fix HiveFilterAggregateTransposeRule when filter is always false

2017-06-01 Thread pengcheng xiong
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59697/#review176665 --- ql/src/test/results/clientpositive/perf/query4.q.out Lines 436 (p

Re: Review Request 59697: Fix HiveFilterAggregateTransposeRule when filter is always false

2017-06-01 Thread Ashutosh Chauhan
> On June 1, 2017, 9 p.m., pengcheng xiong wrote: > > ql/src/test/results/clientpositive/filter_aggr.q.out > > Lines 266 (patched) > > > > > > This shows null scan optimization is in. yup.. but it doesnt show up for

Re: Review Request 59697: Fix HiveFilterAggregateTransposeRule when filter is always false

2017-06-01 Thread pengcheng xiong
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59697/#review176661 --- ql/src/test/results/clientpositive/filter_aggr.q.out Lines 266 (p

Re: Review Request 59697: Fix HiveFilterAggregateTransposeRule when filter is always false

2017-06-01 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59697/#review176656 --- I tested latest and previous patch. On both cases, nullscan optimi

Re: Review Request 59697: Fix HiveFilterAggregateTransposeRule when filter is always false

2017-06-01 Thread pengcheng xiong
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59697/ --- (Updated June 1, 2017, 7:46 p.m.) Review request for hive and Ashutosh Chauhan.

Review Request 59697: Fix HiveFilterAggregateTransposeRule when filter is always false

2017-05-31 Thread pengcheng xiong
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59697/ --- Review request for hive and Ashutosh Chauhan. Repository: hive-git Descriptio