> On June 1, 2017, 9 p.m., pengcheng xiong wrote: > > ql/src/test/results/clientpositive/filter_aggr.q.out > > Lines 266 (patched) > > <https://reviews.apache.org/r/59697/diff/2/?file=1738885#file1738885line266> > > > > This shows null scan optimization is in.
yup.. but it doesnt show up for tpcds query 74 and query 4. I ran those with user.explain=false and explain extended to test. - Ashutosh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59697/#review176661 ----------------------------------------------------------- On June 1, 2017, 7:46 p.m., pengcheng xiong wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59697/ > ----------------------------------------------------------- > > (Updated June 1, 2017, 7:46 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Repository: hive-git > > > Description > ------- > > hive-16775 > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveFilterAggregateTransposeRule.java > 0e5c7313b6 > ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 7f583ed075 > ql/src/test/queries/clientpositive/filter_aggr.q PRE-CREATION > ql/src/test/queries/clientpositive/perf/query4.q PRE-CREATION > ql/src/test/queries/clientpositive/perf/query74.q PRE-CREATION > ql/src/test/results/clientpositive/filter_aggr.q.out PRE-CREATION > ql/src/test/results/clientpositive/perf/query4.q.out PRE-CREATION > ql/src/test/results/clientpositive/perf/query74.q.out PRE-CREATION > > > Diff: https://reviews.apache.org/r/59697/diff/2/ > > > Testing > ------- > > > Thanks, > > pengcheng xiong > >
