Re: Review Request 53328: Support for standard ROLLUP syntax

2016-11-04 Thread Vineet Garg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53328/ --- (Updated Nov. 4, 2016, 9:07 p.m.) Review request for hive and Jesús Camacho Rod

Re: Review Request 53328: Support for standard ROLLUP syntax

2016-11-03 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53328/#review154773 --- Ship it! Ship It! - Jesús Camacho Rodríguez On Nov. 3, 2016,

Re: Review Request 53328: Support for standard ROLLUP syntax

2016-11-03 Thread Vineet Garg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53328/ --- (Updated Nov. 3, 2016, 5:18 p.m.) Review request for hive and Jesús Camacho Rod

Re: Review Request 53328: Support for standard ROLLUP syntax

2016-11-03 Thread Vineet Garg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53328/ --- (Updated Nov. 3, 2016, 5:16 p.m.) Review request for hive and Jesús Camacho Rod

Re: Review Request 53328: Support for standard ROLLUP syntax

2016-11-03 Thread Vineet Garg
> On Nov. 1, 2016, 12:07 a.m., Jesús Camacho Rodríguez wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g, line 60 > > > > > > Since sets is not used in that syntax, maybe it is easier to creat

Re: Review Request 53328: Support for standard ROLLUP syntax

2016-10-31 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53328/#review154349 --- ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g (

Review Request 53328: Support for standard ROLLUP syntax

2016-10-31 Thread Vineet Garg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53328/ --- Review request for hive and Jesús Camacho Rodríguez. Repository: hive-git Des