----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53328/#review154773 -----------------------------------------------------------
Ship it! Ship It! - Jesús Camacho Rodríguez On Nov. 3, 2016, 5:18 p.m., Vineet Garg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53328/ > ----------------------------------------------------------- > > (Updated Nov. 3, 2016, 5:18 p.m.) > > > Review request for hive and Jesús Camacho Rodríguez. > > > Bugs: HIVE-15119 > https://issues.apache.org/jira/browse/HIVE-15119 > > > Repository: hive-git > > > Description > ------- > > Standard ROLLUP and CUBE syntax is GROUP BY ROLLUP/CUBE (expression list)... > but HIVE allows GROUP BY <expression list> WITH ROLLUP/CUBE syntax. We would > like HIVE to support standard ROLLUP/CUBE syntax to allow out of the box > support for TPCDS queries i.e. without rewritting them. > > This patach includes update to grammar to allow ROLLUP and CUBE in following > syntax: > > SELECT.....GROUP BY ROLLUP ( expr1, expr2....) > SELECT.....GROUP BY CUBE (expr1, expr2..) > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g 13e2d17 > ql/src/test/queries/clientpositive/annotate_stats_groupby.q 854e401 > ql/src/test/queries/clientpositive/cbo_rp_annotate_stats_groupby.q 3159fc7 > ql/src/test/queries/clientpositive/cte_1.q 2956339 > ql/src/test/queries/clientpositive/groupby_cube1.q bfa13ee > ql/src/test/queries/clientpositive/groupby_cube_multi_gby.q 80022bb > ql/src/test/queries/clientpositive/groupby_grouping_id1.q de4a7c3 > ql/src/test/queries/clientpositive/groupby_grouping_id2.q 5c05aad > ql/src/test/queries/clientpositive/groupby_grouping_sets1.q 804dfb3 > ql/src/test/queries/clientpositive/groupby_grouping_sets2.q 824942c > ql/src/test/queries/clientpositive/groupby_grouping_sets3.q 7077377 > ql/src/test/queries/clientpositive/groupby_grouping_sets4.q 06e5e1a > ql/src/test/queries/clientpositive/groupby_grouping_sets5.q 6a09c88 > ql/src/test/queries/clientpositive/groupby_rollup1.q 23cac80 > ql/src/test/queries/clientpositive/infer_bucket_sort_grouping_operators.q > 928f6fb > ql/src/test/queries/clientpositive/limit_pushdown2.q 637b5b0 > ql/src/test/queries/clientpositive/vector_grouping_sets.q 09ba6b6 > ql/src/test/results/clientpositive/annotate_stats_groupby.q.out f6971a0 > ql/src/test/results/clientpositive/cbo_rp_annotate_stats_groupby.q.out > f5b4375 > ql/src/test/results/clientpositive/cte_1.q.out 61fd1af > ql/src/test/results/clientpositive/groupby_cube1.q.out b9cfeb2 > ql/src/test/results/clientpositive/groupby_cube_multi_gby.q.out 992fd2d > ql/src/test/results/clientpositive/groupby_grouping_id1.q.out 136edeb > ql/src/test/results/clientpositive/groupby_grouping_sets1.q.out 5b70906 > ql/src/test/results/clientpositive/groupby_grouping_sets2.q.out f00bb5b > ql/src/test/results/clientpositive/groupby_grouping_sets3.q.out 5c69907 > ql/src/test/results/clientpositive/groupby_grouping_sets4.q.out b7e9329 > ql/src/test/results/clientpositive/groupby_grouping_sets5.q.out f175778 > ql/src/test/results/clientpositive/groupby_rollup1.q.out 54e1a0d > > ql/src/test/results/clientpositive/infer_bucket_sort_grouping_operators.q.out > ebfce60 > ql/src/test/results/clientpositive/limit_pushdown2.q.out 2f68674 > ql/src/test/results/clientpositive/llap/cte_1.q.out e309ce8 > ql/src/test/results/clientpositive/llap/groupby_grouping_id2.q.out 544a7ae > ql/src/test/results/clientpositive/llap/vector_grouping_sets.q.out 8e55ce3 > ql/src/test/results/clientpositive/vector_grouping_sets.q.out 4207c19 > > Diff: https://reviews.apache.org/r/53328/diff/ > > > Testing > ------- > > Updated exsting tests to use new ROLLUP and CUBE syntax in addition to > non-standard syntax. > > > Thanks, > > Vineet Garg > >
