Re: Review Request 50787: Add a timezone-aware timestamp

2017-05-09 Thread Rui Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50787/ --- (Updated May 10, 2017, 4:19 a.m.) Review request for hive, Ashutosh Chauhan, pe

Re: Review Request 50787: Add a timezone-aware timestamp

2017-05-09 Thread Rui Li
> On May 9, 2017, 11:05 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/TypeConverter.java > > Lines 204 (patched) > > > > > > Can you file a bug in Calcite that i

Re: Review Request 50787: Add a timezone-aware timestamp

2017-05-09 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50787/#review174383 --- common/src/java/org/apache/hadoop/hive/common/type/TimestampTZ.ja

Re: Review Request 50787: Add a timezone-aware timestamp

2017-05-08 Thread pengcheng xiong
> On May 3, 2017, 9:57 p.m., pengcheng xiong wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g > > Lines 132 (patched) > > > > > > I think Identifier["timestamptz"] and Identifier["zone"] may be > >

Re: Review Request 50787: Add a timezone-aware timestamp

2017-05-08 Thread Xuefu Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50787/#review174202 --- Ship it! Ship It! - Xuefu Zhang On May 8, 2017, 3:17 p.m., R

Re: Review Request 50787: Add a timezone-aware timestamp

2017-05-08 Thread Rui Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50787/ --- (Updated May 8, 2017, 3:17 p.m.) Review request for hive, pengcheng xiong and X

Re: Review Request 50787: Add a timezone-aware timestamp

2017-05-07 Thread Rui Li
> On May 7, 2017, 11:22 p.m., Xuefu Zhang wrote: > > common/src/java/org/apache/hadoop/hive/common/type/TimestampTZ.java > > Lines 138 (patched) > > > > > > Not sure if I understand this, but why cannot we get second

Re: Review Request 50787: Add a timezone-aware timestamp

2017-05-07 Thread Xuefu Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50787/#review174136 --- common/src/java/org/apache/hadoop/hive/common/type/TimestampTZ.ja

Re: Review Request 50787: Add a timezone-aware timestamp

2017-05-03 Thread Rui Li
> On May 3, 2017, 9:57 p.m., pengcheng xiong wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g > > Lines 132 (patched) > > > > > > I think Identifier["timestamptz"] and Identifier["zone"] may be > >

Re: Review Request 50787: Add a timezone-aware timestamp

2017-05-03 Thread pengcheng xiong
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50787/#review173833 --- ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g Lines 132

Re: Review Request 50787: Add a timezone-aware timestamp

2017-05-02 Thread Rui Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50787/ --- (Updated May 3, 2017, 6:34 a.m.) Review request for hive. Bugs: HIVE-14412

Re: Review Request 50787: Add a timezone-aware timestamp

2017-04-26 Thread Rui Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50787/ --- (Updated April 27, 2017, 2:32 a.m.) Review request for hive. Bugs: HIVE-14412

Re: Review Request 50787: Add a timezone-aware timestamp

2016-09-23 Thread Rui Li
> On Sept. 22, 2016, 11:20 a.m., Jason Dere wrote: > > - How about compatbility with the various date functions > > (year()/month()/day()/etc)? For most of the functions, TIMESTAMPTZ is implicitly converted to text. Therefore I think we can get correct results. I added some special handle in

Re: Review Request 50787: Add a timezone-aware timestamp

2016-09-23 Thread Rui Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50787/ --- (Updated Sept. 23, 2016, 8:58 a.m.) Review request for hive. Bugs: HIVE-14412

Re: Review Request 50787: Add a timezone-aware timestamp

2016-09-22 Thread Jason Dere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50787/#review149983 --- - How about compatbility with the various date functions (year()/

Re: Review Request 50787: Add a timezone-aware timestamp

2016-09-21 Thread Xuefu Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50787/#review149942 --- Ship it! Ship It! - Xuefu Zhang On Sept. 22, 2016, 4:05 a.m.

Re: Review Request 50787: Add a timezone-aware timestamp

2016-09-21 Thread Rui Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50787/ --- (Updated Sept. 22, 2016, 4:05 a.m.) Review request for hive. Bugs: HIVE-14412

Re: Review Request 50787: Add a timezone-aware timestamp

2016-09-21 Thread Xuefu Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50787/#review149940 --- ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDF.java

Re: Review Request 50787: Add a timezone-aware timestamp

2016-09-21 Thread Rui Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50787/ --- (Updated Sept. 22, 2016, 1:08 a.m.) Review request for hive. Bugs: HIVE-14412

Re: Review Request 50787: Add a timezone-aware timestamp

2016-09-11 Thread Rui Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50787/ --- (Updated Sept. 12, 2016, 3:06 a.m.) Review request for hive. Bugs: HIVE-14412

Review Request 50787: Add a timezone-aware timestamp

2016-08-04 Thread Rui Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50787/ --- Review request for hive. Bugs: HIVE-14412 https://issues.apache.org/jira/br