-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50787/
-----------------------------------------------------------
(Updated Sept. 12, 2016, 3:06 a.m.)
Review request for hive.
Bugs: HIVE-14412
https://issues.apache.org/jira/browse/HIVE-14412
Repository: hive-git
Description
-------
The 1st patch to add timezone-aware timestamp.
Diffs (updated)
-----
common/src/test/org/apache/hadoop/hive/common/type/TestHiveTimestamp.java
PRE-CREATION
jdbc/src/java/org/apache/hive/jdbc/HiveBaseResultSet.java 93f093f
jdbc/src/java/org/apache/hive/jdbc/JdbcColumn.java 38918f0
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 60646ba
ql/src/java/org/apache/hadoop/hive/ql/exec/GroupByOperator.java f28d33e
ql/src/java/org/apache/hadoop/hive/ql/exec/SerializationUtilities.java
7be628e
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/TypeConverter.java
ba41518
ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 9329e00
ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 7ceb005
ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g df596ff
ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 82080eb
ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java a718264
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToBoolean.java 17b892c
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToByte.java efae82d
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToDouble.java 9cbc114
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToFloat.java 5808c90
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToInteger.java a7551cb
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToLong.java c961d14
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToShort.java 570408a
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToString.java 5cacd59
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDF.java 259fde8
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToTimestampTZ.java
PRE-CREATION
ql/src/test/queries/clientpositive/timestamptz.q PRE-CREATION
ql/src/test/queries/clientpositive/timestamptz_1.q PRE-CREATION
ql/src/test/queries/clientpositive/timestamptz_2.q PRE-CREATION
ql/src/test/results/clientnegative/invalid_cast_from_binary_1.q.out acecbae
ql/src/test/results/clientnegative/invalid_cast_from_binary_2.q.out 41e1c80
ql/src/test/results/clientnegative/invalid_cast_from_binary_3.q.out 23e3403
ql/src/test/results/clientnegative/invalid_cast_from_binary_4.q.out 3541ef6
ql/src/test/results/clientnegative/invalid_cast_from_binary_5.q.out 177039c
ql/src/test/results/clientnegative/invalid_cast_from_binary_6.q.out 668380f
ql/src/test/results/clientnegative/wrong_column_type.q.out 6ff90ea
ql/src/test/results/clientpositive/timestamptz.q.out PRE-CREATION
ql/src/test/results/clientpositive/timestamptz_1.q.out PRE-CREATION
ql/src/test/results/clientpositive/timestamptz_2.q.out PRE-CREATION
serde/if/serde.thrift 6caad36
serde/src/gen/thrift/gen-cpp/serde_constants.h a5f33fb
serde/src/gen/thrift/gen-cpp/serde_constants.cpp 3a675bf
serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/serdeConstants.java
04ed8f5
serde/src/gen/thrift/gen-php/org/apache/hadoop/hive/serde/Types.php 18c3991
serde/src/gen/thrift/gen-py/org_apache_hadoop_hive_serde/constants.py fafdc24
serde/src/gen/thrift/gen-rb/serde_constants.rb 0ce9f27
serde/src/java/org/apache/hadoop/hive/serde2/SerDeUtils.java 6e08dfd
serde/src/java/org/apache/hadoop/hive/serde2/binarysortable/BinarySortableSerDe.java
5e119d7
serde/src/java/org/apache/hadoop/hive/serde2/binarysortable/fast/BinarySortableDeserializeRead.java
0cbc8d0
serde/src/java/org/apache/hadoop/hive/serde2/io/HiveTimestampWritable.java
PRE-CREATION
serde/src/java/org/apache/hadoop/hive/serde2/io/TimestampWritable.java
bbccc7f
serde/src/java/org/apache/hadoop/hive/serde2/io/TimestampWritableBase.java
PRE-CREATION
serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java 23dbe6a
serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyHiveTimestamp.java
PRE-CREATION
serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyTimestamp.java 56945d1
serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyUtils.java 73c72e1
serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyHiveTimestampObjectInspector.java
PRE-CREATION
serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyPrimitiveObjectInspectorFactory.java
5601734
serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryFactory.java
52f3527
serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryHiveTimestamp.java
PRE-CREATION
serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinarySerDe.java
54bfd2d
serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryUtils.java
f8a110d
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorConverters.java
24b3d4e
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java
1ac72c6
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/PrimitiveObjectInspector.java
70633f3
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/HiveTimestampObjectorInspector.java
PRE-CREATION
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaHiveTimestampObjectInspector.java
PRE-CREATION
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaTimestampObjectInspector.java
509189e
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorConverter.java
e08ad43
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorFactory.java
2ed0843
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorUtils.java
51b529e
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/SettableHiveTimestampObjectInspector.java
PRE-CREATION
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantHiveTimestampObjectInspector.java
PRE-CREATION
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableHiveTimestampObjectInspector.java
PRE-CREATION
serde/src/java/org/apache/hadoop/hive/serde2/thrift/Type.java 0ad8c02
serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoFactory.java
43c4819
serde/src/test/org/apache/hadoop/hive/serde2/io/TestTimestampWritable.java
3c483cc
service-rpc/if/TCLIService.thrift a4fa7b0
service-rpc/src/gen/thrift/gen-cpp/TCLIService_constants.cpp 991cb2e
service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.h b249544
service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.cpp 2f460e8
service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TCLIServiceConstants.java
930bed7
service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TProtocolVersion.java
bce2a0c
service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TTypeId.java
a3735eb
service-rpc/src/gen/thrift/gen-php/Types.php 786c773
service-rpc/src/gen/thrift/gen-py/TCLIService/constants.py c8d4f8f
service-rpc/src/gen/thrift/gen-py/TCLIService/ttypes.py fdf6b1f
service-rpc/src/gen/thrift/gen-rb/t_c_l_i_service_constants.rb 25adbb4
service-rpc/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb 4b1854c
service/src/java/org/apache/hive/service/cli/ColumnValue.java 76e8c03
service/src/java/org/apache/hive/service/cli/TypeDescriptor.java d634bef
storage-api/src/java/org/apache/hadoop/hive/common/type/HiveTimestamp.java
PRE-CREATION
storage-api/src/java/org/apache/hadoop/hive/ql/util/JavaDataModel.java
4a745e4
storage-api/src/java/org/apache/hadoop/hive/ql/util/TimestampUtils.java
41db9ca
Diff: https://reviews.apache.org/r/50787/diff/
Testing
-------
Thanks,
Rui Li
