Re: Review Request 36897: HIVE-11257

2015-07-29 Thread pengcheng xiong
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36897/#review93519 --- Ship it! Ship It! - pengcheng xiong On July 29, 2015, 7:09 p.m.,

Re: Review Request 36897: HIVE-11257

2015-07-29 Thread Jesús Camacho Rodríguez
> On July 29, 2015, 8:29 p.m., pengcheng xiong wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinToMultiJoinRule.java, > > line 294 > > > > > > One final issue: this should also be get

Re: Review Request 36897: HIVE-11257

2015-07-29 Thread pengcheng xiong
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36897/#review93507 --- ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJ

Re: Review Request 36897: HIVE-11257

2015-07-29 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36897/ --- (Updated July 29, 2015, 7:09 p.m.) Review request for hive and pengcheng xiong.

Re: Review Request 36897: HIVE-11257

2015-07-29 Thread pengcheng xiong
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36897/#review93498 --- ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJ

Re: Review Request 36897: HIVE-11257

2015-07-29 Thread Jesús Camacho Rodríguez
> On July 29, 2015, 6:07 p.m., pengcheng xiong wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinToMultiJoinRule.java, > > line 295 > > > > > > please apply the Hive code format templa

Re: Review Request 36897: HIVE-11257

2015-07-29 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36897/#review93495 --- ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJ

Re: Review Request 36897: HIVE-11257

2015-07-29 Thread Jesús Camacho Rodríguez
> On July 29, 2015, 6:07 p.m., pengcheng xiong wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinToMultiJoinRule.java, > > line 289 > > > > > > Please correct me if I am wrong: I doubt

Re: Review Request 36897: HIVE-11257

2015-07-29 Thread pengcheng xiong
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36897/#review93486 --- ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJ

Re: Review Request 36897: HIVE-11257

2015-07-29 Thread Jesús Camacho Rodríguez
> On July 28, 2015, 10:44 p.m., pengcheng xiong wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinToMultiJoinRule.java, > > line 250 > > > > > > Please correct me if my understanding i

Re: Review Request 36897: HIVE-11257

2015-07-29 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36897/ --- (Updated July 29, 2015, 11:58 a.m.) Review request for hive and pengcheng xiong

Re: Review Request 36897: HIVE-11257

2015-07-28 Thread pengcheng xiong
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36897/#review93363 --- ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJ

Review Request 36897: HIVE-11257

2015-07-28 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36897/ --- Review request for hive and pengcheng xiong. Bugs: HIVE-11257 https://issue