----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36897/#review93363 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinToMultiJoinRule.java (line 249) <https://reviews.apache.org/r/36897/#comment147734> Please correct me if my understanding is wrong: it seems that systemFieldList and childSystemFieldList may be removed from the input of function isCombinablePredicate because they are neither meaningfully used nor changed inside the function. A better way is to pass join, left, condition and otherCondition and then just use constructJoinPredicateInfo(join, condition); and constructJoinPredicateInfo(left, otherCondition); ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinToMultiJoinRule.java (line 265) <https://reviews.apache.org/r/36897/#comment147735> Previous version is using equals to compare, and now it is changed to containsAll. Can you add some comments explaining why childKey.containsAll(keys) is the correct and sufficient condition for combining predicates? - pengcheng xiong On July 28, 2015, 10:21 p.m., Jesús Camacho Rodríguez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36897/ > ----------------------------------------------------------- > > (Updated July 28, 2015, 10:21 p.m.) > > > Review request for hive and pengcheng xiong. > > > Bugs: HIVE-11257 > https://issues.apache.org/jira/browse/HIVE-11257 > > > Repository: hive-git > > > Description > ------- > > CBO: Calcite Operator To Hive Operator (Calcite Return Path): Method > isCombinablePredicate in HiveJoinToMultiJoinRule should be extended to > support MultiJoin operators merge > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinToMultiJoinRule.java > d0a29a76652c8af120a6efb252c75282730ef097 > > Diff: https://reviews.apache.org/r/36897/diff/ > > > Testing > ------- > > > Thanks, > > Jesús Camacho Rodríguez > >
