Re: Review Request 32809: Disallow create table with dot/colon in column name

> On April 7, 2015, 4:45 a.m., Swarnim Kulkarni wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g, line 635 > > > > > > This and the following line can be simplified as > > > > return input.

Re: Review Request 32809: Disallow create table with dot/colon in column name

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32809/#review79229 --- Ship it! Ship It! - John Pullokkaran On April 7, 2015, 6:18 p.m.

Re: Review Request 32809: Disallow create table with dot/colon in column name

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32809/ --- (Updated April 7, 2015, 6:18 p.m.) Review request for hive, Ashutosh Chauhan an

Re: Review Request 32809: Disallow create table with dot/colon in column name

> On April 7, 2015, 4:45 a.m., Swarnim Kulkarni wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g, line 632 > > > > > > If you choose to use a String.contains, this could as well be a > > character a

Re: Review Request 32809: Disallow create table with dot/colon in column name

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32809/#review79203 --- ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g

Re: Review Request 32809: Disallow create table with dot/colon in column name

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32809/#review79121 --- ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g

Review Request 32809: Disallow create table with dot/colon in column name

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32809/ --- Review request for hive, Ashutosh Chauhan and John Pullokkaran. Repository: hiv