----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32809/#review79121 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g <https://reviews.apache.org/r/32809/#comment128237> If you choose to use a String.contains, this could as well be a character array. ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g <https://reviews.apache.org/r/32809/#comment128236> Why not simply use string.contains here? ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g <https://reviews.apache.org/r/32809/#comment128234> This and the following line can be simplified as return input.indexOf(c); ql/src/test/org/apache/hadoop/hive/ql/parse/TestUnpermittedCharsInColumnNameCreateTableNegative.java <https://reviews.apache.org/r/32809/#comment128235> Nit: Complete the comment. - Swarnim Kulkarni On April 3, 2015, 6:24 a.m., pengcheng xiong wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32809/ > ----------------------------------------------------------- > > (Updated April 3, 2015, 6:24 a.m.) > > > Review request for hive, Ashutosh Chauhan and John Pullokkaran. > > > Repository: hive-git > > > Description > ------- > > Since we don't allow users to query column names with dot in the middle such > as emp.no, don't allow users to create tables with such columns that cannot > be queried. Fix the documentation to reflect this fix. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 2e583da > > ql/src/test/org/apache/hadoop/hive/ql/parse/TestUnpermittedCharsInColumnNameCreateTableNegative.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/32809/diff/ > > > Testing > ------- > > > Thanks, > > pengcheng xiong > >
