Re: Review Request 32370: HIVE-10040

2015-04-07 Thread John Pullokkaran
> On April 7, 2015, 8:38 p.m., John Pullokkaran wrote: > > Ship It! Remaining review comment will be addressed in HIVE-10243. - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32370/#rev

Re: Review Request 32370: HIVE-10040

2015-04-07 Thread John Pullokkaran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32370/#review79253 --- Ship it! Ship It! - John Pullokkaran On April 7, 2015, 7:18 p.m.

Re: Review Request 32370: HIVE-10040

2015-04-07 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32370/ --- (Updated April 7, 2015, 7:18 p.m.) Review request for hive and John Pullokkaran

Re: Review Request 32370: HIVE-10040

2015-04-07 Thread John Pullokkaran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32370/#review79235 --- ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/cost/HiveCo

Re: Review Request 32370: HIVE-10040

2015-04-07 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32370/ --- (Updated April 7, 2015, 7:12 p.m.) Review request for hive and John Pullokkaran

Re: Review Request 32370: HIVE-10040

2015-04-07 Thread John Pullokkaran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32370/#review79228 --- ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/cost/HiveCo

Re: Review Request 32370: HIVE-10040

2015-04-06 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32370/ --- (Updated April 6, 2015, 9:30 p.m.) Review request for hive and John Pullokkaran

Re: Review Request 32370: HIVE-10040

2015-04-06 Thread John Pullokkaran
> On March 31, 2015, 3:20 p.m., Jesús Camacho Rodríguez wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/cost/HiveDefaultCostModel.java, > > line 54 > > > > > > We could do that, but I don't feel stro

Re: Review Request 32370: HIVE-10040

2015-04-06 Thread Jesús Camacho Rodríguez
> On March 30, 2015, 11:48 p.m., John Pullokkaran wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/cost/HiveDefaultCostModel.java, > > line 54 > > > > > > Can't we walk through the algorithms and comp

Re: Review Request 32370: HIVE-10040

2015-03-31 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32370/#review78367 --- ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/cost/HiveDe

Re: Review Request 32370: HIVE-10040

2015-03-30 Thread John Pullokkaran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32370/#review78284 --- ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/cost/HiveDe

Re: Review Request 32370: HIVE-10040

2015-03-27 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32370/ --- (Updated March 27, 2015, 4:15 p.m.) Review request for hive and John Pullokkara

Re: Review Request 32370: HIVE-10040

2015-03-27 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32370/ --- (Updated March 27, 2015, 4:12 p.m.) Review request for hive and John Pullokkara

Re: Review Request 32370: HIVE-10040

2015-03-27 Thread Jesús Camacho Rodríguez
> On March 25, 2015, 8:51 p.m., John Pullokkaran wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/cost/HiveDefaultCostModel.java, > > line 42 > > > > > > How about modifying this t0: > > 1. Get J

Re: Review Request 32370: HIVE-10040

2015-03-25 Thread John Pullokkaran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32370/#review77792 --- ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/cost/HiveDe

Review Request 32370: HIVE-10040

2015-03-21 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32370/ --- Review request for hive and John Pullokkaran. Bugs: HIVE-10040 https://issu