----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32370/#review78367 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/cost/HiveDefaultCostModel.java <https://reviews.apache.org/r/32370/#comment126929> We could do that, but I don't feel strongly about architecting it that way, as we would be mixing two different cost models into the same method: one based on cardinality, and one based on CPU+IO+cardinality. Thus, the cost coming from that method for "NONE" and any other algorithm e.g. "COMMON" should not be even comparable, right? - Jesús Camacho Rodríguez On March 27, 2015, 4:15 p.m., Jesús Camacho Rodríguez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32370/ > ----------------------------------------------------------- > > (Updated March 27, 2015, 4:15 p.m.) > > > Review request for hive and John Pullokkaran. > > > Bugs: HIVE-10040 > https://issues.apache.org/jira/browse/HIVE-10040 > > > Repository: hive-git > > > Description > ------- > > CBO (Calcite Return Path): Pluggable cost modules [CBO branch] > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveDefaultRelMetadataProvider.java > 977313a5a632329fc963daf7ff276ccdd59ce7c5 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/cost/HiveCost.java > 41604cd0af68e7f90296fa271c42debc5aaf743a > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/cost/HiveCostModel.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/cost/HiveDefaultCostModel.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/cost/HiveOnTezCostModel.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/cost/HiveRelMdCost.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveAggregate.java > 9a8a5da81b92c7c1f33d1af8072b1fb94e237290 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveFilter.java > 3e45a3fbed3265b126a3ff9b6ffe44bee24453ef > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveJoin.java > e2b010b641d48ea1bf04750ddf5eb24fb3a7fcbe > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveLimit.java > 5fc64f3e8c97fc8988bc35be39dbabf78dd7de24 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveProject.java > 6c215c96190f0fcebe063b15c2763c49ebf1faaf > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveTableScan.java > f2c5408d913bfe2648c4e1e1e43b1bbc5f43a549 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdCollation.java > 4984683c3c8c6c0378a22e21fd6d961f3901f25c > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdDistribution.java > f846dd19899af51194f3407ef913fcb9bcc24977 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdRowCount.java > dabbe280278dc80f00f0240a0c615fe6c7b8533a > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdUniqueKeys.java > 95515b23e409d73d5c61e107931727add3f992a6 > > Diff: https://reviews.apache.org/r/32370/diff/ > > > Testing > ------- > > > Thanks, > > Jesús Camacho Rodríguez > >
