Re: Review Request 28283: HIVE-8900:Create encryption testing framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28283/#review64638 --- Ship it! Looks good Ferdinand. - Sergio Pena On Dic. 10, 2014, 2

Re: Review Request 28283: HIVE-8900:Create encryption testing framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28283/ --- (Updated Dec. 10, 2014, 2:21 a.m.) Review request for hive. Changes ---

Re: Review Request 28283: HIVE-8900:Create encryption testing framework

> On Dec. 5, 2014, 8:17 p.m., Brock Noland wrote: > > Hi, > > > > This looks really good! I am very happy with the way this worked out! I > > have a few comments, some of which are nits and one or two "real" issues we > > need to adress. Thank you so much! Thanks for your review. Update the p

Re: Review Request 28283: HIVE-8900:Create encryption testing framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28283/#review64067 --- Hi, This looks really good! I am very happy with the way this worke

Re: Review Request 28283: HIVE-8900:Create encryption testing framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28283/#review63681 --- Ship it! Ship It! - Sergio Pena On Dic. 3, 2014, 1:02 a.m., chen

Re: Review Request 28283: HIVE-8900:Create encryption testing framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28283/ --- (Updated Dec. 3, 2014, 1:02 a.m.) Review request for hive. Repository: hive-g

Re: Review Request 28283: HIVE-8900:Create encryption testing framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28283/#review63571 --- itests/qtest/pom.xml

Re: Review Request 28283: HIVE-8900:Create encryption testing framework

> On Dic. 1, 2014, 9:35 p.m., Sergio Pena wrote: > > itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java, line 268 > > > > > > Do we need to set this value? For what I know, AES/CTR/NoPadding is the > >

Re: Review Request 28283: HIVE-8900:Create encryption testing framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28283/ --- (Updated Dec. 2, 2014, 2:58 a.m.) Review request for hive. Changes --- s

Re: Review Request 28283: HIVE-8900:Create encryption testing framework

> On Dec. 1, 2014, 9:35 p.m., Sergio Pena wrote: > > Thanks for your review. Please see my inline comments. > On Dec. 1, 2014, 9:35 p.m., Sergio Pena wrote: > > itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java, line 268 > >

Re: Review Request 28283: HIVE-8900:Create encryption testing framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28283/#review63437 --- itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java

Re: Review Request 28283: HIVE-8900:Create encryption testing framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28283/ --- (Updated Nov. 28, 2014, 1:45 a.m.) Review request for hive. Changes ---

Re: Review Request 28283: HIVE-8900:Create encryption testing framework

> On Nov. 21, 2014, 8:25 p.m., Brock Noland wrote: > > Hi Ferdindand, > > > > I think at the end of this JIRA we only want one q-file tests enabled. The > > other sub-tasks of HIVE-8065 are for enabling tests. I also think that as > > part of this test we'll need to startup a MiniDFS instance.

Re: Review Request 28283: HIVE-8900:Create encryption testing framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28283/#review62626 --- Hi Ferdindand, I think at the end of this JIRA we only want one q-f

Re: Review Request 28283: HIVE-8900:Create encryption testing framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28283/ --- (Updated Nov. 21, 2014, 2:30 a.m.) Review request for hive. Changes ---

Re: Review Request 28283: HIVE-8900:Create encryption testing framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28283/#review62361 --- data/conf/encrypted/hive-site.xml

Review Request 28283: HIVE-8900:Create encryption testing framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28283/ --- Review request for hive. Repository: hive-git Description --- The patch