-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28283/#review62361
-----------------------------------------------------------



data/conf/encrypted/hive-site.xml
<https://reviews.apache.org/r/28283/#comment104410>

    Just to confirm the value of this variable. This value is the directory 
name for the staging dir that will be created like this:
    
    i.e (value '.stagindir')
    /user/hive/warehouse/table/.stagingdir
    
    The value is not an absolute path to where the temporary files will be 
stored, but relative to the table location.



itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java
<https://reviews.apache.org/r/28283/#comment104411>

    This API (as weel as DFSConfigKeys) does not exist on older versions of 
hadoop (<= 2.6.0). We should make QTestUtil compatible with older versions.
    
    Should we use a hadoop shim for this?



itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java
<https://reviews.apache.org/r/28283/#comment104412>

    Should we use hadoop shims to get the key provider? Just to make QTestUtil 
compatible with older versions of hadoop.


- Sergio Pena


On Nov. 20, 2014, 2:19 p.m., cheng xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28283/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2014, 2:19 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> The patch includes:
> 1. enable security properties for hive security cluster
> 
> 
> Diffs
> -----
> 
>   data/conf/encrypted/hive-site.xml PRE-CREATION 
>   itests/qtest/pom.xml 376f4a9 
>   itests/src/test/resources/testconfiguration.properties 3ae001d 
>   itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java 31d5c29 
>   shims/0.20S/src/main/java/org/apache/hadoop/hive/shims/Hadoop20SShims.java 
> 2e00d93 
>   shims/0.23/src/main/java/org/apache/hadoop/hive/shims/Hadoop23Shims.java 
> 8161fc1 
> 
> Diff: https://reviews.apache.org/r/28283/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> cheng xu
> 
>

Reply via email to