Re: Review Request 25178: Add DROP TABLE PURGE

2014-09-10 Thread Xuefu Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25178/#review52911 --- metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.j

Re: Review Request 25178: Add DROP TABLE PURGE

2014-09-10 Thread Lefty Leverenz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25178/#review52834 --- ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java

Re: Review Request 25178: Add DROP TABLE PURGE

2014-09-09 Thread david seraf
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25178/ --- (Updated Sept. 9, 2014, 6:51 p.m.) Review request for hive and Xuefu Zhang. C

Re: Review Request 25178: Add DROP TABLE PURGE

2014-09-08 Thread david seraf
> On Sept. 4, 2014, 9:39 p.m., Mithun Radhakrishnan wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java, > > line 1409 > > > > > > Shouldn't you be passing the environment context here?

Re: Review Request 25178: Add DROP TABLE PURGE

2014-09-04 Thread Mithun Radhakrishnan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25178/#review52353 --- metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.j

Re: Review Request 25178: Add DROP TABLE PURGE

2014-09-04 Thread david seraf
> On Sept. 4, 2014, 4:57 a.m., Lefty Leverenz wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java, > > line 822 > > > > > > You could add an explanation for UnsupportedOperationEx

Re: Review Request 25178: Add DROP TABLE PURGE

2014-09-03 Thread Lefty Leverenz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25178/#review52279 --- Javadoc changes look good. Just one optional quibble. metastore/s

Re: Review Request 25178: Add DROP TABLE PURGE

2014-09-02 Thread david seraf
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25178/ --- (Updated Sept. 2, 2014, 11:41 p.m.) Review request for hive and Xuefu Zhang.

Re: Review Request 25178: Add DROP TABLE PURGE

2014-09-02 Thread Lefty Leverenz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25178/#review52099 --- Let me be your first reviewer (just looking at Javadoc comments).

Re: Review Request 25178: Add DROP TABLE PURGE

2014-09-02 Thread david seraf
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25178/ --- (Updated Sept. 2, 2014, 9:12 p.m.) Review request for hive and Xuefu Zhang. C

Re: Review Request 25178: Add DROP TABLE PURGE

2014-09-02 Thread david seraf
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25178/ --- (Updated Sept. 2, 2014, 9:11 p.m.) Review request for hive and Xuefu Zhang. R