----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25178/#review52099 -----------------------------------------------------------
Let me be your first reviewer (just looking at Javadoc comments). metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java <https://reviews.apache.org/r/25178/#comment90841> Javadoc comment needs a first-line description and param ignoreUnknownTab. Javadoc exceptions should include UnsupportedOperationException and omit ExistingDependentsException. metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java <https://reviews.apache.org/r/25178/#comment90840> Javadoc comment missing 2 params: deleteData, ignoreUknownTab. Also, ignoreUknownTab is a typo for ignoreUnknownTab. Javadoc comment has ExistingDependentsException, which I don't see in the method. - Lefty Leverenz On Sept. 2, 2014, 9:12 p.m., david seraf wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25178/ > ----------------------------------------------------------- > > (Updated Sept. 2, 2014, 9:12 p.m.) > > > Review request for hive and Xuefu Zhang. > > > Repository: hive-git > > > Description > ------- > > Add PURGE option to DROP TABLE command to skip saving table data to the trash > > > Diffs > ----- > > > hcatalog/core/src/test/java/org/apache/hive/hcatalog/mapreduce/TestHCatPartitionPublish.java > be7134f > > hcatalog/webhcat/svr/src/test/java/org/apache/hive/hcatalog/templeton/tool/TestTempletonUtils.java > af952f2 > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/miniHS2/TestHiveServer2.java > da51a55 > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 84ef5f9 > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java > 237166e > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreFsImpl.java > cff0718 > metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java > 143d1c7 > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreFS.java > a141793 > metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java 613b709 > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java cd017d8 > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 6f225f3 > > ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java > 4cf98d8 > ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java > f31a409 > ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 32db0c7 > ql/src/java/org/apache/hadoop/hive/ql/plan/DropTableDesc.java ba30e1f > ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHive.java 406aae9 > ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHiveRemote.java 1a5ba87 > ql/src/test/queries/clientpositive/drop_table_purge.q PRE-CREATION > ql/src/test/results/clientpositive/drop_table_purge.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/25178/diff/ > > > Testing > ------- > > added code test and added QL test. Tests passed in CI, but other, unrelated > tests failed. > > > Thanks, > > david seraf > >
