Re: Review Request 17422: Add https support to HiveServer2 http mode

2014-01-28 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17422/#review33075 --- Ship it! Ship It! - Thejas Nair On Jan. 28, 2014, 10:20 p.m., Va

Re: Review Request 17422: Add https support to HiveServer2 http mode

2014-01-28 Thread Vaibhav Gumashta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17422/ --- (Updated Jan. 28, 2014, 10:20 p.m.) Review request for hive, Prasad Mujumdar an

Re: Review Request 17422: Add https support to HiveServer2 http mode

2014-01-28 Thread Vaibhav Gumashta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17422/ --- (Updated Jan. 28, 2014, 9:55 p.m.) Review request for hive, Prasad Mujumdar and

Re: Review Request 17422: Add https support to HiveServer2 http mode

2014-01-28 Thread Vaibhav Gumashta
> On Jan. 28, 2014, 9:10 p.m., Thejas Nair wrote: > > jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java, line 201 > > > > > > If user has specified "https" in url, should we honor that, and switch > > to ssl ? Th

Re: Review Request 17422: Add https support to HiveServer2 http mode

2014-01-28 Thread Vaibhav Gumashta
> On Jan. 28, 2014, 9:10 p.m., Thejas Nair wrote: > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/miniHS2/MiniHS2.java, > > line 81 > > > > > > do we need this sleep ? If we can avoid this 2 secs of sleep per t

Re: Review Request 17422: Add https support to HiveServer2 http mode

2014-01-28 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17422/#review33034 --- itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestSSL.java

Re: Review Request 17422: Add https support to HiveServer2 http mode

2014-01-27 Thread Vaibhav Gumashta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17422/ --- (Updated Jan. 28, 2014, 12:37 a.m.) Review request for hive, Prasad Mujumdar an

Re: Review Request 17422: Add https support to HiveServer2 http mode

2014-01-27 Thread Vaibhav Gumashta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17422/ --- (Updated Jan. 28, 2014, 12:34 a.m.) Review request for hive, Prasad Mujumdar an

Re: Review Request 17422: Add https support to HiveServer2 http mode

2014-01-27 Thread Vaibhav Gumashta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17422/ --- (Updated Jan. 28, 2014, 12:23 a.m.) Review request for hive, Prasad Mujumdar an

Review Request 17422: Add https support to HiveServer2 http mode

2014-01-27 Thread Vaibhav Gumashta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17422/ --- Review request for hive and Thejas Nair. Bugs: HIVE-5826 https://issues.apa