> On Jan. 28, 2014, 9:10 p.m., Thejas Nair wrote: > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/miniHS2/MiniHS2.java, > > line 81 > > <https://reviews.apache.org/r/17422/diff/3/?file=452299#file452299line81> > > > > do we need this sleep ? If we can avoid this 2 secs of sleep per test > > (with miniHS2.stop()), that would be great. Doesn't the HS2.stop block on > > completion ?
I think you are right. Will remove it. > On Jan. 28, 2014, 9:10 p.m., Thejas Nair wrote: > > jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java, line 102 > > <https://reviews.apache.org/r/17422/diff/3/?file=452302#file452302line102> > > > > instead of a TODO comment, you can probably just say the format that is > > supported/not supported, see HIVE-6286 Sure, will do. > On Jan. 28, 2014, 9:10 p.m., Thejas Nair wrote: > > jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java, line 195 > > <https://reviews.apache.org/r/17422/diff/3/?file=452302#file452302line195> > > > > i think boolean instead of Boolean is better here. It is simpler, as > > you don't have to think if the value can be NULL in other parts of the code > > where it is passed around. > > > > Cool, will do. > On Jan. 28, 2014, 9:10 p.m., Thejas Nair wrote: > > jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java, line 201 > > <https://reviews.apache.org/r/17422/diff/3/?file=452302#file452302line201> > > > > If user has specified "https" in url, should we honor that, and switch > > to ssl ? That seems like a good intuitive experience. Actually the way it is setup is that in the query string, the user specifies the mode as http/binary and specifies whether she wants to use ssl or not. For example: jdbc:hive2://server:10001/db;user=foo;password=bar?hive.server2.transport.mode=http;hive.server2.thrift.http.path=cliservice;ssl=true;sslTrustStore=myTrustStorePath;trustStorePassword=myTrustStorePassword. So the client here sets up the uri which it is using to contact the server as https or http based on whether ssl is true or not. Are you suggesting we add another https mode? > On Jan. 28, 2014, 9:10 p.m., Thejas Nair wrote: > > service/pom.xml, line 70 > > <https://reviews.apache.org/r/17422/diff/3/?file=452304#file452304line70> > > > > what is the reason for change in library? 6.x one was quite old. I was trying to upgrade to the latest 9.x but thought it would better to keep it in sync with the webhcat one, since it will make it better to upgrade in both places whenever we plan to do that. - Vaibhav ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17422/#review33034 ----------------------------------------------------------- On Jan. 28, 2014, 12:37 a.m., Vaibhav Gumashta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17422/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2014, 12:37 a.m.) > > > Review request for hive, Prasad Mujumdar and Thejas Nair. > > > Bugs: HIVE-5826 > https://issues.apache.org/jira/browse/HIVE-5826 > > > Repository: hive-git > > > Description > ------- > > Here: https://issues.apache.org/jira/browse/HIVE-5826 > > > Diffs > ----- > > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniHS2.java > b271d65 > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestSSL.java d0c4fc2 > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/miniHS2/AbstarctHiveService.java > 5ecd156 > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/miniHS2/AbstractHiveService.java > PRE-CREATION > itests/hive-unit/src/test/java/org/apache/hive/jdbc/miniHS2/MiniHS2.java > a65e678 > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/miniHS2/TestHiveServer2.java > 910de9b > > itests/hive-unit/src/test/java/org/apache/hive/service/cli/thrift/TestThriftHttpCLIService.java > 65177dd > jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java aabb5cb > pom.xml 41f5337 > service/pom.xml dff3174 > service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java > b5a6138 > > service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpCLIService.java > e487a7f > service/src/java/org/apache/hive/service/server/HiveServer2.java fa13783 > > Diff: https://reviews.apache.org/r/17422/diff/ > > > Testing > ------- > > New tests added to TestSSL, some refactoring of MiniHS2 as well. > > > Thanks, > > Vaibhav Gumashta > >
