Re: Review Request 16146: HIVE-5993: JDBC Driver should not hard-code the database name

2013-12-11 Thread Prasad Mujumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16146/#review30246 --- Ship it! Thanks for addressing the feedback. Looks fine to me. - P

Re: Review Request 16146: HIVE-5993: JDBC Driver should not hard-code the database name

2013-12-11 Thread Szehon Ho
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16146/ --- (Updated Dec. 11, 2013, 10:33 p.m.) Review request for hive and Prasad Mujumdar

Re: Review Request 16146: HIVE-5993: JDBC Driver should not hard-code the database name

2013-12-11 Thread Prasad Mujumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16146/#review30215 --- The patch look fine. It would be better to avoid duplicating the cod

Review Request 16146: HIVE-5993: JDBC Driver should not hard-code the database name

2013-12-09 Thread Szehon Ho
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16146/ --- Review request for hive and Prasad Mujumdar. Bugs: HIVE-5993 https://issues