----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16146/#review30215 -----------------------------------------------------------
The patch look fine. It would be better to avoid duplicating the code to call GetInfo(). jdbc/src/java/org/apache/hive/jdbc/HiveDatabaseMetaData.java <https://reviews.apache.org/r/16146/#comment57827> I think it would be better to add a helper method to call GetInfo() with given InfoType. We'll endup duplicating this code in multiple places. - Prasad Mujumdar On Dec. 10, 2013, 12:54 a.m., Szehon Ho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16146/ > ----------------------------------------------------------- > > (Updated Dec. 10, 2013, 12:54 a.m.) > > > Review request for hive and Prasad Mujumdar. > > > Bugs: HIVE-5993 > https://issues.apache.org/jira/browse/HIVE-5993 > > > Repository: hive-git > > > Description > ------- > > Method HiveDatabaseMetadata.getDatabaseProductName() returns a hard-coded > string "Hive". > > This should instead call the existing Hive-server2 api to return the db name. > Incidentally, the server returns "Apache Hive". > > > Diffs > ----- > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java > 1ba8ad3 > jdbc/src/java/org/apache/hive/jdbc/HiveDatabaseMetaData.java 5087ded > > Diff: https://reviews.apache.org/r/16146/diff/ > > > Testing > ------- > > Ran TestJdbcDriver2. > > > Thanks, > > Szehon Ho > >
