Re: Review Request 14486: HIVE-5441: Async query execution doesn't return resultset status

2013-11-08 Thread Prasad Mujumdar
> On Nov. 8, 2013, 12:22 a.m., Thejas Nair wrote: > > ql/src/java/org/apache/hadoop/hive/ql/Driver.java, line 979 > > > > > > OK, I see what you mean. I was looking at just the commented line, and > > didn't look at t

Re: Review Request 14486: HIVE-5441: Async query execution doesn't return resultset status

2013-11-07 Thread Brock Noland
> On Nov. 8, 2013, 12:22 a.m., Thejas Nair wrote: > > ql/src/java/org/apache/hadoop/hive/ql/Driver.java, line 979 > > > > > > OK, I see what you mean. I was looking at just the commented line, and > > didn't look at t

Re: Review Request 14486: HIVE-5441: Async query execution doesn't return resultset status

2013-11-07 Thread Brock Noland
> On Nov. 8, 2013, 12:22 a.m., Thejas Nair wrote: > > ql/src/java/org/apache/hadoop/hive/ql/Driver.java, line 979 > > > > > > OK, I see what you mean. I was looking at just the commented line, and > > didn't look at t

Re: Review Request 14486: HIVE-5441: Async query execution doesn't return resultset status

2013-11-07 Thread Brock Noland
> On Nov. 7, 2013, 4:31 p.m., Brock Noland wrote: > > ql/src/java/org/apache/hadoop/hive/ql/Driver.java, line 979 > > > > > > Question: what happens if compile throws an exception, like NPE or > > something. Does that

Re: Review Request 14486: HIVE-5441: Async query execution doesn't return resultset status

2013-11-07 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14486/#review28467 --- ql/src/java/org/apache/hadoop/hive/ql/Driver.java

Re: Review Request 14486: HIVE-5441: Async query execution doesn't return resultset status

2013-11-07 Thread Thejas Nair
> On Nov. 7, 2013, 4:31 p.m., Brock Noland wrote: > > ql/src/java/org/apache/hadoop/hive/ql/Driver.java, line 979 > > > > > > Question: what happens if compile throws an exception, like NPE or > > something. Does that

Re: Review Request 14486: HIVE-5441: Async query execution doesn't return resultset status

2013-11-07 Thread Brock Noland
> On Nov. 7, 2013, 4:31 p.m., Brock Noland wrote: > > ql/src/java/org/apache/hadoop/hive/ql/Driver.java, line 979 > > > > > > Question: what happens if compile throws an exception, like NPE or > > something. Does that

Re: Review Request 14486: HIVE-5441: Async query execution doesn't return resultset status

2013-11-07 Thread Thejas Nair
> On Nov. 7, 2013, 4:31 p.m., Brock Noland wrote: > > ql/src/java/org/apache/hadoop/hive/ql/Driver.java, line 979 > > > > > > Question: what happens if compile throws an exception, like NPE or > > something. Does that

Re: Review Request 14486: HIVE-5441: Async query execution doesn't return resultset status

2013-11-07 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14486/#review28448 --- Ship it! Ship It! - Thejas Nair On Nov. 6, 2013, 11:50 p.m., Pra

Re: Review Request 14486: HIVE-5441: Async query execution doesn't return resultset status

2013-11-07 Thread Brock Noland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14486/#review28376 --- +1 from my side though we should wait to see if Carl or Thejas have

Re: Review Request 14486: HIVE-5441: Async query execution doesn't return resultset status

2013-11-06 Thread Prasad Mujumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14486/ --- (Updated Nov. 6, 2013, 11:50 p.m.) Review request for hive. Changes ---

Re: Review Request 14486: HIVE-5441: Async query execution doesn't return resultset status

2013-11-06 Thread Prasad Mujumdar
> On Oct. 25, 2013, 11:05 p.m., Thejas Nair wrote: > > service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java, > > line 137 > > > > > > This should change to "Error compiling query" > > Done - Pra

Re: Review Request 14486: HIVE-5441: Async query execution doesn't return resultset status

2013-11-06 Thread Prasad Mujumdar
> On Oct. 25, 2013, 7 p.m., Carl Steinbach wrote: > > ql/src/java/org/apache/hadoop/hive/ql/Driver.java, line 962 > > > > > > Please remove. Done - Prasad --

Re: Review Request 14486: HIVE-5441: Async query execution doesn't return resultset status

2013-10-25 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14486/#review27504 --- service/src/java/org/apache/hive/service/cli/operation/SQLOperation

Re: Review Request 14486: HIVE-5441: Async query execution doesn't return resultset status

2013-10-25 Thread Carl Steinbach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14486/#review27543 --- ql/src/java/org/apache/hadoop/hive/ql/Driver.java

Re: Review Request 14486: HIVE-5441: Async query execution doesn't return resultset status

2013-10-07 Thread Prasad Mujumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14486/ --- (Updated Oct. 7, 2013, 6:51 p.m.) Review request for hive. Changes --- U

Re: Review Request 14486: HIVE-5441: Async query execution doesn't return resultset status

2013-10-07 Thread Prasad Mujumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14486/ --- (Updated Oct. 7, 2013, 6:50 p.m.) Review request for hive. Changes --- U

Re: Review Request 14486: HIVE-5441: Async query execution doesn't return resultset status

2013-10-04 Thread Prasad Mujumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14486/ --- (Updated Oct. 4, 2013, 8:19 a.m.) Review request for hive. Bugs: HIVE-5441

Re: Review Request 14486: HIVE-5441: Async query execution doesn't return resultset status

2013-10-04 Thread Prasad Mujumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14486/ --- (Updated Oct. 4, 2013, 8:18 a.m.) Review request for hive. Changes --- T

Review Request 14486: HIVE-5441: Async query execution doesn't return resultset status

2013-10-04 Thread Prasad Mujumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14486/ --- Review request for hive. Bugs: HIVE-5441 https://issues.apache.org/jira/bro