> On Nov. 8, 2013, 12:22 a.m., Thejas Nair wrote: > > ql/src/java/org/apache/hadoop/hive/ql/Driver.java, line 979 > > <https://reviews.apache.org/r/14486/diff/4/?file=380248#file380248line979> > > > > OK, I see what you mean. I was looking at just the commented line, and > > didn't look at the full view-diff page. Yes, the releaseLocks won't get > > called. That looks like a problem. > > > > Thanks to Vaibhav to pointing it out to me. > > Brock Noland wrote: > OK, thanks for responding. I'll open a jira. > > Brock Noland wrote: > https://issues.apache.org/jira/browse/HIVE-5781
I guess the lock are acquired a bit later, just before the execution. We can actually get rid of that releaseLocks() in case of compiler error. - Prasad ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14486/#review28467 ----------------------------------------------------------- On Nov. 6, 2013, 11:50 p.m., Prasad Mujumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14486/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2013, 11:50 p.m.) > > > Review request for hive. > > > Bugs: HIVE-5441 > https://issues.apache.org/jira/browse/HIVE-5441 > > > Repository: hive-git > > > Description > ------- > > Separate out the query compilation and execute that part synchronously. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/Driver.java c09ffde > service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java > 4ee1b74 > service/src/test/org/apache/hive/service/cli/CLIServiceTest.java cd9d99a > > Diff: https://reviews.apache.org/r/14486/diff/ > > > Testing > ------- > > Added test cases > > > Thanks, > > Prasad Mujumdar > >
