Re: Review Request 68744: Add Surrogate Keys function to Hive

> On Sept. 18, 2018, 10:35 p.m., Ashutosh Chauhan wrote: > > ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFSurrogateKey.java > > Lines 55 (patched) > > > > > > do udf.setWriteId(3) and call runAndVer

Re: Review Request 68744: Add Surrogate Keys function to Hive

> On Sept. 18, 2018, 8:58 p.m., Antal Sinkovits wrote: > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFSurrogateKey.java > > Lines 116 (patched) > > > > > > You have a potential NPE here, if the execu

Re: Review Request 68744: Add Surrogate Keys function to Hive

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68744/ --- (Updated Sept. 19, 2018, 9:28 a.m.) Review request for hive and Ashutosh Chauha

Re: Review Request 68744: Add Surrogate Keys function to Hive

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68744/#review208739 --- ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFSurro

Re: Review Request 68744: Add Surrogate Keys function to Hive

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68744/ --- (Updated Sept. 18, 2018, 9:35 p.m.) Review request for hive and Ashutosh Chauha

Re: Review Request 68744: Add Surrogate Keys function to Hive

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68744/#review208733 --- ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFSurro